Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v5 18/30] lib/i915/perf: Set missing metric unit for some counters
Date: Thu, 23 Mar 2023 15:55:22 -0700	[thread overview]
Message-ID: <20230323225534.3739835-19-umesh.nerlige.ramappa@intel.com> (raw)
In-Reply-To: <20230323225534.3739835-1-umesh.nerlige.ramappa@intel.com>

Some counters do not have units specified, so use 'number' as the unit.

v2: Drop " from commit description (Kamil)

Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Acked-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
---
 lib/i915/perf-configs/mdapi-xml-convert.py | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/lib/i915/perf-configs/mdapi-xml-convert.py b/lib/i915/perf-configs/mdapi-xml-convert.py
index 3b7d0663..eee12ad5 100755
--- a/lib/i915/perf-configs/mdapi-xml-convert.py
+++ b/lib/i915/perf-configs/mdapi-xml-convert.py
@@ -819,9 +819,14 @@ for arg in args.xml:
             # XXX Not sure why EU metrics tend to just be bundled under 'gpu'
             counter.set('mdapi_hw_unit_type', mdapi_counter.get('HWUnitType').lower())
 
+            # Some counters do not have MetricUnits, treat them as number.
+            if mdapi_counter.get('MetricUnits') == None:
+                units = "number"
+            else:
+                units = mdapi_counter.get('MetricUnits').lower()
+
             # There are counters representing cycle counts that have a semantic
             # type of 'duration' which doesn't seem to make sense...
-            units = mdapi_counter.get('MetricUnits').lower()
             if units == "cycles":
                 semantic_type = "event"
             else:
-- 
2.36.1

  parent reply	other threads:[~2023-03-23 22:55 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-23 22:55 [igt-dev] [PATCH i-g-t v5 00/30] Enable OAM support in IGT and GPUvis Umesh Nerlige Ramappa
2023-03-23 22:55 ` [igt-dev] [PATCH i-g-t v5 01/30] i915/perf: Add support for 64-bit OA formats Umesh Nerlige Ramappa
2023-03-23 22:55 ` [igt-dev] [PATCH i-g-t v5 02/30] i915/perf: Define a default engine for OA Umesh Nerlige Ramappa
2023-03-23 22:55 ` [igt-dev] [PATCH i-g-t v5 03/30] i915/perf: Use default engine for sseu tests Umesh Nerlige Ramappa
2023-03-23 22:55 ` [igt-dev] [PATCH i-g-t v5 04/30] i915/perf: Ensure rcs0 is present for gen12-mi-rpc Umesh Nerlige Ramappa
2023-03-23 22:55 ` [igt-dev] [PATCH i-g-t v5 05/30] i915/perf: Use ARRAY_SIZE for buffer-fill test Umesh Nerlige Ramappa
2023-03-23 22:55 ` [igt-dev] [PATCH i-g-t v5 06/30] i915/perf: Add class:instance support to OA tests Umesh Nerlige Ramappa
2023-03-23 22:55 ` [igt-dev] [PATCH i-g-t v5 07/30] i915/perf: Enable tests to run on specific engines Umesh Nerlige Ramappa
2023-03-23 22:55 ` [igt-dev] [PATCH i-g-t v5 08/30] i915/perf: Treat ticks as 64 bit Umesh Nerlige Ramappa
2023-03-23 22:55 ` [igt-dev] [PATCH i-g-t v5 09/30] i915/perf: Treat timestamp as 64 bit value Umesh Nerlige Ramappa
2023-03-23 22:55 ` [igt-dev] [PATCH i-g-t v5 10/30] i915/perf: Add OAM format type Umesh Nerlige Ramappa
2023-03-23 22:55 ` [igt-dev] [PATCH i-g-t v5 11/30] i915/perf: Move OA format array from stack to heap Umesh Nerlige Ramappa
2023-03-23 22:55 ` [igt-dev] [PATCH i-g-t v5 12/30] i915/perf: Use a helper for OA format Umesh Nerlige Ramappa
2023-03-23 22:55 ` [igt-dev] [PATCH i-g-t v5 13/30] i915/perf: Add support for oa perf groups Umesh Nerlige Ramappa
2023-03-23 22:55 ` [igt-dev] [PATCH i-g-t v5 14/30] i915/perf: Test concurrent access to OA in different groups Umesh Nerlige Ramappa
2023-03-23 22:55 ` [igt-dev] [PATCH i-g-t v5 15/30] i915/perf: Add OAM support Umesh Nerlige Ramappa
2023-03-23 22:55 ` [igt-dev] [PATCH i-g-t v5 16/30] lib/i915/perf: Prepare to read different OA formats Umesh Nerlige Ramappa
2023-03-23 22:55 ` [igt-dev] [PATCH i-g-t v5 17/30] lib/i915/perf: Choose OAM format for media metrics Umesh Nerlige Ramappa
2023-03-23 22:55 ` Umesh Nerlige Ramappa [this message]
2023-03-23 22:55 ` [igt-dev] [PATCH i-g-t v5 19/30] lib/i915/perf: Add MTL to supported HW in OA guid registry Umesh Nerlige Ramappa
2023-03-23 22:55 ` [igt-dev] [PATCH i-g-t v5 20/30] lib/i915/perf: Add support for OAM format in codegen Umesh Nerlige Ramappa
2023-03-23 22:55 ` [igt-dev] [PATCH i-g-t v5 21/30] lib/i915/perf: Update MTL GT2 metrics Umesh Nerlige Ramappa
2023-03-23 22:55 ` [igt-dev] [PATCH i-g-t v5 22/30] lib/i915/perf: Update MTL GT3 metrics Umesh Nerlige Ramappa
2023-03-23 22:55 ` [igt-dev] [PATCH i-g-t v5 23/30] i915/perf: Add support for engine specific metrics Umesh Nerlige Ramappa
2023-03-23 22:55 ` [igt-dev] [PATCH i-g-t v5 24/30] i915/perf: Run non-zero-reason on media engines as well Umesh Nerlige Ramappa
2023-03-23 22:55 ` [igt-dev] [PATCH i-g-t v5 25/30] i915/perf: Make sanity check failures descriptive Umesh Nerlige Ramappa
2023-03-23 22:55 ` [igt-dev] [PATCH i-g-t v5 26/30] lib/i915/perf: Enable multi-tile support for perf library Umesh Nerlige Ramappa
2023-03-23 22:55 ` [igt-dev] [PATCH i-g-t v5 27/30] lib/i915/perf: Update MTL OA timestamp and EU thread config Umesh Nerlige Ramappa
2023-03-23 22:55 ` [igt-dev] [PATCH i-g-t v5 28/30] lib/i915/perf: Add support for select MPEC formats Umesh Nerlige Ramappa
2023-03-23 22:55 ` [igt-dev] [PATCH i-g-t v5 29/30] lib/i915/perf: Adjust the GPU timestamp for new OA formats Umesh Nerlige Ramappa
2023-03-23 22:55 ` [igt-dev] [PATCH i-g-t v5 30/30] lib/i915/perf: Apply shift to raw timestamp as well Umesh Nerlige Ramappa
2023-03-23 23:29 ` [igt-dev] ✓ Fi.CI.BAT: success for Enable OAM support in IGT and GPUvis (rev5) Patchwork
2023-03-24  5:01 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230323225534.3739835-19-umesh.nerlige.ramappa@intel.com \
    --to=umesh.nerlige.ramappa@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox