From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org, swati2.sharma@intel.com,
ankit.k.nautiyal@intel.com, karthik.b.s@intel.com
Subject: [igt-dev] [i-g-t 1/4] lib/igt_kms: Fix Bigjoiner checks
Date: Tue, 28 Mar 2023 16:23:10 +0530 [thread overview]
Message-ID: <20230328105313.3727321-2-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20230328105313.3727321-1-bhanuprakash.modem@intel.com>
Bigjoiner will come in the picture when the resolution > 5K or
clock > max dot-clock. Add a support to check the selected mode
clock is greater than the max dot-clock.
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
lib/igt_kms.c | 39 +++++++++++++++++++++++++++++++++++++--
lib/igt_kms.h | 1 +
2 files changed, 38 insertions(+), 2 deletions(-)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index c12823d318e..3587dc7d7f6 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -5780,6 +5780,36 @@ bool igt_max_bpc_constraint(igt_display_t *display, enum pipe pipe,
return false;
}
+/*
+ * igt_get_max_dotclock:
+ * @fd: A drm file descriptor
+ *
+ * Get the Max pixel clock frequency from intel specific debugfs
+ * "i915_frequency_info".
+ *
+ * Returns: Max supported pixel clock frequency.
+ */
+int igt_get_max_dotclock(int fd)
+{
+ char buf[4096];
+ char *s;
+ int max_dotclock = 0;
+
+ if (!is_i915_device(fd))
+ return max_dotclock;
+
+ igt_debugfs_read(fd, "i915_frequency_info", buf);
+ s = strstr(buf, "Max pixel clock frequency:");
+ igt_assert(s);
+ igt_assert_eq(sscanf(s, "Max pixel clock frequency: %d kHz", &max_dotclock), 1);
+
+ /* 100 Mhz to 5 GHz seem like reasonable values to expect */
+ igt_assert_lt(max_dotclock, 5000000);
+ igt_assert_lt(100000, max_dotclock);
+
+ return max_dotclock;
+}
+
/*
* igt_check_bigjoiner_support:
* @display: a pointer to an #igt_display_t structure
@@ -5802,6 +5832,7 @@ bool igt_check_bigjoiner_support(igt_display_t *display)
enum pipe idx;
drmModeModeInfo *mode;
} pipes[IGT_MAX_PIPES];
+ int max_dotclock;
/* Get total enabled pipes. */
for_each_pipe(display, p)
@@ -5825,6 +5856,8 @@ bool igt_check_bigjoiner_support(igt_display_t *display)
return true;
}
+ max_dotclock = igt_get_max_dotclock(display->drm_fd);
+
/*
* if mode.hdisplay > 5120, then ignore
* - if the consecutive pipe is not available
@@ -5836,11 +5869,13 @@ bool igt_check_bigjoiner_support(igt_display_t *display)
* - current & previous crtcs are consecutive
*/
for (i = 0; i < pipes_in_use; i++) {
- if (((pipes[i].mode->hdisplay > MAX_HDISPLAY_PER_PIPE) &&
+ if (((pipes[i].mode->hdisplay > MAX_HDISPLAY_PER_PIPE ||
+ pipes[i].mode->clock > max_dotclock) &&
((pipes[i].idx >= (total_pipes - 1)) ||
(!display->pipes[pipes[i].idx + 1].enabled) ||
((i < (pipes_in_use - 1)) && (abs(pipes[i + 1].idx - pipes[i].idx) <= 1)))) ||
- ((i > 0) && (pipes[i - 1].mode->hdisplay > MAX_HDISPLAY_PER_PIPE) &&
+ ((i > 0) && (pipes[i - 1].mode->hdisplay > MAX_HDISPLAY_PER_PIPE ||
+ pipes[i - 1].mode->clock > max_dotclock) &&
((!display->pipes[pipes[i - 1].idx + 1].enabled) ||
(abs(pipes[i].idx - pipes[i - 1].idx) <= 1)))) {
igt_debug("Pipe/Output combo is not possible with selected mode(s).\n");
diff --git a/lib/igt_kms.h b/lib/igt_kms.h
index 2b917925158..20a4ced9ad9 100644
--- a/lib/igt_kms.h
+++ b/lib/igt_kms.h
@@ -990,6 +990,7 @@ void igt_sort_connector_modes(drmModeConnector *connector,
bool igt_max_bpc_constraint(igt_display_t *display, enum pipe pipe,
igt_output_t *output, int bpc);
+int igt_get_max_dotclock(int fd);
bool igt_check_bigjoiner_support(igt_display_t *display);
bool igt_parse_mode_string(const char *mode_string, drmModeModeInfo *mode);
bool i915_pipe_output_combo_valid(igt_display_t *display);
--
2.40.0
next prev parent reply other threads:[~2023-03-28 10:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 10:53 [igt-dev] [i-g-t 0/4] Fix Bigjoiner checks Bhanuprakash Modem
2023-03-28 10:53 ` Bhanuprakash Modem [this message]
2023-03-28 11:32 ` [igt-dev] [i-g-t 1/4] lib/igt_kms: " Nautiyal, Ankit K
2023-03-28 10:53 ` [igt-dev] [i-g-t 2/4] tests/i915/kms_big_joiner: " Bhanuprakash Modem
2023-03-28 10:53 ` [igt-dev] [i-g-t 3/4] tests/i915/kms_dsc: Update bigjoiner pipe constraint Bhanuprakash Modem
2023-03-28 10:53 ` [igt-dev] [i-g-t 4/4] tests/kms_invalid_mode: Use helpers from IGT lib Bhanuprakash Modem
2023-03-28 11:54 ` [igt-dev] ✓ Fi.CI.BAT: success for Fix Bigjoiner checks Patchwork
2023-03-28 21:45 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230328105313.3727321-2-bhanuprakash.modem@intel.com \
--to=bhanuprakash.modem@intel.com \
--cc=ankit.k.nautiyal@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=karthik.b.s@intel.com \
--cc=swati2.sharma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox