From: pallavi.mishra@intel.com
To: igt-dev@lists.freedesktop.org, kamil.konieczny@intel.com
Subject: [igt-dev] [PATCH 2/2] [PATCH i-g-t] i915/sysfs_timeslice_duration: skip off subtest for GuC submission
Date: Wed, 29 Mar 2023 10:58:48 +0530 [thread overview]
Message-ID: <20230329052848.1076928-3-pallavi.mishra@intel.com> (raw)
In-Reply-To: <20230329052848.1076928-1-pallavi.mishra@intel.com>
From: Pallavi Mishra <pallavi.mishra@intel.com>
Don't run 'off' section as with GuC submission we don't handle
dynamically changing the timeslice duration from 'off' to 'on' on a
currently running context. This is not bug in GuC submission rather an
architectural decision to not implement this as there is no user aside
from IGTs.
Co-authored-by: Matthew Brost <matthew.brost@intel.com>
Signed-off-by: Pallavi Mishra <pallavi.mishra@intel.com>
---
tests/i915/sysfs_timeslice_duration.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/tests/i915/sysfs_timeslice_duration.c b/tests/i915/sysfs_timeslice_duration.c
index c23424c6..92c4c5ea 100644
--- a/tests/i915/sysfs_timeslice_duration.c
+++ b/tests/i915/sysfs_timeslice_duration.c
@@ -29,6 +29,7 @@
#include <sys/types.h>
#include <unistd.h>
+#include "igt.h"
#include "igt_params.h"
#include "drmtest.h"
#include "i915/gem.h"
@@ -475,6 +476,13 @@ static void test_off(int i915, int engine)
gem_quiescent_gpu(i915);
igt_require(enable_hangcheck(i915, false));
+ /* GuC does not handle dynamic change in timeslice
+ * duration from 'off' to 'on' on a currently
+ * running context. Hence add below check.
+ */
+
+ igt_require(!gem_using_guc_submission(i915));
+
igt_assert(igt_sysfs_scanf(engine, "class", "%u", &class) == 1);
igt_assert(igt_sysfs_scanf(engine, "instance", "%u", &inst) == 1);
--
2.25.1
next prev parent reply other threads:[~2023-03-29 5:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 5:28 [igt-dev] [PATCH i-g-t 0/2] Increase timeout for GuC submission pallavi.mishra
2023-03-29 5:28 ` [igt-dev] [PATCH 1/2] [PATCH i-g-t] tests/i915: " pallavi.mishra
2023-03-29 9:40 ` Kamil Konieczny
2023-03-29 5:28 ` pallavi.mishra [this message]
2023-03-29 9:46 ` [igt-dev] [PATCH 2/2] [PATCH i-g-t] i915/sysfs_timeslice_duration: skip off subtest " Kamil Konieczny
2023-03-29 6:05 ` [igt-dev] ✓ Fi.CI.BAT: success for Increase timeout " Patchwork
2023-03-29 17:00 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230329052848.1076928-3-pallavi.mishra@intel.com \
--to=pallavi.mishra@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=kamil.konieczny@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox