From: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: badal.nilawar@intel.com, arjun.melkaveri@intel.com
Subject: [igt-dev] [PATCH i-g-t 5/7] tests/i915/perf_pmu: Quiesce GPU if measuring idle busyness without spinner
Date: Wed, 29 Mar 2023 17:36:54 -0700 [thread overview]
Message-ID: <20230330003656.1294873-6-umesh.nerlige.ramappa@intel.com> (raw)
In-Reply-To: <20230330003656.1294873-1-umesh.nerlige.ramappa@intel.com>
The assumption in some tests is that the engines are not busy if no
spinners are being run. This is not true in some cases where we see
that the render is busy at the start of the test. Quiesce GPU to wait
for such work to complete before checking for idle busyness.
Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
---
tests/i915/perf_pmu.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/tests/i915/perf_pmu.c b/tests/i915/perf_pmu.c
index 1bea3e57..5185cd9a 100644
--- a/tests/i915/perf_pmu.c
+++ b/tests/i915/perf_pmu.c
@@ -281,10 +281,12 @@ single(int gem_fd, const intel_ctx_t *ctx,
fd = open_pmu(gem_fd, I915_PMU_ENGINE_BUSY(e->class, e->instance));
- if (flags & TEST_BUSY)
+ if (flags & TEST_BUSY) {
spin = spin_sync(gem_fd, ahnd, ctx, e);
- else
+ } else {
spin = NULL;
+ gem_quiescent_gpu(gem_fd);
+ }
val = pmu_read_single(fd);
slept = measured_usleep(batch_duration_ns / 1000);
@@ -644,10 +646,12 @@ no_sema(int gem_fd, const intel_ctx_t *ctx,
fd[1] = open_group(gem_fd, I915_PMU_ENGINE_WAIT(e->class, e->instance),
fd[0]);
- if (flags & TEST_BUSY)
+ if (flags & TEST_BUSY) {
spin = spin_sync(gem_fd, ahnd, ctx, e);
- else
+ } else {
spin = NULL;
+ gem_quiescent_gpu(gem_fd);
+ }
pmu_read_multi(fd[0], 2, val[0]);
measured_usleep(batch_duration_ns / 1000);
--
2.36.1
next prev parent reply other threads:[~2023-03-30 0:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 0:36 [igt-dev] [PATCH i-g-t 0/7] Add MTL PMU support for multi-gt Umesh Nerlige Ramappa
2023-03-30 0:36 ` [igt-dev] [PATCH i-g-t 1/7] lib/debugfs: GT directory helpers Umesh Nerlige Ramappa
2023-03-30 8:49 ` Tvrtko Ursulin
2023-03-30 0:36 ` [igt-dev] [PATCH i-g-t 2/7] tests/i915/perf_pmu: Support multi-tile in rc6 subtest Umesh Nerlige Ramappa
2023-03-30 0:36 ` [igt-dev] [PATCH i-g-t 3/7] tests/i915/perf_pmu: Two new rc6 subtests Umesh Nerlige Ramappa
2023-03-30 0:36 ` [igt-dev] [PATCH i-g-t 4/7] tests/i915/perf_pmu: Support multi-tile in frequency subtest Umesh Nerlige Ramappa
2023-03-30 8:54 ` Tvrtko Ursulin
2023-03-30 0:36 ` Umesh Nerlige Ramappa [this message]
2023-03-30 9:00 ` [igt-dev] [PATCH i-g-t 5/7] tests/i915/perf_pmu: Quiesce GPU if measuring idle busyness without spinner Tvrtko Ursulin
2023-03-30 18:35 ` Umesh Nerlige Ramappa
2023-03-30 0:36 ` [igt-dev] [PATCH i-g-t 6/7] tests/i915/perf_pmu: Use correct pmu config for multi-tile Umesh Nerlige Ramappa
2023-03-30 0:36 ` [igt-dev] [PATCH i-g-t 7/7] tools/intel_gpu_top: Add support for gt specific counters Umesh Nerlige Ramappa
2023-03-30 0:45 ` Umesh Nerlige Ramappa
2023-03-30 9:25 ` Tvrtko Ursulin
2023-03-30 18:43 ` Umesh Nerlige Ramappa
2023-04-26 21:13 ` Umesh Nerlige Ramappa
2023-04-27 14:52 ` Tvrtko Ursulin
2023-03-30 1:23 ` [igt-dev] ✓ Fi.CI.BAT: success for Add MTL PMU support for multi-gt Patchwork
2023-03-30 18:58 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230330003656.1294873-6-umesh.nerlige.ramappa@intel.com \
--to=umesh.nerlige.ramappa@intel.com \
--cc=arjun.melkaveri@intel.com \
--cc=badal.nilawar@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox