Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mauro.chehab@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v3 07/12] scripts/test_list.py: better handle documentation validation issues
Date: Thu, 30 Mar 2023 15:05:13 +0200	[thread overview]
Message-ID: <20230330130518.2731441-8-mauro.chehab@linux.intel.com> (raw)
In-Reply-To: <20230330130518.2731441-1-mauro.chehab@linux.intel.com>

From: Mauro Carvalho Chehab <mchehab@kernel.org>

Produce warnings and exit with an error when test plan is out of sync.

Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
---
 scripts/test_list.py | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/scripts/test_list.py b/scripts/test_list.py
index 73c1794caec5..7d35deda3329 100755
--- a/scripts/test_list.py
+++ b/scripts/test_list.py
@@ -803,16 +803,14 @@ class TestList:
                 run_missing.append(run_test)
 
         if doc_uneeded:
-            print("Unused documentation")
             for test_name in doc_uneeded:
-                print(test_name)
+                print(f"Warning: Documented {test_name} doesn't exist on source files")
 
         if run_missing:
-            if doc_uneeded:
-                print()
-            print("Missing documentation")
             for test_name in run_missing:
-                print(test_name)
+                print(f'Warning: Missing documentation for {test_name}')
+        if doc_uneeded or run_missing:
+            sys.exit(1)
 
     #
     # File handling methods
-- 
2.39.2

  parent reply	other threads:[~2023-03-30 13:06 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-30 13:05 [igt-dev] [PATCH i-g-t v3 00/12] Improve igt_doc.py Mauro Carvalho Chehab
2023-03-30 13:05 ` [igt-dev] [PATCH i-g-t v3 01/12] xe_test_config.json: do some adjustments at the output hierarchy Mauro Carvalho Chehab
2023-03-30 13:05 ` [igt-dev] [PATCH i-g-t v3 02/12] scripts/igt_doc.py: move show_subtests logic to the class Mauro Carvalho Chehab
2023-03-30 13:05 ` [igt-dev] [PATCH i-g-t v3 03/12] scripts/igt_doc.py: add support to generate testlists Mauro Carvalho Chehab
2023-03-30 13:05 ` [igt-dev] [PATCH i-g-t v3 04/12] scripts/igt_doc.py: prepare to place TestList class on a separate file Mauro Carvalho Chehab
2023-03-30 13:05 ` [igt-dev] [PATCH i-g-t v3 05/12] scripts/test_list.py: prepare to place " Mauro Carvalho Chehab
2023-03-30 13:05 ` [igt-dev] [PATCH i-g-t v3 06/12] scripts/igt_doc.py: re-introduce it by calling test_list.py Mauro Carvalho Chehab
2023-03-30 13:05 ` Mauro Carvalho Chehab [this message]
2023-03-30 13:05 ` [igt-dev] [PATCH i-g-t v3 08/12] scripts/test_list.py: add support for igt_simple_main Mauro Carvalho Chehab
2023-03-30 13:05 ` [igt-dev] [PATCH i-g-t v3 09/12] testplan/meson.build: Validate documentation at build time Mauro Carvalho Chehab
2023-03-30 13:05 ` [igt-dev] [PATCH i-g-t v3 10/12] xe/xe_vm: add documentation for igt@xe_vm@userptr-invalid Mauro Carvalho Chehab
2023-03-30 13:05 ` [igt-dev] [PATCH i-g-t v3 11/12] xe/xe_noexec_ping_pong: document subtest Mauro Carvalho Chehab
2023-03-30 13:05 ` [igt-dev] [PATCH i-g-t v3 12/12] runner/meson.build: fix minimal build Mauro Carvalho Chehab
2023-03-31 13:42   ` Kamil Konieczny
2023-03-30 15:46 ` [igt-dev] ✓ Fi.CI.BAT: success for Improve igt_doc.py (rev3) Patchwork
2023-03-31 11:14 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230330130518.2731441-8-mauro.chehab@linux.intel.com \
    --to=mauro.chehab@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox