Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 3/3] xe/xe_create: Add xe_create test
Date: Fri, 31 Mar 2023 11:17:00 +0200	[thread overview]
Message-ID: <20230331091700.69801-4-zbigniew.kempczynski@intel.com> (raw)
In-Reply-To: <20230331091700.69801-1-zbigniew.kempczynski@intel.com>

Add basic test which exercises invalid sizes passed to create ioctl.

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
---
 tests/meson.build    |   1 +
 tests/xe/xe_create.c | 107 +++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 108 insertions(+)
 create mode 100644 tests/xe/xe_create.c

diff --git a/tests/meson.build b/tests/meson.build
index 7d2168beb3..da31e7824b 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -242,6 +242,7 @@ i915_progs = [
 ]
 
 xe_progs = [
+	'xe_create',
 	'xe_compute',
 	'xe_dma_buf_sync',
 	'xe_debugfs',
diff --git a/tests/xe/xe_create.c b/tests/xe/xe_create.c
new file mode 100644
index 0000000000..ae841f8092
--- /dev/null
+++ b/tests/xe/xe_create.c
@@ -0,0 +1,107 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright © 2023 Intel Corporation
+ */
+
+/**
+ * TEST: Check bo create ioctl
+ * Category: Software building block
+ * Sub-category: uapi
+ * Test category: functionality test
+ * Run type: BAT
+ */
+
+#include <string.h>
+
+#include "igt.h"
+#include "xe_drm.h"
+#include "xe/xe_ioctl.h"
+#include "xe/xe_query.h"
+
+#define PAGE_SIZE 0x1000
+
+static int __create_bo(int fd, uint32_t vm, uint64_t size, uint32_t flags,
+		       uint32_t *handlep)
+{
+	struct drm_xe_gem_create create = {
+		.vm_id = vm,
+		.size = size,
+		.flags = flags,
+	};
+	int ret = 0;
+
+	igt_assert(handlep);
+
+	if (igt_ioctl(fd, DRM_IOCTL_XE_GEM_CREATE, &create)) {
+		ret = -errno;
+		errno = 0;
+	}
+	*handlep = create.handle;
+
+	return ret;
+}
+
+/**
+ * SUBTEST: create-invalid-size
+ * Description: Verifies xe bo create returns expected error code on invalid
+ *              buffer sizes.
+ */
+static void create_invalid_size(int fd)
+{
+	struct drm_xe_query_mem_region *memregion;
+	uint64_t memreg = all_memory_regions(fd), region;
+	uint32_t vm;
+	uint32_t handle;
+	int ret;
+
+	vm = xe_vm_create(fd, DRM_XE_VM_CREATE_ASYNC_BIND_OPS, 0);
+
+	xe_for_each_mem_region(fd, memreg, region) {
+		memregion = xe_mem_region(fd, region);
+
+		/* first try, use half of possible min page size */
+		ret = __create_bo(fd, vm, memregion->min_page_size >> 1,
+				  region, &handle);
+		if (!ret) {
+			gem_close(fd, handle);
+			xe_vm_destroy(fd, vm);
+		}
+		igt_assert_eq(ret, -EINVAL);
+
+		/*
+		 * second try, add page size to min page size if it is
+		 * bigger than page size.
+		 */
+		if (memregion->min_page_size > PAGE_SIZE) {
+			ret = __create_bo(fd, vm,
+					  memregion->min_page_size + PAGE_SIZE,
+					  region, &handle);
+			if (!ret) {
+				gem_close(fd, handle);
+				xe_vm_destroy(fd, vm);
+			}
+			igt_assert_eq(ret, -EINVAL);
+		}
+	}
+
+	xe_vm_destroy(fd, vm);
+}
+
+igt_main
+{
+	int xe;
+
+	igt_fixture {
+		xe = drm_open_driver(DRIVER_XE);
+		xe_device_get(xe);
+	}
+
+	igt_subtest("create-invalid-size") {
+		create_invalid_size(xe);
+	}
+
+	igt_fixture {
+		xe_device_put(xe);
+		close(xe);
+	}
+}
-- 
2.34.1

  parent reply	other threads:[~2023-03-31  9:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-31  9:16 [igt-dev] [PATCH i-g-t 0/3] Add xe_create test Zbigniew Kempczyński
2023-03-31  9:16 ` [igt-dev] [PATCH i-g-t 1/3] lib/xe_query: Add xe_for_each_mem_region iterator Zbigniew Kempczyński
2023-03-31  9:16 ` [igt-dev] [PATCH i-g-t 2/3] lib/xe_query: Add memory region getter from region mask Zbigniew Kempczyński
2023-03-31  9:17 ` Zbigniew Kempczyński [this message]
2023-03-31 12:08   ` [igt-dev] [PATCH i-g-t 3/3] xe/xe_create: Add xe_create test Maarten Lankhorst
2023-03-31 10:18 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-04-01  8:32 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230331091700.69801-4-zbigniew.kempczynski@intel.com \
    --to=zbigniew.kempczynski@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox