From: Vikas Srivastava <vikas.srivastava@intel.com>
To: igt-dev@lists.freedesktop.org, karolina.stolarek@intel.com
Subject: [igt-dev] [PATCH i-g-t 4/4 v3] lib/intel_batchbuffer: Enable XY_FAST_COPY_BLT support for api_intel_bb
Date: Fri, 31 Mar 2023 17:51:33 +0530 [thread overview]
Message-ID: <20230331122133.3000215-5-vikas.srivastava@intel.com> (raw)
In-Reply-To: <20230331122133.3000215-1-vikas.srivastava@intel.com>
Test case uses legacy command XY_SRC_COPY_BLT_CMD which is
not supported on newer platforms. Modify test to use
XY_FAST_COPY_BLT.
Signed-off-by: Vikas Srivastava <vikas.srivastava@intel.com>
Cc: Karolina Stolarek <karolina.stolarek@intel.com>
---
lib/intel_batchbuffer.c | 57 ++++++++++++++++++++++++++---------------
1 file changed, 37 insertions(+), 20 deletions(-)
diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
index 40e444ad9b..a4eb4c2bbc 100644
--- a/lib/intel_batchbuffer.c
+++ b/lib/intel_batchbuffer.c
@@ -2409,11 +2409,16 @@ uint32_t intel_bb_copy_data(struct intel_bb *ibb,
*/
void intel_bb_blit_start(struct intel_bb *ibb, uint32_t flags)
{
- intel_bb_out(ibb, XY_SRC_COPY_BLT_CMD |
- XY_SRC_COPY_BLT_WRITE_ALPHA |
- XY_SRC_COPY_BLT_WRITE_RGB |
- flags |
- (6 + 2 * (ibb->gen >= 8)));
+ if (blt_has_xy_src_copy(ibb->i915))
+ intel_bb_out(ibb, XY_SRC_COPY_BLT_CMD |
+ XY_SRC_COPY_BLT_WRITE_ALPHA |
+ XY_SRC_COPY_BLT_WRITE_RGB |
+ flags |
+ (6 + 2 * (ibb->gen >= 8)));
+ else if (blt_has_fast_copy(ibb->i915))
+ intel_bb_out(ibb, XY_FAST_COPY_BLT | flags);
+ else
+ igt_assert_f(0, "No supported blit command found\n");
}
/*
@@ -2451,12 +2456,20 @@ void intel_bb_emit_blt_copy(struct intel_bb *ibb,
if (gen >= 4 && src->tiling != I915_TILING_NONE) {
src_pitch /= 4;
- cmd_bits |= XY_SRC_COPY_BLT_SRC_TILED;
+ if (blt_has_xy_src_copy(ibb->i915))
+ cmd_bits |= XY_SRC_COPY_BLT_SRC_TILED;
+ else if (blt_has_fast_copy(ibb->i915))
+ cmd_bits |= fast_copy_dword0(src->tiling, dst->tiling);
+ else
+ igt_assert_f(0, "No supported blit command found\n");
}
if (gen >= 4 && dst->tiling != I915_TILING_NONE) {
dst_pitch /= 4;
- cmd_bits |= XY_SRC_COPY_BLT_DST_TILED;
+ if (blt_has_xy_src_copy(ibb->i915))
+ cmd_bits |= XY_SRC_COPY_BLT_DST_TILED;
+ else
+ cmd_bits |= fast_copy_dword0(src->tiling, dst->tiling);
}
CHECK_RANGE(src_x1); CHECK_RANGE(src_y1);
@@ -2467,19 +2480,23 @@ void intel_bb_emit_blt_copy(struct intel_bb *ibb,
CHECK_RANGE(src_pitch); CHECK_RANGE(dst_pitch);
br13_bits = 0;
- switch (bpp) {
- case 8:
- break;
- case 16: /* supporting only RGB565, not ARGB1555 */
- br13_bits |= 1 << 24;
- break;
- case 32:
- br13_bits |= 3 << 24;
- cmd_bits |= (XY_SRC_COPY_BLT_WRITE_ALPHA |
- XY_SRC_COPY_BLT_WRITE_RGB);
- break;
- default:
- igt_fail(IGT_EXIT_FAILURE);
+ if (blt_has_xy_src_copy(ibb->i915)) {
+ switch (bpp) {
+ case 8:
+ break;
+ case 16: /* supporting only RGB565, not ARGB1555 */
+ br13_bits |= 1 << 24;
+ break;
+ case 32:
+ br13_bits |= 3 << 24;
+ cmd_bits |= (XY_SRC_COPY_BLT_WRITE_ALPHA |
+ XY_SRC_COPY_BLT_WRITE_RGB);
+ break;
+ default:
+ igt_fail(IGT_EXIT_FAILURE);
+ }
+ } else {
+ br13_bits = fast_copy_dword1(ibb->i915, src->tiling, dst->tiling, bpp);
}
if ((src->tiling | dst->tiling) >= I915_TILING_Y) {
--
2.25.1
next prev parent reply other threads:[~2023-03-31 12:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 12:21 [igt-dev] [PATCH i-g-t 0/4 v3] tests/i915: Enable XY_FAST_COPY_BLT for gen12+ Vikas Srivastava
2023-03-31 12:21 ` [igt-dev] [PATCH i-g-t 1/4 v2] tests/i915/gem_caching: Enable XY_FAST_COPY_BLT for MTL Vikas Srivastava
2023-03-31 12:56 ` Karolina Stolarek
2023-03-31 12:21 ` [igt-dev] [PATCH i-g-t 2/4 v2] tests/i915/gem_userptr_blits: Enable XY_FAST_COPY_BLT command for gen12+ Vikas Srivastava
2023-03-31 12:57 ` Karolina Stolarek
2023-03-31 12:21 ` [igt-dev] [PATCH i-g-t 3/4 v2] tests/i915/gem_linear_blits: Enable XY_FAST_COPY_BLT copy instruction Vikas Srivastava
2023-03-31 12:58 ` Karolina Stolarek
2023-03-31 12:21 ` Vikas Srivastava [this message]
2023-03-31 12:53 ` [igt-dev] [PATCH i-g-t 4/4 v3] lib/intel_batchbuffer: Enable XY_FAST_COPY_BLT support for api_intel_bb Karolina Stolarek
2023-03-31 14:28 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/i915: Enable XY_FAST_COPY_BLT for gen12+ (rev3) Patchwork
2023-04-01 12:51 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230331122133.3000215-5-vikas.srivastava@intel.com \
--to=vikas.srivastava@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=karolina.stolarek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox