Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v2 2/2] tests/drm_fdinfo: Drop active busyness tests for GuC backend
Date: Wed,  5 Apr 2023 00:09:09 +0000	[thread overview]
Message-ID: <20230405000909.51175-3-umesh.nerlige.ramappa@intel.com> (raw)
In-Reply-To: <20230405000909.51175-1-umesh.nerlige.ramappa@intel.com>

With GuC scheduling backends, the context busyness for an active context is
obtained from the GuC FW. The support for this is WIP, so disable tests that
check TEST_BUSY until the feature is implemented.

v2: Drop fixture (Tvrtko)

Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
---
 tests/i915/drm_fdinfo.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/tests/i915/drm_fdinfo.c b/tests/i915/drm_fdinfo.c
index 65b8b830..1b124755 100644
--- a/tests/i915/drm_fdinfo.c
+++ b/tests/i915/drm_fdinfo.c
@@ -197,6 +197,9 @@ single(int gem_fd, const intel_ctx_t *ctx,
 	int spin_fd;
 	uint64_t ahnd;
 
+	if (flags & TEST_BUSY)
+		igt_require(!gem_using_guc_submission(gem_fd));
+
 	if (flags & TEST_ISOLATION) {
 		spin_fd = gem_reopen_driver(gem_fd);
 		ctx = intel_ctx_create_all_physical(spin_fd);
@@ -287,6 +290,8 @@ busy_check_all(int gem_fd, const intel_ctx_t *ctx,
 	igt_spin_t *spin;
 	unsigned int i;
 
+	igt_require(!gem_using_guc_submission(gem_fd));
+
 	memset(tval, 0, sizeof(tval));
 
 	spin = spin_sync(gem_fd, ahnd, ctx, e);
@@ -346,6 +351,8 @@ most_busy_check_all(int gem_fd, const intel_ctx_t *ctx,
 	uint64_t val[16];
 	unsigned int i;
 
+	igt_require(!gem_using_guc_submission(gem_fd));
+
 	memset(busy_class, 0, sizeof(busy_class));
 	memset(tval, 0, sizeof(tval));
 
@@ -404,6 +411,8 @@ all_busy_check_all(int gem_fd, const intel_ctx_t *ctx,
 	uint64_t val[16];
 	unsigned int i;
 
+	igt_require(!gem_using_guc_submission(gem_fd));
+
 	memset(busy_class, 0, sizeof(busy_class));
 	memset(tval, 0, sizeof(tval));
 
@@ -525,6 +534,9 @@ virtual(int i915, const intel_ctx_cfg_t *base_cfg, unsigned int flags)
 {
 	intel_ctx_cfg_t cfg = {};
 
+	if (flags & TEST_BUSY)
+		igt_require(!gem_using_guc_submission(i915));
+
 	cfg.vm = gem_vm_create(i915);
 
 	for (int class = 0; class < 32; class++) {
@@ -624,6 +636,8 @@ virtual_all(int i915, const intel_ctx_cfg_t *base_cfg, unsigned int flags)
 	const unsigned int num_engines = base_cfg->num_engines;
 	intel_ctx_cfg_t cfg = {};
 
+	igt_require(!gem_using_guc_submission(i915));
+
 	cfg.vm = gem_vm_create(i915);
 
 	for (int class = 0; class < 32; class++) {
-- 
2.34.1

  parent reply	other threads:[~2023-04-05  0:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-05  0:09 [igt-dev] [PATCH i-g-t v2 0/2] tests/drm_fdinfo: Drop tests with TEST_BUSY for GuC Umesh Nerlige Ramappa
2023-04-05  0:09 ` [igt-dev] [PATCH i-g-t v2 1/2] lib/drm_fdinfo: Check for compute engines when parsing Umesh Nerlige Ramappa
2023-04-05  0:09 ` Umesh Nerlige Ramappa [this message]
2023-04-05  8:31   ` [igt-dev] [PATCH i-g-t v2 2/2] tests/drm_fdinfo: Drop active busyness tests for GuC backend Tvrtko Ursulin
2023-04-05  0:54 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/drm_fdinfo: Drop tests with TEST_BUSY for GuC (rev2) Patchwork
2023-04-05 10:55 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230405000909.51175-3-umesh.nerlige.ramappa@intel.com \
    --to=umesh.nerlige.ramappa@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox