From: Vikas Srivastava <vikas.srivastava@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 2/4 v3] tests/i915/gem_caching: Enable XY_FAST_COPY_BLT for MTL
Date: Wed, 5 Apr 2023 11:37:08 +0530 [thread overview]
Message-ID: <20230405060710.3476794-3-vikas.srivastava@intel.com> (raw)
In-Reply-To: <20230405060710.3476794-1-vikas.srivastava@intel.com>
Test case uses legacy command XY_SRC_COPY_BLT_CMD which
is not supported on newer platforms. Modify test to
use XY_FAST_COPY_BLT.
Signed-off-by: Vikas Srivastava <vikas.srivastava@intel.com>
Cc: Karolina Stolarek <karolina.stolarek@intel.com>
Reviewed-by: Karolina Stolarek <karolina.stolarek@intel.com>
---
tests/i915/gem_caching.c | 25 +++++++++++++++++--------
1 file changed, 17 insertions(+), 8 deletions(-)
diff --git a/tests/i915/gem_caching.c b/tests/i915/gem_caching.c
index eb0170abca..3783dc2b33 100644
--- a/tests/i915/gem_caching.c
+++ b/tests/i915/gem_caching.c
@@ -39,6 +39,7 @@
#include "i915/gem.h"
#include "igt.h"
+#include "i915/i915_blt.h"
IGT_TEST_DESCRIPTION("Test snoop consistency when touching partial"
" cachelines.");
@@ -82,15 +83,23 @@ copy_bo(struct intel_bb *ibb, struct intel_buf *src, struct intel_buf *dst)
intel_bb_add_intel_buf(ibb, src, false);
intel_bb_add_intel_buf(ibb, dst, true);
- intel_bb_out(ibb,
- XY_SRC_COPY_BLT_CMD |
- XY_SRC_COPY_BLT_WRITE_ALPHA |
- XY_SRC_COPY_BLT_WRITE_RGB |
- (6 + 2 * has_64b_reloc));
+ if (blt_has_xy_src_copy(ibb->i915)) {
+ intel_bb_out(ibb,
+ XY_SRC_COPY_BLT_CMD |
+ XY_SRC_COPY_BLT_WRITE_ALPHA |
+ XY_SRC_COPY_BLT_WRITE_RGB |
+ (6 + 2 * has_64b_reloc));
+
+ intel_bb_out(ibb, (3 << 24) | /* 32 bits */
+ (0xcc << 16) | /* copy ROP */
+ 4096);
+ } else if (blt_has_fast_copy(ibb->i915)) {
+ intel_bb_out(ibb, XY_FAST_COPY_BLT);
+ intel_bb_out(ibb, XY_FAST_COPY_COLOR_DEPTH_32 | 4096);
+ } else {
+ igt_assert_f(0, "No supported blit command found\n");
+ }
- intel_bb_out(ibb, (3 << 24) | /* 32 bits */
- (0xcc << 16) | /* copy ROP */
- 4096);
intel_bb_out(ibb, 0 << 16 | 0);
intel_bb_out(ibb, (BO_SIZE/4096) << 16 | 1024);
intel_bb_emit_reloc_fenced(ibb, dst->handle,
--
2.25.1
next prev parent reply other threads:[~2023-04-05 6:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 6:07 [igt-dev] [PATCH i-g-t 0/4] tests/i915: Enable XY_FAST_COPY_BLT for gen12+ Vikas Srivastava
2023-04-05 6:07 ` [igt-dev] [PATCH i-g-t 1/4 v3] tests/i915/gem_linear_blits: Enable XY_FAST_COPY_BLT copy instruction Vikas Srivastava
2023-04-05 6:07 ` Vikas Srivastava [this message]
2023-04-05 6:07 ` [igt-dev] [PATCH i-g-t 3/4 v3] lib/intel_batchbuffer: Enable XY_FAST_COPY_BLT support for api_intel_bb Vikas Srivastava
2023-04-05 6:07 ` [igt-dev] [PATCH i-g-t 4/4 v3] tests/i915/gem_userptr_blits: Enable XY_FAST_COPY_BLT command for gen12+ Vikas Srivastava
2023-04-05 7:18 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/i915: Enable XY_FAST_COPY_BLT " Patchwork
2023-04-05 15:06 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2023-04-04 6:54 [igt-dev] [PATCH i-g-t 0/4] " Vikas Srivastava
2023-04-04 6:54 ` [igt-dev] [PATCH i-g-t 2/4 v3] tests/i915/gem_caching: Enable XY_FAST_COPY_BLT for MTL Vikas Srivastava
2023-04-03 10:57 [igt-dev] [PATCH i-g-t 0/4] tests/i915: Enable XY_FAST_COPY_BLT for gen12+ Vikas Srivastava
2023-04-03 10:57 ` [igt-dev] [PATCH i-g-t 2/4 v3] tests/i915/gem_caching: Enable XY_FAST_COPY_BLT for MTL Vikas Srivastava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230405060710.3476794-3-vikas.srivastava@intel.com \
--to=vikas.srivastava@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox