Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org, karthik.b.s@intel.com
Subject: [igt-dev] [i-g-t V3 2/6] lib/igt_fb: Add support for allocating buffers for XE
Date: Thu,  6 Apr 2023 13:18:11 +0530	[thread overview]
Message-ID: <20230406074815.463965-3-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20230406074815.463965-1-bhanuprakash.modem@intel.com>

Add support to create a buffer object to the XE driver.

V2: - Use vram_if_possible() (Zbigniew)

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Acked-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Reviewed-by: Karthik B S <karthik.b.s@intel.com>
---
 lib/igt_fb.c | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index ba89e1f60ee..7379b99aa8a 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -49,6 +49,8 @@
 #include "intel_batchbuffer.h"
 #include "intel_chipset.h"
 #include "intel_bufops.h"
+#include "xe/xe_ioctl.h"
+#include "xe/xe_query.h"
 
 /**
  * SECTION:igt_fb
@@ -434,7 +436,7 @@ void igt_get_fb_tile_size(int fd, uint64_t modifier, int fb_bpp,
 
 	switch (modifier) {
 	case DRM_FORMAT_MOD_LINEAR :
-		if (is_i915_device(fd))
+		if (is_intel_device(fd))
 			*width_ret = 64;
 		else
 			*width_ret = 1;
@@ -924,6 +926,9 @@ static uint64_t calc_fb_size(struct igt_fb *fb)
 		size += calc_plane_size(fb, plane);
 	}
 
+	if (is_xe_device(fb->fd))
+		size = ALIGN(size, xe_get_default_alignment(fb->fd));
+
 	return size;
 }
 
@@ -1143,8 +1148,8 @@ static int create_bo_for_fb(struct igt_fb *fb, bool prefer_sysmem)
 	 * them, so we need to make sure to use a device BO then.
 	 */
 	if (fb->modifier || fb->size || fb->strides[0] ||
-	    (is_i915_device(fd) && igt_format_is_yuv(fb->drm_format)) ||
-	    (is_i915_device(fd) && igt_format_is_fp16(fb->drm_format)) ||
+	    (is_intel_device(fd) && igt_format_is_yuv(fb->drm_format)) ||
+	    (is_intel_device(fd) && igt_format_is_fp16(fb->drm_format)) ||
 	    (is_amdgpu_device(fd) && igt_format_is_yuv(fb->drm_format)) ||
 	    is_nouveau_device(fd))
 		device_bo = true;
@@ -1168,6 +1173,9 @@ static int create_bo_for_fb(struct igt_fb *fb, bool prefer_sysmem)
 					       fb->strides[0]);
 			/* If we can't use fences, we won't use ggtt detiling later. */
 			igt_assert(err == 0 || err == -EOPNOTSUPP);
+		} else if (is_xe_device(fd)) {
+			fb->gem_handle = xe_bo_create_flags(fd, 0, fb->size,
+							vram_if_possible(fd, 0));
 		} else if (is_vc4_device(fd)) {
 			fb->gem_handle = igt_vc4_create_bo(fd, fb->size);
 
-- 
2.40.0

  parent reply	other threads:[~2023-04-06  7:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-06  7:48 [igt-dev] [i-g-t V3 0/6] Enable ADDFB tests for XE Bhanuprakash Modem
2023-04-06  7:48 ` [igt-dev] [i-g-t V3 1/6] lib/xe/xe_ioctl: Add a helper to map the buffer Bhanuprakash Modem
2023-04-06  7:48 ` Bhanuprakash Modem [this message]
2023-04-06  7:48 ` [igt-dev] [i-g-t V3 3/6] tests/kms_addfb_basic: Code cleanup Bhanuprakash Modem
2023-04-06 10:01   ` Karthik B S
2023-04-06  7:48 ` [igt-dev] [i-g-t V3 4/6] tests/kms_addfb_basic: Add XE support Bhanuprakash Modem
2023-04-06 10:01   ` Karthik B S
2023-04-06  7:48 ` [igt-dev] [i-g-t V3 5/6] tests/kms_force_connector_basic: Set the param only if driver supports Bhanuprakash Modem
2023-04-06  7:48 ` [igt-dev] [i-g-t V3 6/6] xe-fast-feedback: Add basic kms tests to XE BAT Bhanuprakash Modem
2023-04-06  8:26   ` Karthik B S
2023-04-06  8:36 ` [igt-dev] ✗ Fi.CI.BAT: failure for Enable ADDFB tests for XE (rev4) Patchwork
2023-04-06 10:36 ` [igt-dev] ✓ Fi.CI.BAT: success for Enable ADDFB tests for XE (rev5) Patchwork
2023-04-07  0:32 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230406074815.463965-3-bhanuprakash.modem@intel.com \
    --to=bhanuprakash.modem@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=karthik.b.s@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox