From: Rob Clark <robdclark@gmail.com>
To: igt-dev@lists.freedesktop.org
Cc: Rob Clark <robdclark@chromium.org>,
Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: [igt-dev] [PATCH igt 1/2] lib/igt_drm_fdinfo: Parse memory usage
Date: Fri, 7 Apr 2023 14:56:24 -0700 [thread overview]
Message-ID: <20230407215625.1551410-2-robdclark@gmail.com> (raw)
In-Reply-To: <20230407215625.1551410-1-robdclark@gmail.com>
From: Rob Clark <robdclark@chromium.org>
Add parsing for the memory usage related fdinfo stats.
Signed-off-by: Rob Clark <robdclark@chromium.org>
---
lib/igt_drm_fdinfo.c | 39 +++++++++++++++++++++++++++++++++++++++
lib/igt_drm_fdinfo.h | 9 +++++++++
2 files changed, 48 insertions(+)
diff --git a/lib/igt_drm_fdinfo.c b/lib/igt_drm_fdinfo.c
index b850d221..6269e166 100644
--- a/lib/igt_drm_fdinfo.c
+++ b/lib/igt_drm_fdinfo.c
@@ -124,6 +124,34 @@ static const char *find_kv(const char *buf, const char *key, size_t keylen)
return *p ? p : NULL;
}
+static size_t find_mem_kv(const char *buf, const char *key)
+{
+ const char *val = find_kv(buf, key, strlen(key));
+ char *p, *unit = NULL;
+ size_t sz;
+
+ if (!val)
+ return 0;
+
+ sz = atoi(val);
+
+ p = index(val, ' ');
+ if (!p)
+ return sz;
+
+ unit = ++p;
+
+ if (!strcmp(unit, "KiB")) {
+ sz *= 1024;
+ } else if (!strcmp(unit, "MiB")) {
+ sz *= 1024 * 1024;
+ } else if (!strcmp(unit, "GiB")) {
+ sz *= 1024 * 1024 * 1024;
+ }
+
+ return sz;
+}
+
unsigned int
__igt_parse_drm_fdinfo(int dir, const char *fd, struct drm_client_fdinfo *info,
const char **name_map, unsigned int map_entries)
@@ -140,6 +168,7 @@ __igt_parse_drm_fdinfo(int dir, const char *fd, struct drm_client_fdinfo *info,
while ((l = strtok_r(_buf, "\n", &ctx))) {
uint64_t val = 0;
const char *v;
+ size_t sz;
int idx;
_buf = NULL;
@@ -173,6 +202,16 @@ __igt_parse_drm_fdinfo(int dir, const char *fd, struct drm_client_fdinfo *info,
info->capacity[idx] = val;
num_capacity++;
}
+ } else if ((sz = find_mem_kv(l, "drm-shared-memory"))) {
+ info->mem.shared = sz;
+ } else if ((sz = find_mem_kv(l, "drm-private-memory"))) {
+ info->mem.private = sz;
+ } else if ((sz = find_mem_kv(l, "drm-resident-memory"))) {
+ info->mem.resident = sz;
+ } else if ((sz = find_mem_kv(l, "drm-purgeable-memory"))) {
+ info->mem.purgeable = sz;
+ } else if ((sz = find_mem_kv(l, "drm-active-memory"))) {
+ info->mem.active = sz;
}
}
diff --git a/lib/igt_drm_fdinfo.h b/lib/igt_drm_fdinfo.h
index 6284e05e..dd4bdd54 100644
--- a/lib/igt_drm_fdinfo.h
+++ b/lib/igt_drm_fdinfo.h
@@ -32,6 +32,14 @@
#define DRM_CLIENT_FDINFO_MAX_ENGINES 16
+struct drm_client_meminfo {
+ size_t shared;
+ size_t private;
+ size_t resident;
+ size_t purgeable;
+ size_t active;
+};
+
struct drm_client_fdinfo {
char driver[128];
char pdev[128];
@@ -42,6 +50,7 @@ struct drm_client_fdinfo {
unsigned int capacity[DRM_CLIENT_FDINFO_MAX_ENGINES];
char names[DRM_CLIENT_FDINFO_MAX_ENGINES][256];
uint64_t busy[DRM_CLIENT_FDINFO_MAX_ENGINES];
+ struct drm_client_meminfo mem;
};
/**
--
2.39.2
next prev parent reply other threads:[~2023-04-07 21:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-07 21:56 [igt-dev] [PATCH igt 0/2] gputop memory information Rob Clark
2023-04-07 21:56 ` Rob Clark [this message]
2023-04-13 15:18 ` [igt-dev] [PATCH igt 1/2] lib/igt_drm_fdinfo: Parse memory usage Tvrtko Ursulin
2023-04-13 18:26 ` Rob Clark
2023-04-14 8:27 ` Tvrtko Ursulin
2023-04-07 21:56 ` [igt-dev] [PATCH igt 2/2] gputop: Add memory information Rob Clark
2023-04-13 15:27 ` Tvrtko Ursulin
2023-04-07 22:10 ` [igt-dev] ✗ Fi.CI.BUILD: failure for gputop " Patchwork
2023-05-22 16:58 ` [igt-dev] ✗ Fi.CI.BUILD: failure for gputop memory information (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230407215625.1551410-2-robdclark@gmail.com \
--to=robdclark@gmail.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=robdclark@chromium.org \
--cc=tvrtko.ursulin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox