From: Mauro Carvalho Chehab <mauro.chehab@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v3 3/4] scripts/test_list.py: use a compiled regex for check
Date: Thu, 13 Apr 2023 11:21:58 +0200 [thread overview]
Message-ID: <20230413092159.146658-4-mauro.chehab@linux.intel.com> (raw)
In-Reply-To: <20230413092159.146658-1-mauro.chehab@linux.intel.com>
From: Mauro Carvalho Chehab <mchehab@kernel.org>
Speed up even further the logic for --check-testlist by
pre-compiling the regex that will be used to validate the
results.
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
---
scripts/test_list.py | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/scripts/test_list.py b/scripts/test_list.py
index 287351e717b3..96d8883db122 100755
--- a/scripts/test_list.py
+++ b/scripts/test_list.py
@@ -820,10 +820,18 @@ class TestList:
run_missing = []
doc_uneeded = []
+ test_regex = r""
+ for doc_test in doc_subtests:
+ if test_regex != r"":
+ test_regex += r"|"
+ test_regex += r'^' + doc_test + r'$'
+
+ test_regex = re.compile(test_regex)
+
for doc_test in doc_subtests:
found = False
for run_test in run_subtests:
- if re.match(r'^' + doc_test + r'$', run_test):
+ if re.match(test_regex, run_test):
found = True
break
if not found:
@@ -831,10 +839,8 @@ class TestList:
for run_test in run_subtests:
found = False
- for doc_test in doc_subtests:
- if re.match(r'^' + doc_test + r'$', run_test):
- found = True
- break
+ if re.match(test_regex, run_test):
+ found = True
if not found:
run_missing.append(run_test)
--
2.39.2
next prev parent reply other threads:[~2023-04-13 9:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 9:21 [igt-dev] [PATCH i-g-t v3 0/4] ./scripts/igt_doc.py: speedup check logic Mauro Carvalho Chehab
2023-04-13 9:21 ` [igt-dev] [PATCH i-g-t v3 1/4] scripts/igt_doc.py: cleanup some pylint warnings Mauro Carvalho Chehab
2023-04-13 13:06 ` Kamil Konieczny
2023-04-13 9:21 ` [igt-dev] [PATCH i-g-t v3 2/4] scripts/igt_doc.py: don't depend on igt_runner anymore Mauro Carvalho Chehab
2023-04-13 13:07 ` Kamil Konieczny
2023-04-13 9:21 ` Mauro Carvalho Chehab [this message]
2023-04-13 13:08 ` [igt-dev] [PATCH i-g-t v3 3/4] scripts/test_list.py: use a compiled regex for check Kamil Konieczny
2023-04-13 9:21 ` [igt-dev] [PATCH i-g-t v3 4/4] meson_options.txt: disable Sphinx by default Mauro Carvalho Chehab
2023-04-13 10:10 ` Kamil Konieczny
2023-04-13 13:24 ` Mauro Carvalho Chehab
2023-04-21 15:37 ` Kamil Konieczny
2023-04-13 10:34 ` [igt-dev] ✓ Fi.CI.BAT: success for ./scripts/igt_doc.py: speedup check logic Patchwork
2023-04-13 12:01 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230413092159.146658-4-mauro.chehab@linux.intel.com \
--to=mauro.chehab@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox