From: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org,
Chris Wilson <chris.p.wilson@linux.intel.com>,
Nirmoy Das <nirmoy.das@intel.com>
Subject: [igt-dev] [PATCH i-g-t] tests/gem_reset_stats: Don't allow request watchdog to interfere
Date: Thu, 13 Apr 2023 16:36:26 +0200 [thread overview]
Message-ID: <20230413143626.311639-1-janusz.krzysztofik@linux.intel.com> (raw)
A user reported recently that some subtests are failing. The test was
blocklisted in 2018, so we've lost CI feedback on its results since then.
In 2021, request watchdog with 20 seconds timeout was introduced to i915.
Kernel logs from failed subtest runs indicate that the request watchdog
interfers with engine heartbeat and request preemption used by the test
for exercising reset statistics.
Disable request watchdog during the test execution.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/8310
Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
---
tests/i915/gem_reset_stats.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/tests/i915/gem_reset_stats.c b/tests/i915/gem_reset_stats.c
index baa101517d..7b003d88b6 100644
--- a/tests/i915/gem_reset_stats.c
+++ b/tests/i915/gem_reset_stats.c
@@ -906,6 +906,7 @@ igt_main
igt_fixture {
bool has_reset_stats;
bool using_full_reset;
+ char *tmp;
device = drm_open_driver(DRIVER_INTEL);
devid = intel_get_drm_devid(device);
@@ -922,6 +923,12 @@ igt_main
"No reset stats ioctl support. Too old kernel?\n");
igt_require_f(using_full_reset,
"Full GPU reset is not enabled. Is enable_hangcheck set?\n");
+
+ /* Don't allow request watchdog to interfere */
+ tmp = __igt_params_get(device, "request_timeout_ms");
+ if (tmp && atoi(tmp))
+ igt_params_save_and_set(device, "request_timeout_ms", "%u", 0);
+ free(tmp);
}
igt_subtest("params")
--
2.25.1
next reply other threads:[~2023-04-13 14:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 14:36 Janusz Krzysztofik [this message]
2023-04-13 15:28 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/gem_reset_stats: Don't allow request watchdog to interfere Patchwork
2023-04-13 15:31 ` [igt-dev] [PATCH i-g-t] " Andrzej Hajda
2023-04-14 11:47 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-04-14 16:38 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230413143626.311639-1-janusz.krzysztofik@linux.intel.com \
--to=janusz.krzysztofik@linux.intel.com \
--cc=chris.p.wilson@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=nirmoy.das@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox