Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [i-g-t 5/7] tests/kms_flip: Add XE support
Date: Thu, 13 Apr 2023 21:57:30 +0530	[thread overview]
Message-ID: <20230413162732.1155058-6-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20230413162732.1155058-1-bhanuprakash.modem@intel.com>

Add XE driver support for kms tests.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_flip.c | 35 ++++++++++++++++++++++++++---------
 1 file changed, 26 insertions(+), 9 deletions(-)

diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index 5e82f4a2f84..5f5e84ba27c 100755
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -44,6 +44,7 @@
 
 #include "i915/gem_create.h"
 #include "igt_stats.h"
+#include "xe/xe_query.h"
 
 #define TEST_DPMS		(1 << 0)
 
@@ -792,7 +793,8 @@ static bool run_test_step(struct test_output *o, unsigned int *events)
 
 	memset(&hang, 0, sizeof(hang));
 	if (do_flip && (o->flags & TEST_HANG)) {
-		igt_require_intel(drm_fd);
+		igt_require_i915(drm_fd);
+		/* TODO: Add XE support? */
 		ahnd = get_reloc_ahnd(drm_fd, 0);
 		hang = hang_gpu(drm_fd, ahnd);
 	}
@@ -1347,15 +1349,21 @@ restart:
 		o->fb_width *= 2;
 
 	modifier = DRM_FORMAT_MOD_LINEAR;
-	if (o->flags & TEST_FENCE_STRESS)
+	if (o->flags & TEST_FENCE_STRESS) {
+		igt_skip_on(!is_i915_device(drm_fd));
 		modifier = I915_FORMAT_MOD_X_TILED;
+	}
 
 	/* 256 MB is usually the maximum mappable aperture,
 	 * (make it 4x times that to ensure failure) */
 	if (o->flags & TEST_BO_TOOBIG) {
-		igt_skip_on(!is_i915_device(drm_fd));
+		igt_skip_on(!is_intel_device(drm_fd));
 		bo_size = 4*gem_mappable_aperture_size(drm_fd);
-		igt_require(bo_size < gem_global_aperture_size(drm_fd));
+
+		if (is_i915_device(drm_fd))
+			igt_require(bo_size < gem_global_aperture_size(drm_fd));
+		else
+			igt_require(bo_size < (1ULL << xe_va_bits(drm_fd)));
 	}
 
 	o->fb_ids[0] = igt_create_fb(drm_fd, o->fb_width, o->fb_height,
@@ -1557,9 +1565,10 @@ static int run_test(int duration, int flags)
 	struct test_output o;
 	int i, n, modes = 0;
 
-	igt_require((flags & TEST_HANG) == 0 || !is_wedged(drm_fd));
+	igt_require((flags & TEST_HANG) == 0 ||
+		    (is_i915_device(drm_fd) && !is_wedged(drm_fd)));
 	igt_require(!(flags & TEST_FENCE_STRESS) ||
-		    gem_available_fences(drm_fd));
+		    (is_i915_device(drm_fd) && gem_available_fences(drm_fd)));
 
 	resources = drmModeGetResources(drm_fd);
 	igt_require(resources);
@@ -1626,9 +1635,10 @@ static int run_pair(int duration, int flags)
 	struct test_output o;
 	int i, j, m, n, modes = 0;
 
-	igt_require((flags & TEST_HANG) == 0 || !is_wedged(drm_fd));
+	igt_require((flags & TEST_HANG) == 0 ||
+		    (is_i915_device(drm_fd) && !is_wedged(drm_fd)));
 	igt_require(!(flags & TEST_FENCE_STRESS) ||
-		    gem_available_fences(drm_fd));
+		    (is_i915_device(drm_fd) && gem_available_fences(drm_fd)));
 
 	resources = drmModeGetResources(drm_fd);
 	igt_require(resources);
@@ -1813,6 +1823,9 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
 		igt_install_exit_handler(kms_flip_exit_handler);
 		get_timestamp_format();
 
+		if (is_xe_device(drm_fd))
+			xe_device_get(drm_fd);
+
 		if (is_i915_device(drm_fd)) {
 			bops = buf_ops_create(drm_fd);
 		}
@@ -1878,6 +1891,10 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
 	}
 	igt_stop_signal_helper();
 
-	igt_fixture
+	igt_fixture {
+		if (is_xe_device(drm_fd))
+			xe_device_put(drm_fd);
+
 		close(drm_fd);
+	}
 }
-- 
2.40.0

  parent reply	other threads:[~2023-04-13 16:32 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-13 16:27 [igt-dev] [i-g-t 0/7] Enable KMS tests in XE BAT Bhanuprakash Modem
2023-04-13 16:27 ` [igt-dev] [i-g-t 1/7] lib/intel_bufops: Fix bops creation to support XE Bhanuprakash Modem
2023-04-17 10:57   ` Zbigniew Kempczyński
2023-04-13 16:27 ` [igt-dev] [i-g-t 2/7] lib/igt_fb: Add copy engine support for XE Bhanuprakash Modem
2023-04-13 16:27 ` [igt-dev] [i-g-t 3/7] lib: Use i915 namespace for XE debugfs Bhanuprakash Modem
2023-04-17  5:07   ` Karthik B S
2023-04-17  7:05   ` [igt-dev] [i-g-t V2 " Bhanuprakash Modem
2023-04-17 10:59   ` [igt-dev] [i-g-t " Zbigniew Kempczyński
2023-04-13 16:27 ` [igt-dev] [i-g-t 4/7] tests/kms_cursor_legacy: Add XE support Bhanuprakash Modem
2023-04-17  5:03   ` Karthik B S
2023-04-13 16:27 ` Bhanuprakash Modem [this message]
2023-04-18  9:34   ` [igt-dev] [i-g-t 5/7] tests/kms_flip: " Karthik B S
2023-04-13 16:27 ` [igt-dev] [i-g-t 6/7] tests/i915/kms_psr: " Bhanuprakash Modem
2023-04-13 16:27 ` [igt-dev] [i-g-t 7/7] xe-fast-feedback: Add kms tests to XE BAT Bhanuprakash Modem
2023-04-18  9:38   ` Karthik B S
2023-04-13 17:39 ` [igt-dev] ✓ Fi.CI.BAT: success for Enable KMS tests in " Patchwork
2023-04-13 22:11 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-04-17 11:01 ` [igt-dev] ✓ Fi.CI.BAT: success for Enable KMS tests in XE BAT (rev2) Patchwork
2023-04-17 16:43 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230413162732.1155058-6-bhanuprakash.modem@intel.com \
    --to=bhanuprakash.modem@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox