From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [i-g-t V4 4/6] tests/kms_invalid_mode: Use helpers from IGT lib
Date: Fri, 14 Apr 2023 19:23:17 +0530 [thread overview]
Message-ID: <20230414135319.1270913-5-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20230414135319.1270913-1-bhanuprakash.modem@intel.com>
Instead of writing own logic at test level, use existing IGT
helper to read the max dot clock.
V2: - Rebase
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Karthik B S <karthik.b.s@intel.com>
---
tests/kms_invalid_mode.c | 38 +-------------------------------------
1 file changed, 1 insertion(+), 37 deletions(-)
diff --git a/tests/kms_invalid_mode.c b/tests/kms_invalid_mode.c
index 6ef36d3cc98..ec048305567 100644
--- a/tests/kms_invalid_mode.c
+++ b/tests/kms_invalid_mode.c
@@ -213,42 +213,6 @@ test_output(data_t *data)
igt_remove_fb(data->drm_fd, &fb);
}
-static int i915_max_dotclock(data_t *data)
-{
- char buf[4096];
- char *s;
- int dir, res, max_dotclock = 0;
-
- if (!is_i915_device(data->drm_fd))
- return 0;
-
- dir = igt_debugfs_dir(data->drm_fd);
- igt_require(dir);
-
- /*
- * Display specific clock frequency info is moved to i915_cdclk_info,
- * On older kernels if this debugfs is not found, fallback to read from
- * i915_frequency_info.
- */
- res = igt_debugfs_simple_read(dir, "i915_cdclk_info",
- buf, sizeof(buf));
- if (res <= 0)
- res = igt_debugfs_simple_read(dir, "i915_frequency_info",
- buf, sizeof(buf));
- close(dir);
-
- igt_require(res > 0);
-
- igt_assert(s = strstr(buf, "Max pixel clock frequency:"));
- igt_assert_eq(sscanf(s, "Max pixel clock frequency: %d kHz", &max_dotclock), 1);
-
- /* 100 Mhz to 5 GHz seem like reasonable values to expect */
- igt_assert_lt(max_dotclock, 5000000);
- igt_assert_lt(100000, max_dotclock);
-
- return max_dotclock;
-}
-
static const struct {
const char *name;
bool (*adjust_mode)(data_t *data, drmModeModeInfoPtr mode);
@@ -308,7 +272,7 @@ igt_main
data.res = drmModeGetResources(data.drm_fd);
igt_assert(data.res);
- data.max_dotclock = i915_max_dotclock(&data);
+ data.max_dotclock = igt_get_max_dotclock(data.drm_fd);
igt_info("Max dotclock: %d kHz\n", data.max_dotclock);
}
--
2.40.0
next prev parent reply other threads:[~2023-04-14 13:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 13:53 [igt-dev] [i-g-t V4 0/6] Fix Bigjoiner checks Bhanuprakash Modem
2023-04-14 13:53 ` [igt-dev] [i-g-t V4 1/6] lib/igt_kms: " Bhanuprakash Modem
2023-04-14 13:53 ` [igt-dev] [i-g-t V4 2/6] tests/i915/kms_big_joiner: " Bhanuprakash Modem
2023-04-17 6:45 ` Nautiyal, Ankit K
2023-04-14 13:53 ` [igt-dev] [i-g-t V4 3/6] tests/i915/kms_dsc: Update bigjoiner pipe constraint Bhanuprakash Modem
2023-04-14 13:53 ` Bhanuprakash Modem [this message]
2023-04-14 13:53 ` [igt-dev] [i-g-t V4 5/6] tests/kms_flip: Fix Bigjoiner checks Bhanuprakash Modem
2023-04-17 7:30 ` Nautiyal, Ankit K
2023-04-14 13:53 ` [igt-dev] [i-g-t V4 6/6] tests/kms_setmode: " Bhanuprakash Modem
2023-04-17 7:33 ` Nautiyal, Ankit K
2023-04-14 14:59 ` [igt-dev] ✓ Fi.CI.BAT: success for Fix Bigjoiner checks (rev6) Patchwork
2023-04-14 21:16 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230414135319.1270913-5-bhanuprakash.modem@intel.com \
--to=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox