Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 09/10] lib/gpgpu_fill: Use RENDER engine flag to work on Xe
Date: Mon, 17 Apr 2023 17:36:01 +0200	[thread overview]
Message-ID: <20230417153602.104298-10-zbigniew.kempczynski@intel.com> (raw)
In-Reply-To: <20230417153602.104298-1-zbigniew.kempczynski@intel.com>

Using I915_EXEC_DEFAULT works fine for i915 selecting appropriate
command streamer. Unfortunately this cannot be used on Xe as it
requires explicit engine selection. Submitting gpgpu work on
render is fine so change to I915_EXEC_RENDER doesn't break i915
and allows run on valid engine on Xe.

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
---
 lib/gpgpu_fill.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/gpgpu_fill.c b/lib/gpgpu_fill.c
index 4f7bab68f2..4db8775145 100644
--- a/lib/gpgpu_fill.c
+++ b/lib/gpgpu_fill.c
@@ -288,7 +288,7 @@ __gen9_gpgpu_fillfunc(int i915,
 	intel_bb_ptr_align(ibb, 32);
 
 	intel_bb_exec(ibb, intel_bb_offset(ibb),
-		      I915_EXEC_DEFAULT | I915_EXEC_NO_RELOC, true);
+		      I915_EXEC_RENDER | I915_EXEC_NO_RELOC, true);
 
 	intel_bb_destroy(ibb);
 }
@@ -329,7 +329,7 @@ __xehp_gpgpu_fillfunc(int i915,
 	intel_bb_ptr_align(ibb, 32);
 
 	intel_bb_exec(ibb, intel_bb_offset(ibb),
-		      I915_EXEC_DEFAULT | I915_EXEC_NO_RELOC, true);
+		      I915_EXEC_RENDER | I915_EXEC_NO_RELOC, true);
 
 	intel_bb_destroy(ibb);
 }
-- 
2.34.1

  parent reply	other threads:[~2023-04-17 15:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-17 15:35 [igt-dev] [PATCH i-g-t 00/10] Integrate intel-bb with Xe Zbigniew Kempczyński
2023-04-17 15:35 ` [igt-dev] [PATCH i-g-t 01/10] lib/xe_ioctl: Add missing header for direct resolving Zbigniew Kempczyński
2023-04-17 15:35 ` [igt-dev] [PATCH i-g-t 02/10] lib/xe_query: Add region helpers and missing doc Zbigniew Kempczyński
2023-04-17 15:35 ` [igt-dev] [PATCH i-g-t 03/10] lib/xe_query: Remove commented out function prototype Zbigniew Kempczyński
2023-04-17 15:35 ` [igt-dev] [PATCH i-g-t 04/10] lib/intel_allocator: Add allocator support for Xe Zbigniew Kempczyński
2023-04-17 15:35 ` [igt-dev] [PATCH i-g-t 05/10] lib/intel_bufops: Add Xe support in bufops Zbigniew Kempczyński
2023-04-17 15:35 ` [igt-dev] [PATCH i-g-t 06/10] lib/intel_batchbuffer: Add Xe support in intel-bb Zbigniew Kempczyński
2023-04-17 15:35 ` [igt-dev] [PATCH i-g-t 07/10] tests/xe_intel_bb: Check if intel-bb Xe support correctness Zbigniew Kempczyński
2023-04-17 15:36 ` [igt-dev] [PATCH i-g-t 08/10] tests/xe-fast-feedback: Add xe_intel_bb test to BAT Zbigniew Kempczyński
2023-04-17 15:36 ` Zbigniew Kempczyński [this message]
2023-04-17 15:36 ` [igt-dev] [PATCH i-g-t 10/10] tests/xe_gpgpu_fill: Exercise gpgpu fill on Xe Zbigniew Kempczyński
2023-04-17 16:46 ` [igt-dev] ✓ Fi.CI.BAT: success for Integrate intel-bb with Xe Patchwork
2023-04-18  2:03 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230417153602.104298-10-zbigniew.kempczynski@intel.com \
    --to=zbigniew.kempczynski@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox