Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v5 11/11] lib/igt_fb: For xe assume vram is used on discrete
Date: Mon, 24 Apr 2023 09:39:07 +0200	[thread overview]
Message-ID: <20230424073907.158701-12-zbigniew.kempczynski@intel.com> (raw)
In-Reply-To: <20230424073907.158701-1-zbigniew.kempczynski@intel.com>

Assume fb bo's were created on vram on discrete, otherwise use system
memory.

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
---
 lib/igt_fb.c | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index 7379b99aa8..2c1d48783a 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -2545,6 +2545,7 @@ igt_fb_create_intel_buf(int fd, struct buf_ops *bops,
 {
 	struct intel_buf *buf;
 	uint32_t bo_name, handle, compression;
+	uint64_t region;
 	int num_surfaces;
 	int i;
 
@@ -2571,12 +2572,15 @@ igt_fb_create_intel_buf(int fd, struct buf_ops *bops,
 	bo_name = gem_flink(fd, fb->gem_handle);
 	handle = gem_open(fd, bo_name);
 
-	buf = intel_buf_create_using_handle_and_size(bops, handle,
-						     fb->width, fb->height,
-						     fb->plane_bpp[0], 0,
-						     igt_fb_mod_to_tiling(fb->modifier),
-						     compression, fb->size,
-						     fb->strides[0]);
+	/* For i915 region doesn't matter, for xe does */
+	region = is_i915_device(fd) ? 0 : vram_if_possible(fd, 0);
+	buf = intel_buf_create_full(bops, handle,
+				    fb->width, fb->height,
+				    fb->plane_bpp[0], 0,
+				    igt_fb_mod_to_tiling(fb->modifier),
+				    compression, fb->size,
+				    fb->strides[0],
+				    region);
 	intel_buf_set_name(buf, name);
 
 	/* Make sure we close handle on destroy path */
-- 
2.34.1

  parent reply	other threads:[~2023-04-24  7:39 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-24  7:38 [igt-dev] [PATCH i-g-t v5 00/11] Integrate intel-bb with Xe Zbigniew Kempczyński
2023-04-24  7:38 ` [igt-dev] [PATCH i-g-t v5 01/11] lib/xe_ioctl: Add missing header for direct resolving Zbigniew Kempczyński
2023-04-24  7:38 ` [igt-dev] [PATCH i-g-t v5 02/11] lib/xe_query: Add region helpers and missing doc Zbigniew Kempczyński
2023-04-24  7:38 ` [igt-dev] [PATCH i-g-t v5 03/11] lib/xe_query: Remove commented out function prototype Zbigniew Kempczyński
2023-04-24  7:39 ` [igt-dev] [PATCH i-g-t v5 04/11] lib/intel_allocator: Add allocator support for Xe Zbigniew Kempczyński
2023-04-24  7:39 ` [igt-dev] [PATCH i-g-t v5 05/11] lib/intel_bufops: Add Xe support in bufops Zbigniew Kempczyński
2023-04-24 15:38   ` Manszewski, Christoph
2023-04-24  7:39 ` [igt-dev] [PATCH i-g-t v5 06/11] lib/intel_batchbuffer: Add Xe support in intel-bb Zbigniew Kempczyński
2023-04-24 11:26   ` Kamil Konieczny
2023-04-24 14:14     ` Manszewski, Christoph
2023-04-24 16:35       ` Kamil Konieczny
2023-04-25  3:13         ` Zbigniew Kempczyński
2023-04-25  2:54     ` Zbigniew Kempczyński
2023-04-24 15:42   ` Manszewski, Christoph
2023-04-24  7:39 ` [igt-dev] [PATCH i-g-t v5 07/11] tests/xe_intel_bb: Check if intel-bb Xe support correctness Zbigniew Kempczyński
2023-04-24  7:39 ` [igt-dev] [PATCH i-g-t v5 08/11] tests/xe-fast-feedback: Add xe_intel_bb test to BAT Zbigniew Kempczyński
2023-04-24  7:39 ` [igt-dev] [PATCH i-g-t v5 09/11] lib/gpgpu_fill: Use RENDER engine flag to work on Xe Zbigniew Kempczyński
2023-04-24  7:39 ` [igt-dev] [PATCH i-g-t v5 10/11] tests/xe_gpgpu_fill: Exercise gpgpu fill " Zbigniew Kempczyński
2023-04-24  7:39 ` Zbigniew Kempczyński [this message]
2023-04-24 11:27   ` [igt-dev] [PATCH i-g-t v5 11/11] lib/igt_fb: For xe assume vram is used on discrete Kamil Konieczny
2023-04-25  3:17     ` Zbigniew Kempczyński
2023-04-24 10:38 ` [igt-dev] ✗ Fi.CI.BAT: failure for Integrate intel-bb with Xe (rev6) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230424073907.158701-12-zbigniew.kempczynski@intel.com \
    --to=zbigniew.kempczynski@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox