From: "Maíra Canal" <mcanal@igalia.com>
To: Melissa Wen <mwen@igalia.com>,
Petri Latvala <adrinael@adrinael.net>,
Kamil Konieczny <kamil.konieczny@linux.intel.com>,
Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>,
Swati Sharma <swati2.sharma@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 2/3] tests/kms_plane_scaling: fix variable misspelling
Date: Mon, 24 Apr 2023 15:33:59 -0300 [thread overview]
Message-ID: <20230424183400.465464-2-mcanal@igalia.com> (raw)
In-Reply-To: <20230424183400.465464-1-mcanal@igalia.com>
As the function test_scaler_with_multi_pipe_plane() intends to test two
planes, it is necessary to check the output of both planes, not only
one. Therefore, instead of checking the variable ret1 twice, check the
variable ret2.
Fixes: 56bedcde ("tests/kms_plane_scaling: Cleanup")
Signed-off-by: Maíra Canal <mcanal@igalia.com>
---
tests/kms_plane_scaling.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index 302fffcd..7f5cb00d 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -926,7 +926,7 @@ static void test_scaler_with_multi_pipe_plane(data_t *d)
cleanup_fbs(d);
igt_skip_on_f(ret1 == -ERANGE || ret1 == -EINVAL ||
- ret2 == -ERANGE || ret1 == -EINVAL,
+ ret2 == -ERANGE || ret2 == -EINVAL,
"Scaling op is not supported by driver\n");
igt_assert_eq(ret1 && ret2, 0);
}
--
2.40.0
next prev parent reply other threads:[~2023-04-24 18:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 18:33 [igt-dev] [PATCH i-g-t 1/3] tests/kms_plane_scaling: negative tests can return -EINVAL or -ERANGE Maíra Canal
2023-04-24 18:33 ` Maíra Canal [this message]
2023-04-25 7:55 ` [igt-dev] [PATCH i-g-t 2/3] tests/kms_plane_scaling: fix variable misspelling Kamil Konieczny
2023-04-24 18:34 ` [igt-dev] [PATCH i-g-t 3/3] tests/kms_plane_scaling: remove unused parameters Maíra Canal
2023-04-25 9:09 ` Kamil Konieczny
2023-04-24 19:50 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] tests/kms_plane_scaling: negative tests can return -EINVAL or -ERANGE Patchwork
2023-04-25 0:23 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-04-25 9:00 ` [igt-dev] [PATCH i-g-t 1/3] " Kamil Konieczny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230424183400.465464-2-mcanal@igalia.com \
--to=mcanal@igalia.com \
--cc=adrinael@adrinael.net \
--cc=igt-dev@lists.freedesktop.org \
--cc=juhapekka.heikkila@gmail.com \
--cc=kamil.konieczny@linux.intel.com \
--cc=mwen@igalia.com \
--cc=swati2.sharma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox