From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [i-g-t V2 12/40] lib/igt_fb: Add copy engine support for XE
Date: Tue, 25 Apr 2023 12:19:25 +0530 [thread overview]
Message-ID: <20230425064953.2121947-13-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20230425064953.2121947-1-bhanuprakash.modem@intel.com>
Add copy engine support for kms framebuffer mappings.
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
lib/igt_fb.c | 30 ++++++++++++++++++++++++++----
lib/igt_fb.h | 2 ++
2 files changed, 28 insertions(+), 4 deletions(-)
diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index 2c1d48783..93fdca681 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -45,6 +45,7 @@
#include "igt_amd.h"
#include "igt_x86.h"
#include "igt_nouveau.h"
+#include "igt_syncobj.h"
#include "ioctl_wrappers.h"
#include "intel_batchbuffer.h"
#include "intel_chipset.h"
@@ -2489,12 +2490,13 @@ static bool blitter_ok(const struct igt_fb *fb)
static bool use_enginecopy(const struct igt_fb *fb)
{
- if (blitter_ok(fb))
+ if (!is_xe_device(fb->fd) && blitter_ok(fb))
return false;
return fb->modifier == I915_FORMAT_MOD_Yf_TILED ||
is_ccs_modifier(fb->modifier) ||
- !gem_has_mappable_ggtt(fb->fd);
+ (is_xe_device(fb->fd) && fb->modifier == DRM_FORMAT_MOD_LINEAR) ||
+ (is_i915_device(fb->fd) && !gem_has_mappable_ggtt(fb->fd));
}
static bool use_blitter(const struct igt_fb *fb)
@@ -2504,7 +2506,7 @@ static bool use_blitter(const struct igt_fb *fb)
return fb->modifier == I915_FORMAT_MOD_Y_TILED ||
fb->modifier == I915_FORMAT_MOD_Yf_TILED ||
- !gem_has_mappable_ggtt(fb->fd);
+ (is_i915_device(fb->fd) && !gem_has_mappable_ggtt(fb->fd));
}
static void init_buf_ccs(struct intel_buf *buf, int ccs_idx,
@@ -2705,7 +2707,7 @@ static void blitcopy(const struct igt_fb *dst_fb,
src_tiling = igt_fb_mod_to_tiling(src_fb->modifier);
dst_tiling = igt_fb_mod_to_tiling(dst_fb->modifier);
- if (!gem_has_relocations(dst_fb->fd)) {
+ if (is_i915_device(dst_fb->fd) && !gem_has_relocations(dst_fb->fd)) {
igt_require(gem_has_contexts(dst_fb->fd));
ctx = gem_context_create(dst_fb->fd);
ahnd = get_reloc_ahnd(dst_fb->fd, ctx);
@@ -2785,6 +2787,12 @@ static void free_linear_mapping(struct fb_blit_upload *blit)
} else if (is_nouveau_device(fd)) {
igt_nouveau_fb_blit(fb, &linear->fb);
igt_nouveau_delete_bo(&linear->fb);
+ } else if (is_xe_device(fd)) {
+ gem_munmap(linear->map, linear->fb.size);
+ copy_with_engine(blit, fb, &linear->fb);
+
+ syncobj_wait(fd, &blit->ibb->engine_syncobj, 1, INT64_MAX, 0, NULL);
+ gem_close(fd, linear->fb.gem_handle);
} else {
gem_munmap(linear->map, linear->fb.size);
gem_set_domain(fd, linear->fb.gem_handle,
@@ -2862,6 +2870,11 @@ static void setup_linear_mapping(struct fb_blit_upload *blit)
igt_nouveau_fb_blit(&linear->fb, fb);
linear->map = igt_nouveau_mmap_bo(&linear->fb, PROT_READ | PROT_WRITE);
+ } else if (is_xe_device(fd)) {
+ copy_with_engine(blit, &linear->fb, fb);
+
+ linear->map = xe_bo_mmap_ext(fd, linear->fb.gem_handle,
+ linear->fb.size, PROT_READ | PROT_WRITE);
} else {
/* Copy fb content to linear BO */
gem_set_domain(fd, linear->fb.gem_handle,
@@ -2919,6 +2932,9 @@ static void create_cairo_surface__gpu(int fd, struct igt_fb *fb)
*/
int igt_dirty_fb(int fd, struct igt_fb *fb)
{
+ if (fb->syncobj)
+ syncobj_wait(fd, &fb->syncobj, 1, INT64_MAX, 0, NULL);
+
return drmModeDirtyFB(fb->fd, fb->fb_id, NULL, 0);
}
@@ -2968,6 +2984,9 @@ static void *map_bo(int fd, struct igt_fb *fb)
PROT_READ | PROT_WRITE);
else if (is_nouveau_device(fd))
ptr = igt_nouveau_mmap_bo(fb, PROT_READ | PROT_WRITE);
+ else if (is_xe_device(fd))
+ ptr = xe_bo_mmap_ext(fd, fb->gem_handle,
+ fb->size, PROT_READ | PROT_WRITE);
else
igt_assert(false);
@@ -4252,6 +4271,9 @@ void igt_remove_fb(int fd, struct igt_fb *fb)
if (!fb || !fb->fb_id)
return;
+ if (fb->syncobj)
+ syncobj_destroy(fd, fb->syncobj);
+
cairo_surface_destroy(fb->cairo_surface);
do_or_die(drmModeRmFB(fd, fb->fb_id));
if (fb->is_dumb)
diff --git a/lib/igt_fb.h b/lib/igt_fb.h
index 73bdfc866..a127a8128 100644
--- a/lib/igt_fb.h
+++ b/lib/igt_fb.h
@@ -62,6 +62,7 @@ typedef struct _igt_crc igt_crc_t;
* @fb_id: KMS ID of the framebuffer
* @fd: DRM device fd this framebuffer is created on
* @gem_handle: GEM handler of the underlying backing storage
+ * @syncobj: Syncobj to sync to for last drawing operation
* @is_dumb: Whether this framebuffer was allocated using the dumb buffer API
* @drm_format: DRM FOURCC code
* @width: width in pixels
@@ -84,6 +85,7 @@ typedef struct igt_fb {
uint32_t fb_id;
int fd;
uint32_t gem_handle;
+ uint32_t syncobj;
bool is_dumb;
uint32_t drm_format;
int width;
--
2.40.0
next prev parent reply other threads:[~2023-04-25 6:54 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 6:49 [igt-dev] [i-g-t V2 00/40] Add IGT display support for XE Bhanuprakash Modem
2023-04-25 6:49 ` [igt-dev] [i-g-t V2 01/40] lib/xe_ioctl: Add missing header for direct resolving Bhanuprakash Modem
2023-04-25 6:49 ` [igt-dev] [i-g-t V2 02/40] lib/xe_query: Add region helpers and missing doc Bhanuprakash Modem
2023-04-25 6:49 ` [igt-dev] [i-g-t V2 03/40] lib/xe_query: Remove commented out function prototype Bhanuprakash Modem
2023-04-25 6:49 ` [igt-dev] [i-g-t V2 04/40] lib/intel_allocator: Add allocator support for Xe Bhanuprakash Modem
2023-04-25 6:49 ` [igt-dev] [i-g-t V2 05/40] lib/intel_bufops: Add Xe support in bufops Bhanuprakash Modem
2023-04-25 6:49 ` [igt-dev] [i-g-t V2 06/40] lib/intel_batchbuffer: Add Xe support in intel-bb Bhanuprakash Modem
2023-04-25 6:49 ` [igt-dev] [i-g-t V2 07/40] tests/xe_intel_bb: Check if intel-bb Xe support correctness Bhanuprakash Modem
2023-04-25 6:49 ` [igt-dev] [i-g-t V2 08/40] tests/xe-fast-feedback: Add xe_intel_bb test to BAT Bhanuprakash Modem
2023-04-25 6:49 ` [igt-dev] [i-g-t V2 09/40] lib/gpgpu_fill: Use RENDER engine flag to work on Xe Bhanuprakash Modem
2023-04-25 6:49 ` [igt-dev] [i-g-t V2 10/40] tests/xe_gpgpu_fill: Exercise gpgpu fill " Bhanuprakash Modem
2023-04-25 6:49 ` [igt-dev] [i-g-t V2 11/40] lib/igt_fb: For xe assume vram is used on discrete Bhanuprakash Modem
2023-04-25 6:49 ` Bhanuprakash Modem [this message]
2023-04-26 6:39 ` [igt-dev] [i-g-t V2 12/40] lib/igt_fb: Add copy engine support for XE Sharma, Swati2
2023-04-25 6:49 ` [igt-dev] [i-g-t V2 13/40] lib/igt_draw: Add gpu draw routine " Bhanuprakash Modem
2023-04-26 2:30 ` [igt-dev] [i-g-t, V2, " Gupta, Nidhi1
2023-04-26 6:40 ` Modem, Bhanuprakash
2023-04-26 7:15 ` [igt-dev] [i-g-t V2 " Sharma, Swati2
2023-04-25 6:49 ` [igt-dev] [i-g-t V2 14/40] tests/i915/kms_big_fb: Add XE support Bhanuprakash Modem
2023-04-25 6:49 ` [igt-dev] [i-g-t V2 15/40] tests/i915/kms_big_joiner: " Bhanuprakash Modem
2023-04-25 9:16 ` [igt-dev] [i-g-t, V2, " Gupta, Nidhi1
2023-04-25 6:49 ` [igt-dev] [i-g-t V2 16/40] tests/i915/kms_cdclk: " Bhanuprakash Modem
2023-04-25 6:49 ` [igt-dev] [i-g-t V2 17/40] tests/i915/kms_draw_crc: " Bhanuprakash Modem
2023-04-26 2:06 ` [igt-dev] [i-g-t, V2, " Gupta, Nidhi1
2023-04-25 6:49 ` [igt-dev] [i-g-t V2 18/40] tests/i915/kms_dsc: " Bhanuprakash Modem
2023-04-25 6:49 ` [igt-dev] [i-g-t V2 19/40] tests/i915/kms_flip_scaled_crc: " Bhanuprakash Modem
2023-04-25 6:49 ` [igt-dev] [i-g-t V2 20/40] tests/i915/kms_flip_tiling: " Bhanuprakash Modem
2023-04-25 6:49 ` [igt-dev] [i-g-t V2 21/40] tests/i915/kms_mmap_write_crc: " Bhanuprakash Modem
2023-04-25 9:19 ` Karthik B S
2023-04-25 9:26 ` [igt-dev] [i-g-t, V2, " Joshi, Kunal1
2023-04-25 6:49 ` [igt-dev] [i-g-t V2 22/40] tests/kms_3d: " Bhanuprakash Modem
2023-04-25 9:23 ` Karthik B S
2023-04-25 6:49 ` [igt-dev] [i-g-t V2 23/40] tests/kms_async_flips: No " Bhanuprakash Modem
2023-04-25 6:49 ` [igt-dev] [i-g-t V2 24/40] tests/kms_atomic_transition: Add " Bhanuprakash Modem
2023-04-26 6:21 ` Sharma, Swati2
2023-04-25 6:49 ` [igt-dev] [i-g-t V2 25/40] tests/color: " Bhanuprakash Modem
2023-04-25 6:49 ` [igt-dev] [i-g-t V2 26/40] tests/kms_concurrent: " Bhanuprakash Modem
2023-04-25 6:49 ` [igt-dev] [i-g-t V2 27/40] tests/kms_content_protection: " Bhanuprakash Modem
2023-04-25 6:49 ` [igt-dev] [i-g-t V2 28/40] tests/kms_cursor_crc: " Bhanuprakash Modem
2023-04-25 9:28 ` [igt-dev] [i-g-t, V2, " Joshi, Kunal1
2023-04-25 6:49 ` [igt-dev] [i-g-t V2 29/40] tests/kms_flip_event_leak: " Bhanuprakash Modem
2023-04-25 9:44 ` [igt-dev] [i-g-t, V2, " Joshi, Kunal1
2023-04-25 6:49 ` [igt-dev] [i-g-t V2 30/40] tests/kms_getfb: " Bhanuprakash Modem
2023-04-25 10:09 ` [igt-dev] [i-g-t,V2,30/40] " Joshi, Kunal1
2023-04-25 6:49 ` [igt-dev] [i-g-t V2 31/40] tests/kms_hdmi_inject: " Bhanuprakash Modem
2023-04-25 9:19 ` [igt-dev] [i-g-t, V2, " Joshi, Kunal1
2023-04-25 6:49 ` [igt-dev] [i-g-t V2 32/40] tests/kms_hdr: " Bhanuprakash Modem
2023-04-25 6:49 ` [igt-dev] [i-g-t V2 33/40] tests/kms_panel_fitting: " Bhanuprakash Modem
2023-04-25 6:49 ` [igt-dev] [i-g-t V2 34/40] tests/kms_plane: " Bhanuprakash Modem
2023-04-25 10:12 ` [igt-dev] [i-g-t,V2,34/40] " Joshi, Kunal1
2023-04-25 6:49 ` [igt-dev] [i-g-t V2 35/40] tests/kms_plane_lowers: " Bhanuprakash Modem
2023-04-25 9:50 ` [igt-dev] [i-g-t, V2, " Joshi, Kunal1
2023-04-25 6:49 ` [igt-dev] [i-g-t V2 36/40] tests/kms_plane_scaling: " Bhanuprakash Modem
2023-04-25 10:03 ` [igt-dev] [i-g-t, V2, " Joshi, Kunal1
2023-04-25 6:49 ` [igt-dev] [i-g-t V2 37/40] tests/kms_prime: " Bhanuprakash Modem
2023-04-25 9:00 ` [igt-dev] [i-g-t V3 " Bhanuprakash Modem
2023-04-25 9:14 ` Bhanuprakash Modem
2023-04-26 4:57 ` Sharma, Swati2
2023-04-25 6:49 ` [igt-dev] [i-g-t V2 38/40] tests/kms_rotation_crc: " Bhanuprakash Modem
2023-04-26 7:48 ` Sharma, Swati2
2023-04-26 10:54 ` Modem, Bhanuprakash
2023-04-25 6:49 ` [igt-dev] [i-g-t V2 39/40] tests/kms_setmode: " Bhanuprakash Modem
2023-04-25 9:22 ` [igt-dev] [i-g-t,V2,39/40] " Gupta, Nidhi1
2023-04-25 6:49 ` [igt-dev] [i-g-t V2 40/40] tests/kms_universal_plane: " Bhanuprakash Modem
2023-04-25 7:39 ` [igt-dev] ✗ Fi.CI.BAT: failure for Add IGT display support for XE (rev2) Patchwork
2023-04-25 10:26 ` [igt-dev] ✗ Fi.CI.BAT: failure for Add IGT display support for XE (rev4) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230425064953.2121947-13-bhanuprakash.modem@intel.com \
--to=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox