From: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v6 13/15] lib/igt_fb: For xe assume vram is used on discrete
Date: Tue, 25 Apr 2023 17:40:15 +0200 [thread overview]
Message-ID: <20230425154017.374465-14-zbigniew.kempczynski@intel.com> (raw)
In-Reply-To: <20230425154017.374465-1-zbigniew.kempczynski@intel.com>
Assume fb bo's were created on vram on discrete, otherwise use system
memory.
Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
---
lib/igt_fb.c | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index 7379b99aa8..76f2e12456 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -2545,6 +2545,7 @@ igt_fb_create_intel_buf(int fd, struct buf_ops *bops,
{
struct intel_buf *buf;
uint32_t bo_name, handle, compression;
+ uint64_t region;
int num_surfaces;
int i;
@@ -2571,12 +2572,16 @@ igt_fb_create_intel_buf(int fd, struct buf_ops *bops,
bo_name = gem_flink(fd, fb->gem_handle);
handle = gem_open(fd, bo_name);
- buf = intel_buf_create_using_handle_and_size(bops, handle,
- fb->width, fb->height,
- fb->plane_bpp[0], 0,
- igt_fb_mod_to_tiling(fb->modifier),
- compression, fb->size,
- fb->strides[0]);
+ /* For i915 region doesn't matter, for xe does */
+ region = buf_ops_get_driver(bops) == INTEL_DRIVER_XE ?
+ vram_if_possible(fd, 0) : 0;
+ buf = intel_buf_create_full(bops, handle,
+ fb->width, fb->height,
+ fb->plane_bpp[0], 0,
+ igt_fb_mod_to_tiling(fb->modifier),
+ compression, fb->size,
+ fb->strides[0],
+ region);
intel_buf_set_name(buf, name);
/* Make sure we close handle on destroy path */
--
2.34.1
next prev parent reply other threads:[~2023-04-25 15:41 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 15:40 [igt-dev] [PATCH i-g-t v6 00/15] Integrate intel-bb with Xe Zbigniew Kempczyński
2023-04-25 15:40 ` [igt-dev] [PATCH i-g-t v6 01/15] lib/xe_ioctl: Add missing header for direct resolving Zbigniew Kempczyński
2023-04-25 15:40 ` [igt-dev] [PATCH i-g-t v6 02/15] lib/xe_query: Add region helpers and missing doc Zbigniew Kempczyński
2023-04-25 15:40 ` [igt-dev] [PATCH i-g-t v6 03/15] lib/xe_query: Remove commented out function prototype Zbigniew Kempczyński
2023-04-25 15:40 ` [igt-dev] [PATCH i-g-t v6 04/15] lib/intel_allocator: Add allocator support for Xe Zbigniew Kempczyński
2023-04-25 15:40 ` [igt-dev] [PATCH i-g-t v6 05/15] lib/drmtest: Add driver enum for i915/xe Zbigniew Kempczyński
2023-04-26 8:23 ` Manszewski, Christoph
2023-04-26 9:03 ` Manszewski, Christoph
2023-04-26 9:51 ` Zbigniew Kempczyński
2023-04-25 15:40 ` [igt-dev] [PATCH i-g-t v6 06/15] lib/intel_bufops: Add Xe support in bufops Zbigniew Kempczyński
2023-04-26 12:18 ` Manszewski, Christoph
2023-04-26 20:08 ` Zbigniew Kempczyński
2023-04-26 14:02 ` Kamil Konieczny
2023-04-26 20:10 ` Zbigniew Kempczyński
2023-04-25 15:40 ` [igt-dev] [PATCH i-g-t v6 07/15] lib/intel_batchbuffer: Rename i915 -> fd as preparation step for xe Zbigniew Kempczyński
2023-04-26 9:28 ` Manszewski, Christoph
2023-04-25 15:40 ` [igt-dev] [PATCH i-g-t v6 08/15] lib/intel_batchbuffer: Add Xe support in intel-bb Zbigniew Kempczyński
2023-04-25 18:27 ` Zbigniew Kempczyński
2023-04-26 9:59 ` Manszewski, Christoph
2023-04-26 10:52 ` Zbigniew Kempczyński
2023-04-26 12:47 ` Kamil Konieczny
2023-04-26 14:23 ` Manszewski, Christoph
2023-04-27 8:25 ` Zbigniew Kempczyński
2023-04-25 15:40 ` [igt-dev] [PATCH i-g-t v6 09/15] tests/xe_intel_bb: Check if intel-bb Xe support correctness Zbigniew Kempczyński
2023-04-25 15:40 ` [igt-dev] [PATCH i-g-t v6 10/15] tests/xe-fast-feedback: Add xe_intel_bb test to BAT Zbigniew Kempczyński
2023-04-25 15:40 ` [igt-dev] [PATCH i-g-t v6 11/15] lib/gpgpu_fill: Use RENDER engine flag to work on Xe Zbigniew Kempczyński
2023-04-25 15:40 ` [igt-dev] [PATCH i-g-t v6 12/15] tests/xe_gpgpu_fill: Exercise gpgpu fill " Zbigniew Kempczyński
2023-04-25 15:40 ` Zbigniew Kempczyński [this message]
2023-04-27 6:44 ` [igt-dev] [PATCH i-g-t v6 13/15] lib/igt_fb: For xe assume vram is used on discrete Modem, Bhanuprakash
2023-04-27 9:04 ` Zbigniew Kempczyński
2023-04-25 15:40 ` [igt-dev] [PATCH i-g-t v6 14/15] lib/igt_draw: Pass region while building intel_buf from flink Zbigniew Kempczyński
2023-04-27 6:41 ` Modem, Bhanuprakash
2023-04-25 15:40 ` [igt-dev] [PATCH i-g-t v6 15/15] tests/kms_big_fb: Deduce region for xe framebuffer Zbigniew Kempczyński
2023-04-27 6:40 ` Modem, Bhanuprakash
2023-04-25 19:24 ` [igt-dev] ✗ Fi.CI.BAT: failure for Integrate intel-bb with Xe (rev7) Patchwork
2023-04-25 21:54 ` [igt-dev] ✗ Fi.CI.BAT: failure for Integrate intel-bb with Xe (rev8) Patchwork
2023-04-26 8:23 ` [igt-dev] ✓ Fi.CI.BAT: success for Integrate intel-bb with Xe (rev9) Patchwork
2023-04-26 9:28 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230425154017.374465-14-zbigniew.kempczynski@intel.com \
--to=zbigniew.kempczynski@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox