From: Hersen Wu <hersenxs.wu@amd.com>
To: <igt-dev@lists.freedesktop.org>, <rodrigo.siqueira@amd.com>,
<aurabindo.pillai@amd.com>, <alex.hung@amd.com>,
<hamza.mahfooz@amd.com>
Cc: Hersen Wu <hersenxs.wu@amd.com>
Subject: [igt-dev] [PATCH] [i-g-t] tests/amdgpu/amd_link_settings: use mode 640x480 for link configuration test
Date: Tue, 25 Apr 2023 17:47:10 -0400 [thread overview]
Message-ID: <20230425214710.179129-1-hersenxs.wu@amd.com> (raw)
with 4k dp connected, amdgpu kernel warning message dp_blank timeout
happens intermittently. link configuration <1, 1.62> could not support
4k mode. dp safe mode 640x480@60hz could be used for all link
configuration test.
video timing bw in bits: pixel_clock x bits_per_color x 3
dp lane bw in bits: link_rate x lane_count x 8 / 10
Signed-off-by: Hersen Wu <hersenxs.wu@amd.com>
---
tests/amdgpu/amd_link_settings.c | 22 +++++++++++++++++++++-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/tests/amdgpu/amd_link_settings.c b/tests/amdgpu/amd_link_settings.c
index 14c8c4d7..28aa5da5 100644
--- a/tests/amdgpu/amd_link_settings.c
+++ b/tests/amdgpu/amd_link_settings.c
@@ -159,6 +159,21 @@ static void run_link_training_config(data_t *data, igt_output_t *output)
}
}
+static const drmModeModeInfo dp_safe_mode_640_480 = {
+ .name = "640x480",
+ .vrefresh = 60,
+ .clock = 25200,
+ .hdisplay = 640,
+ .hsync_start = 656,
+ .hsync_end = 752,
+ .htotal = 800,
+ .vdisplay = 480,
+ .vsync_start = 490,
+ .vsync_end = 492,
+ .vtotal = 525,
+ .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
+};
+
static void test_link_training_configs(data_t *data)
{
const drmModeModeInfo *orig_mode;
@@ -177,7 +192,12 @@ static void test_link_training_configs(data_t *data)
/* Init only if display supports link_settings */
test_init(data, output);
- orig_mode = igt_output_get_mode(output);
+ /* run_link_training_config run test from <1, 1.62>
+ * to highest link configuration. to make sure mode timing
+ * be fitted into <1, 1.62> and higher configuration, use
+ * dp safe mode 640x480@60hz
+ */
+ orig_mode = &dp_safe_mode_640_480;
igt_assert(orig_mode);
igt_output_override_mode(output, orig_mode);
--
2.25.1
next reply other threads:[~2023-04-25 21:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 21:47 Hersen Wu [this message]
2023-04-25 22:53 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/amdgpu/amd_link_settings: use mode 640x480 for link configuration test (rev4) Patchwork
2023-04-25 22:57 ` [igt-dev] [PATCH] [i-g-t] tests/amdgpu/amd_link_settings: use mode 640x480 for link configuration test Alex Hung
2023-06-14 19:26 ` [igt-dev] ✗ GitLab.Pipeline: warning for tests/amdgpu/amd_link_settings: use mode 640x480 for link configuration test (rev5) Patchwork
2023-06-14 19:49 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-06-14 21:55 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2023-04-25 21:44 [igt-dev] [PATCH] [i-g-t] tests/amdgpu/amd_link_settings: use mode 640x480 for link configuration test Hersen Wu
2023-04-24 16:32 Hersen Wu
2023-04-24 14:16 Hersen Wu
2023-04-24 16:46 ` Rodrigo Siqueira Jordao
2023-04-24 19:08 ` Wu, Hersen
2023-04-25 21:32 ` Wu, Hersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230425214710.179129-1-hersenxs.wu@amd.com \
--to=hersenxs.wu@amd.com \
--cc=alex.hung@amd.com \
--cc=aurabindo.pillai@amd.com \
--cc=hamza.mahfooz@amd.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=rodrigo.siqueira@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox