Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v7 16/16] tests/kms_big_fb: Deduce region for xe framebuffer
Date: Thu, 27 Apr 2023 22:03:07 +0200	[thread overview]
Message-ID: <20230427200307.240349-17-zbigniew.kempczynski@intel.com> (raw)
In-Reply-To: <20230427200307.240349-1-zbigniew.kempczynski@intel.com>

For discrete framebuffer reside on vram/device memory and for
integrated on system memory. Due to xe requirement regarding
size and alignment on different memory regions during intel_buf
creation pass deduced memory region.

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Reviewed-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/i915/kms_big_fb.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/tests/i915/kms_big_fb.c b/tests/i915/kms_big_fb.c
index a29a05a282..a0d5ef7301 100644
--- a/tests/i915/kms_big_fb.c
+++ b/tests/i915/kms_big_fb.c
@@ -28,6 +28,7 @@
 #include <string.h>
 
 #include "i915/gem_create.h"
+#include "xe/xe_query.h"
 
 IGT_TEST_DESCRIPTION("Test big framebuffers");
 
@@ -62,7 +63,10 @@ static struct intel_buf *init_buf(data_t *data,
 				  const char *buf_name)
 {
 	struct intel_buf *buf;
+	enum intel_driver driver = buf_ops_get_driver(data->bops);
 	uint32_t name, handle, tiling, stride, width, height, bpp, size;
+	uint64_t region = driver == INTEL_DRIVER_XE ?
+				vram_if_possible(data->drm_fd, 0) : -1;
 
 	igt_assert_eq(fb->offsets[0], 0);
 
@@ -75,8 +79,10 @@ static struct intel_buf *init_buf(data_t *data,
 
 	name = gem_flink(data->drm_fd, fb->gem_handle);
 	handle = gem_open(data->drm_fd, name);
-	buf = intel_buf_create_using_handle(data->bops, handle, width, height,
-					    bpp, 0, tiling, 0);
+	buf = intel_buf_create_full(data->bops, handle, width, height,
+				    bpp, 0, tiling, 0, size, 0,
+				    region);
+
 	intel_buf_set_name(buf, buf_name);
 	intel_buf_set_ownership(buf, true);
 
-- 
2.34.1

  parent reply	other threads:[~2023-04-27 20:06 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-27 20:02 [igt-dev] [PATCH i-g-t v7 00/16] Integrate intel-bb with Xe Zbigniew Kempczyński
2023-04-27 20:02 ` [igt-dev] [PATCH i-g-t v7 01/16] lib/xe_ioctl: Add missing header for direct resolving Zbigniew Kempczyński
2023-04-27 20:02 ` [igt-dev] [PATCH i-g-t v7 02/16] lib/xe_query: Add region helpers and missing doc Zbigniew Kempczyński
2023-04-27 20:02 ` [igt-dev] [PATCH i-g-t v7 03/16] lib/xe_query: Remove commented out function prototype Zbigniew Kempczyński
2023-04-27 20:02 ` [igt-dev] [PATCH i-g-t v7 04/16] lib/intel_allocator: Add allocator support for Xe Zbigniew Kempczyński
2023-04-27 20:02 ` [igt-dev] [PATCH i-g-t v7 05/16] lib/drmtest: Add driver enum for i915/xe Zbigniew Kempczyński
2023-04-27 20:02 ` [igt-dev] [PATCH i-g-t v7 06/16] lib/intel_bufops: Add Xe support in bufops Zbigniew Kempczyński
2023-04-27 20:02 ` [igt-dev] [PATCH i-g-t v7 07/16] lib/intel_batchbuffer: Rename i915 -> fd as preparation step for xe Zbigniew Kempczyński
2023-04-27 20:02 ` [igt-dev] [PATCH i-g-t v7 08/16] lib/intel_batchbuffer: Update intel-bb docs Zbigniew Kempczyński
2023-04-27 20:03 ` [igt-dev] [PATCH i-g-t v7 09/16] lib/intel_batchbuffer: Add Xe support in intel-bb Zbigniew Kempczyński
2023-04-27 20:03 ` [igt-dev] [PATCH i-g-t v7 10/16] tests/xe_intel_bb: Check if intel-bb Xe support correctness Zbigniew Kempczyński
2023-04-27 20:03 ` [igt-dev] [PATCH i-g-t v7 11/16] tests/xe-fast-feedback: Add xe_intel_bb test to BAT Zbigniew Kempczyński
2023-04-27 20:03 ` [igt-dev] [PATCH i-g-t v7 12/16] lib/gpgpu_fill: Use RENDER engine flag to work on Xe Zbigniew Kempczyński
2023-04-27 20:03 ` [igt-dev] [PATCH i-g-t v7 13/16] tests/xe_gpgpu_fill: Exercise gpgpu fill " Zbigniew Kempczyński
2023-04-27 20:03 ` [igt-dev] [PATCH i-g-t v7 14/16] lib/igt_fb: For xe assume vram is used on discrete Zbigniew Kempczyński
2023-04-28  5:58   ` Modem, Bhanuprakash
2023-04-27 20:03 ` [igt-dev] [PATCH i-g-t v7 15/16] lib/igt_draw: Pass region while building intel_buf from flink Zbigniew Kempczyński
2023-04-27 20:03 ` Zbigniew Kempczyński [this message]
2023-04-27 20:42 ` [igt-dev] ✓ Fi.CI.BAT: success for Integrate intel-bb with Xe (rev10) Patchwork
2023-04-28  3:08 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230427200307.240349-17-zbigniew.kempczynski@intel.com \
    --to=zbigniew.kempczynski@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox