Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v8 08/17] lib/intel_batchbuffer: Reacquire offset for reloc allocator in reset path
Date: Fri, 28 Apr 2023 08:22:15 +0200	[thread overview]
Message-ID: <20230428062224.21322-9-zbigniew.kempczynski@intel.com> (raw)
In-Reply-To: <20230428062224.21322-1-zbigniew.kempczynski@intel.com>

On reset path we recreate bo for batch (to avoid stalls) so we should
reacquire the offset too. At the moment simple allocator will return
same offset (so unfortunately we'll stall), but for reloc allocator
we'll get new one (so we avoid stall).

I've noticed this is missing during xe_intel_bb test, where on reloc
I noticed unexpected result (direct consequence of using same offset
which pointed to old batch, not new one).

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
---
 lib/intel_batchbuffer.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
index 7dbd6dd582..99b0b61585 100644
--- a/lib/intel_batchbuffer.c
+++ b/lib/intel_batchbuffer.c
@@ -1280,8 +1280,9 @@ void intel_bb_reset(struct intel_bb *ibb, bool purge_objects_cache)
 	gem_close(ibb->fd, ibb->handle);
 	ibb->handle = gem_create(ibb->fd, ibb->size);
 
-	/* Keep address for bb in reloc mode and RANDOM allocator */
-	if (ibb->allocator_type == INTEL_ALLOCATOR_SIMPLE)
+	/* Reacquire offset for RELOC and SIMPLE */
+	if (ibb->allocator_type == INTEL_ALLOCATOR_SIMPLE ||
+	    ibb->allocator_type == INTEL_ALLOCATOR_RELOC)
 		ibb->batch_offset = __intel_bb_get_offset(ibb,
 							  ibb->handle,
 							  ibb->size,
-- 
2.34.1

  parent reply	other threads:[~2023-04-28  6:22 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-28  6:22 [igt-dev] [PATCH i-g-t v8 00/17] Integrate intel-bb with Xe Zbigniew Kempczyński
2023-04-28  6:22 ` [igt-dev] [PATCH i-g-t v8 01/17] lib/xe_ioctl: Add missing header for direct resolving Zbigniew Kempczyński
2023-04-28  6:22 ` [igt-dev] [PATCH i-g-t v8 02/17] lib/xe_query: Add region helpers and missing doc Zbigniew Kempczyński
2023-04-28  6:22 ` [igt-dev] [PATCH i-g-t v8 03/17] lib/xe_query: Remove commented out function prototype Zbigniew Kempczyński
2023-04-28  6:22 ` [igt-dev] [PATCH i-g-t v8 04/17] lib/intel_allocator: Add allocator support for Xe Zbigniew Kempczyński
2023-04-28  6:22 ` [igt-dev] [PATCH i-g-t v8 05/17] lib/drmtest: Add driver enum for i915/xe Zbigniew Kempczyński
2023-04-28  6:22 ` [igt-dev] [PATCH i-g-t v8 06/17] lib/intel_bufops: Add Xe support in bufops Zbigniew Kempczyński
2023-04-28  7:49   ` Kamil Konieczny
2023-04-28  6:22 ` [igt-dev] [PATCH i-g-t v8 07/17] lib/intel_batchbuffer: Rename i915 -> fd as preparation step for xe Zbigniew Kempczyński
2023-04-28  6:22 ` Zbigniew Kempczyński [this message]
2023-04-28  7:50   ` [igt-dev] [PATCH i-g-t v8 08/17] lib/intel_batchbuffer: Reacquire offset for reloc allocator in reset path Kamil Konieczny
2023-04-28  8:44   ` Manszewski, Christoph
2023-04-28  6:22 ` [igt-dev] [PATCH i-g-t v8 09/17] lib/intel_batchbuffer: Update intel-bb docs Zbigniew Kempczyński
2023-04-28  7:51   ` Kamil Konieczny
2023-04-28  8:51   ` Manszewski, Christoph
2023-04-28  6:22 ` [igt-dev] [PATCH i-g-t v8 10/17] lib/intel_batchbuffer: Add Xe support in intel-bb Zbigniew Kempczyński
2023-04-28  7:53   ` Kamil Konieczny
2023-04-28  8:40   ` Manszewski, Christoph
2023-04-28  9:20     ` Zbigniew Kempczyński
2023-04-28  6:22 ` [igt-dev] [PATCH i-g-t v8 11/17] tests/xe_intel_bb: Check if intel-bb Xe support correctness Zbigniew Kempczyński
2023-04-28  7:58   ` Kamil Konieczny
2023-04-28  8:18     ` Zbigniew Kempczyński
2023-04-28  6:22 ` [igt-dev] [PATCH i-g-t v8 12/17] tests/xe-fast-feedback: Add xe_intel_bb test to BAT Zbigniew Kempczyński
2023-04-28  7:59   ` Kamil Konieczny
2023-04-28  6:22 ` [igt-dev] [PATCH i-g-t v8 13/17] lib/gpgpu_fill: Use RENDER engine flag to work on Xe Zbigniew Kempczyński
2023-04-28  6:22 ` [igt-dev] [PATCH i-g-t v8 14/17] tests/xe_gpgpu_fill: Exercise gpgpu fill " Zbigniew Kempczyński
2023-04-28  6:22 ` [igt-dev] [PATCH i-g-t v8 15/17] lib/igt_fb: For xe assume vram is used on discrete Zbigniew Kempczyński
2023-04-28  6:22 ` [igt-dev] [PATCH i-g-t v8 16/17] lib/igt_draw: Pass region while building intel_buf from flink Zbigniew Kempczyński
2023-04-28  6:22 ` [igt-dev] [PATCH i-g-t v8 17/17] tests/kms_big_fb: Deduce region for xe framebuffer Zbigniew Kempczyński
2023-04-28  7:48 ` [igt-dev] ✓ Fi.CI.BAT: success for Integrate intel-bb with Xe (rev11) Patchwork
2023-04-28 10:05 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-04-28 10:21   ` Zbigniew Kempczyński
2023-04-28 12:56     ` Yedireswarapu, SaiX Nandan
2023-04-28 12:52 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230428062224.21322-9-zbigniew.kempczynski@intel.com \
    --to=zbigniew.kempczynski@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox