Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org, mchehab@kernel.org,
	kamil.konieczny@linux.intel.com
Subject: [igt-dev] [i-g-t 3/3] scripts/test_list: Ignore non-XE tests for missing documentation
Date: Thu,  4 May 2023 15:54:51 +0530	[thread overview]
Message-ID: <20230504102451.3047783-4-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20230504102451.3047783-1-bhanuprakash.modem@intel.com>

To add the test file to tests_config.json, documentation is
mandatory for all the subtests, else we'll end up with the
compilation failure.

It's completely make sense to consider the documentation as
mandatory for newly created test files like xe_*.c. But for
existing files, it is very painful to add the documentation
for all the subtests in that file.

Example: tests/kms_flip.c
It has N number of subtests, but we are using 2-3 subtests
for BAT. Will slowly add the documentation for remaining
subtests.

So, for non-XE subtests, don't fail the compilation for
missing documentation. Once the documentation is done for
all the subtests we can revert this patch.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 scripts/test_list.py | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/scripts/test_list.py b/scripts/test_list.py
index 1c5e195eb..3c959d6b9 100755
--- a/scripts/test_list.py
+++ b/scripts/test_list.py
@@ -876,11 +876,16 @@ class TestList:
             if not found:
                 doc_uneeded.append(doc_test)
 
+        xe_regex = r"^(igt@xe_.*@.*$)"
         for run_test in run_subtests:
             found = False
             if re.match(test_regex, run_test):
                 found = True
-            if not found:
+            #
+            # FIXME: Drop this XE specific check once documentation is done
+            # for all subtests.
+            #
+            if not found and re.match(xe_regex, run_test):
                 run_missing.append(run_test)
 
         if doc_uneeded:
-- 
2.40.0



  parent reply	other threads:[~2023-05-04 10:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-04 10:24 [igt-dev] [i-g-t 0/3] Add testplan support for kms tests Bhanuprakash Modem
2023-05-04 10:24 ` [igt-dev] [i-g-t 1/3] tests/kms: Document kms subtests for XE BAT Bhanuprakash Modem
2023-05-05  4:49   ` Mauro Carvalho Chehab
2023-05-04 10:24 ` [igt-dev] [i-g-t 2/3] testplan: Add testplan support for kms tests Bhanuprakash Modem
2023-05-05  4:53   ` Mauro Carvalho Chehab
2023-05-04 10:24 ` Bhanuprakash Modem [this message]
2023-05-05  4:55   ` [igt-dev] [i-g-t 3/3] scripts/test_list: Ignore non-XE tests for missing documentation Mauro Carvalho Chehab
2023-05-04 11:33 ` [igt-dev] ✓ Fi.CI.BAT: success for Add testplan support for kms tests Patchwork
2023-05-04 13:57 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230504102451.3047783-4-bhanuprakash.modem@intel.com \
    --to=bhanuprakash.modem@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox