From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 75EA710E35E for ; Tue, 9 May 2023 09:07:44 +0000 (UTC) Received: from linux.intel.com (ksebasti-mobl.ger.corp.intel.com [10.252.18.159]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id 549A6580DA1 for ; Tue, 9 May 2023 02:07:42 -0700 (PDT) Received: from maurocar by linux.intel.com with local (Exim 4.96) (envelope-from ) id 1pwJJs-004rJb-0e for igt-dev@lists.freedesktop.org; Tue, 09 May 2023 11:07:40 +0200 From: Mauro Carvalho Chehab To: igt-dev@lists.freedesktop.org Date: Tue, 9 May 2023 11:07:35 +0200 Message-Id: <20230509090738.1157939-4-mauro.chehab@linux.intel.com> In-Reply-To: <20230509090738.1157939-1-mauro.chehab@linux.intel.com> References: <20230509090738.1157939-1-mauro.chehab@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [igt-dev] [PATCH i-g-t v3 3/6] scripts/test_list.py: fix some hints pointed by Ruff List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: From: Mauro Carvalho Chehab There are some places where the wrong logic was used to check for dict members, causing those warnings on Ruff: E713 [*] Test for membership should be `not in` Signed-off-by: Mauro Carvalho Chehab --- scripts/test_list.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/test_list.py b/scripts/test_list.py index 7153b06df015..21767870b1c1 100755 --- a/scripts/test_list.py +++ b/scripts/test_list.py @@ -689,7 +689,7 @@ class TestList: marker = 0 for cur_level in range(0, len(fields_order)): # pylint: disable=C0200 field = fields_order[cur_level] - if not "level" in self.props[field]["_properties_"]: + if "level" not in self.props[field]["_properties_"]: continue if field in fields: if old_fields[cur_level] != fields[field]: @@ -698,9 +698,9 @@ class TestList: # print hierarchy for i in range(cur_level, len(fields_order)): - if not "level" in self.props[fields_order[i]]["_properties_"]: + if "level" not in self.props[fields_order[i]]["_properties_"]: continue - if not fields_order[i] in fields: + if fields_order[i] not in fields: continue if marker >= len(level_markers): @@ -728,7 +728,7 @@ class TestList: # Store current values for i in range(cur_level, len(fields_order)): field = fields_order[i] - if not "level" in self.props[field]["_properties_"]: + if "level" not in self.props[field]["_properties_"]: continue if field in fields: old_fields[i] = fields[field] -- 2.40.1