From: Swati Sharma <swati2.sharma@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 1/2] DO NOT MERGE: NV12 Experiment
Date: Thu, 11 May 2023 18:20:09 +0530 [thread overview]
Message-ID: <20230511125010.172215-1-swati2.sharma@intel.com> (raw)
From: Jeevan B <jeevan.b@intel.com>
Signed-off-by: Jeevan B <jeevan.b@intel.com>
Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
tests/intel-ci/fast-feedback.testlist | 9 +-
tests/kms_pipe_crc_basic.c | 293 ++++++++++++++++++++++++--
2 files changed, 286 insertions(+), 16 deletions(-)
diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
index d9fcb62d..4af9e8d2 100644
--- a/tests/intel-ci/fast-feedback.testlist
+++ b/tests/intel-ci/fast-feedback.testlist
@@ -118,7 +118,14 @@ igt@kms_force_connector_basic@force-edid
igt@kms_force_connector_basic@force-load-detect
igt@kms_force_connector_basic@prune-stale-modes
igt@kms_frontbuffer_tracking@basic
-igt@kms_pipe_crc_basic@compare-crc-sanitycheck
+igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xrgb
+igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xrgb-red
+igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xrgb-green
+igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xrgb-blue
+igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12
+igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12-red
+igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12-green
+igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12-blue
igt@kms_pipe_crc_basic@hang-read-crc
igt@kms_pipe_crc_basic@nonblocking-crc
igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence
diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c
index 84c73fd7..939d8486 100644
--- a/tests/kms_pipe_crc_basic.c
+++ b/tests/kms_pipe_crc_basic.c
@@ -226,6 +226,109 @@ static void test_read_crc(data_t *data, enum pipe pipe,
igt_display_commit(display);
}
+static void test_compare_crc_xrgb(data_t *data, enum pipe pipe, igt_output_t *output, int color)
+{
+ igt_display_t *display = &data->display;
+ igt_plane_t *primary;
+ drmModeModeInfo *mode;
+ igt_crc_t ref_crc, crc;
+ igt_pipe_crc_t *pipe_crc = NULL;
+ struct igt_fb fb0, fb1;
+
+ igt_display_reset(display);
+ igt_output_set_pipe(output, pipe);
+
+ mode = igt_output_get_mode(output);
+
+ /* Create two framebuffers with the same color info. */
+ switch (color) {
+ case 1:
+ igt_create_color_fb(data->drm_fd,
+ mode->hdisplay, mode->vdisplay,
+ DRM_FORMAT_XRGB8888,
+ DRM_FORMAT_MOD_LINEAR,
+ 1.0, 0.0, 0.0,
+ &fb0);
+
+ igt_create_color_fb(data->drm_fd,
+ mode->hdisplay, mode->vdisplay,
+ DRM_FORMAT_XRGB8888,
+ DRM_FORMAT_MOD_LINEAR,
+ 1.0, 0.0, 0.0,
+ &fb1);
+ break;
+ case 2:
+ igt_create_color_fb(data->drm_fd,
+ mode->hdisplay, mode->vdisplay,
+ DRM_FORMAT_XRGB8888,
+ DRM_FORMAT_MOD_LINEAR,
+ 0.0, 1.0, 0.0,
+ &fb0);
+
+ igt_create_color_fb(data->drm_fd,
+ mode->hdisplay, mode->vdisplay,
+ DRM_FORMAT_XRGB8888,
+ DRM_FORMAT_MOD_LINEAR,
+ 0.0, 1.0, 0.0,
+ &fb1);
+ break;
+ case 3:
+ igt_create_color_fb(data->drm_fd,
+ mode->hdisplay, mode->vdisplay,
+ DRM_FORMAT_XRGB8888,
+ DRM_FORMAT_MOD_LINEAR,
+ 0.0, 0.0, 1.0,
+ &fb0);
+
+ igt_create_color_fb(data->drm_fd,
+ mode->hdisplay, mode->vdisplay,
+ DRM_FORMAT_XRGB8888,
+ DRM_FORMAT_MOD_LINEAR,
+ 0.0, 0.0, 1.0,
+ &fb1);
+ break;
+ default:
+ igt_create_color_fb(data->drm_fd,
+ mode->hdisplay, mode->vdisplay,
+ DRM_FORMAT_XRGB8888,
+ DRM_FORMAT_MOD_LINEAR,
+ 1.0, 1.0, 1.0,
+ &fb0);
+
+ igt_create_color_fb(data->drm_fd,
+ mode->hdisplay, mode->vdisplay,
+ DRM_FORMAT_XRGB8888,
+ DRM_FORMAT_MOD_LINEAR,
+ 1.0, 1.0, 1.0,
+ &fb1);
+ }
+
+ /* Flip FB0 with the Primary plane & collect the CRC as ref CRC. */
+ primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
+ igt_plane_set_fb(primary, &fb0);
+ igt_display_commit(display);
+
+ pipe_crc = igt_pipe_crc_new(data->drm_fd, pipe,
+ IGT_PIPE_CRC_SOURCE_AUTO);
+ igt_pipe_crc_collect_crc(pipe_crc, &ref_crc);
+
+ /* Flip FB1 with the Primary plane & compare the CRC with ref CRC. */
+ igt_plane_set_fb(primary, &fb1);
+ igt_display_commit(display);
+
+ igt_pipe_crc_collect_crc(pipe_crc, &crc);
+ igt_assert_crc_equal(&crc, &ref_crc);
+
+ /* Clean-up */
+ igt_pipe_crc_free(pipe_crc);
+ igt_plane_set_fb(primary, NULL);
+ igt_output_set_pipe(output, PIPE_NONE);
+ igt_display_commit(display);
+
+ igt_remove_fb(data->drm_fd, &fb0);
+ igt_remove_fb(data->drm_fd, &fb1);
+}
+
/**
* SUBTEST: compare-crc-sanitycheck
* Description: Basic sanity check for CRC mismatches
@@ -245,7 +348,7 @@ static void test_read_crc(data_t *data, enum pipe pipe,
*
* No CRC mismatch should happen
*/
-static void test_compare_crc(data_t *data, enum pipe pipe, igt_output_t *output)
+static void test_compare_crc_nv12(data_t *data, enum pipe pipe, igt_output_t *output, int color)
{
igt_display_t *display = &data->display;
igt_plane_t *primary;
@@ -260,18 +363,64 @@ static void test_compare_crc(data_t *data, enum pipe pipe, igt_output_t *output)
mode = igt_output_get_mode(output);
/* Create two framebuffers with the same color info. */
- igt_create_color_fb(data->drm_fd,
- mode->hdisplay, mode->vdisplay,
- DRM_FORMAT_XRGB8888,
- DRM_FORMAT_MOD_LINEAR,
- 1.0, 1.0, 1.0,
- &fb0);
- igt_create_color_fb(data->drm_fd,
- mode->hdisplay, mode->vdisplay,
- DRM_FORMAT_XRGB8888,
- DRM_FORMAT_MOD_LINEAR,
- 1.0, 1.0, 1.0,
- &fb1);
+ switch (color) {
+ case 1:
+ igt_create_color_fb(data->drm_fd,
+ mode->hdisplay, mode->vdisplay,
+ DRM_FORMAT_NV12,
+ DRM_FORMAT_MOD_LINEAR,
+ 1.0, 0.0, 0.0,
+ &fb0);
+
+ igt_create_color_fb(data->drm_fd,
+ mode->hdisplay, mode->vdisplay,
+ DRM_FORMAT_NV12,
+ DRM_FORMAT_MOD_LINEAR,
+ 1.0, 0.0, 0.0,
+ &fb1);
+ case 2:
+ igt_create_color_fb(data->drm_fd,
+ mode->hdisplay, mode->vdisplay,
+ DRM_FORMAT_NV12,
+ DRM_FORMAT_MOD_LINEAR,
+ 0.0, 1.0, 0.0,
+ &fb0);
+
+ igt_create_color_fb(data->drm_fd,
+ mode->hdisplay, mode->vdisplay,
+ DRM_FORMAT_NV12,
+ DRM_FORMAT_MOD_LINEAR,
+ 0.0, 1.0, 0.0,
+ &fb1);
+ case 3:
+ igt_create_color_fb(data->drm_fd,
+ mode->hdisplay, mode->vdisplay,
+ DRM_FORMAT_NV12,
+ DRM_FORMAT_MOD_LINEAR,
+ 0.0, 0.0, 1.0,
+ &fb0);
+
+ igt_create_color_fb(data->drm_fd,
+ mode->hdisplay, mode->vdisplay,
+ DRM_FORMAT_NV12,
+ DRM_FORMAT_MOD_LINEAR,
+ 0.0, 0.0, 1.0,
+ &fb1);
+ default:
+ igt_create_color_fb(data->drm_fd,
+ mode->hdisplay, mode->vdisplay,
+ DRM_FORMAT_NV12,
+ DRM_FORMAT_MOD_LINEAR,
+ 1.0, 1.0, 1.0,
+ &fb0);
+
+ igt_create_color_fb(data->drm_fd,
+ mode->hdisplay, mode->vdisplay,
+ DRM_FORMAT_NV12,
+ DRM_FORMAT_MOD_LINEAR,
+ 1.0, 1.0, 1.0,
+ &fb1);
+ }
/* Flip FB0 with the Primary plane & collect the CRC as ref CRC. */
primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
@@ -476,7 +625,71 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
}
igt_describe("Basic sanity check for CRC mismatches");
- igt_subtest_with_dynamic("compare-crc-sanitycheck") {
+ igt_subtest_with_dynamic("compare-crc-sanitycheck-xrgb") {
+ for_each_pipe_with_single_output(&data.display, pipe, output) {
+ if (simulation_constraint(pipe))
+ continue;
+
+ if(!pipe_output_combo_valid(&data.display, pipe, output))
+ continue;
+
+ igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), output->name)
+ test_compare_crc_xrgb(&data, pipe, output, 0);
+
+ break;
+ }
+ }
+
+ igt_describe("Basic sanity check for CRC mismatches");
+ igt_subtest_with_dynamic("compare-crc-sanitycheck-xrgb-red") {
+ for_each_pipe_with_single_output(&data.display, pipe, output) {
+ if (simulation_constraint(pipe))
+ continue;
+
+ if(!pipe_output_combo_valid(&data.display, pipe, output))
+ continue;
+
+ igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), output->name)
+ test_compare_crc_xrgb(&data, pipe, output, 1);
+
+ break;
+ }
+ }
+
+ igt_describe("Basic sanity check for CRC mismatches");
+ igt_subtest_with_dynamic("compare-crc-sanitycheck-xrgb-green") {
+ for_each_pipe_with_single_output(&data.display, pipe, output) {
+ if (simulation_constraint(pipe))
+ continue;
+
+ if(!pipe_output_combo_valid(&data.display, pipe, output))
+ continue;
+
+ igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), output->name)
+ test_compare_crc_xrgb(&data, pipe, output, 2);
+
+ break;
+ }
+ }
+
+ igt_describe("Basic sanity check for CRC mismatches");
+ igt_subtest_with_dynamic("compare-crc-sanitycheck-xrgb-blue") {
+ for_each_pipe_with_single_output(&data.display, pipe, output) {
+ if (simulation_constraint(pipe))
+ continue;
+
+ if(!pipe_output_combo_valid(&data.display, pipe, output))
+ continue;
+
+ igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), output->name)
+ test_compare_crc_xrgb(&data, pipe, output, 3);
+
+ break;
+ }
+ }
+
+ igt_describe("Basic sanity check for CRC mismatches");
+ igt_subtest_with_dynamic("compare-crc-sanitycheck-nv12") {
for_each_pipe_with_single_output(&data.display, pipe, output) {
if (simulation_constraint(pipe))
continue;
@@ -485,7 +698,57 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
continue;
igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), output->name)
- test_compare_crc(&data, pipe, output);
+ test_compare_crc_nv12(&data, pipe, output, 0);
+
+ break;
+ }
+ }
+
+ igt_describe("Basic sanity check for CRC mismatches");
+ igt_subtest_with_dynamic("compare-crc-sanitycheck-nv12-red") {
+ for_each_pipe_with_single_output(&data.display, pipe, output) {
+ if (simulation_constraint(pipe))
+ continue;
+
+ if(!pipe_output_combo_valid(&data.display, pipe, output))
+ continue;
+
+ igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), output->name)
+ test_compare_crc_nv12(&data, pipe, output, 1);
+
+ break;
+ }
+ }
+
+ igt_describe("Basic sanity check for CRC mismatches");
+ igt_subtest_with_dynamic("compare-crc-sanitycheck-nv12-green") {
+ for_each_pipe_with_single_output(&data.display, pipe, output) {
+ if (simulation_constraint(pipe))
+ continue;
+
+ if(!pipe_output_combo_valid(&data.display, pipe, output))
+ continue;
+
+ igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), output->name)
+ test_compare_crc_nv12(&data, pipe, output, 2);
+
+ break;
+ }
+ }
+
+ igt_describe("Basic sanity check for CRC mismatches");
+ igt_subtest_with_dynamic("compare-crc-sanitycheck-nv12-blue") {
+ for_each_pipe_with_single_output(&data.display, pipe, output) {
+ if (simulation_constraint(pipe))
+ continue;
+
+ if(!pipe_output_combo_valid(&data.display, pipe, output))
+ continue;
+
+ igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), output->name)
+ test_compare_crc_nv12(&data, pipe, output, 3);
+
+ break;
}
}
--
2.25.1
next reply other threads:[~2023-05-11 13:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-11 12:50 Swati Sharma [this message]
2023-05-11 12:50 ` [igt-dev] [PATCH i-g-t 2/2] lib/igt_fb: round rgb->yuv conversion results Swati Sharma
2023-05-11 15:05 ` [igt-dev] [PATCH i-g-t 1/2] DO NOT MERGE: NV12 Experiment Kamil Konieczny
2023-05-11 18:47 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] " Patchwork
2023-05-12 0:35 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2023-05-11 7:42 [igt-dev] [PATCH i-g-t 1/2] " Swati Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230511125010.172215-1-swati2.sharma@intel.com \
--to=swati2.sharma@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox