From: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v2 15/15] intel_gpu_top: Add gt specific values to header in interactive mode
Date: Wed, 17 May 2023 14:25:42 -0700 [thread overview]
Message-ID: <20230517212542.3681862-16-umesh.nerlige.ramappa@intel.com> (raw)
In-Reply-To: <20230517212542.3681862-1-umesh.nerlige.ramappa@intel.com>
If -p options is specified in INTERACTIVE mode, show the gt specific
values.
v2: Reformat GT info for INTERACTIVE mode (Tvrtko)
Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
tools/intel_gpu_top.c | 33 +++++++++++++++++++++++++--------
1 file changed, 25 insertions(+), 8 deletions(-)
diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
index 11ef4c0e2..da72c0166 100644
--- a/tools/intel_gpu_top.c
+++ b/tools/intel_gpu_top.c
@@ -1570,14 +1570,31 @@ print_header(const struct igt_device_card *card,
lines = print_header_token(" @ ", lines, con_w, con_h, &rem,
"%s", card->card);
- lines = print_header_token(" - ", lines, con_w, con_h, &rem,
- "%s/%s MHz",
- freq_items[1].buf,
- freq_items[0].buf);
-
- lines = print_header_token("; ", lines, con_w, con_h, &rem,
- "%s%% RC6",
- rc6_items[0].buf);
+ if (class_view || engines->num_gts == 1) {
+ lines = print_header_token(" - ", lines, con_w, con_h, &rem,
+ "%s/%s MHz",
+ freq_items[1].buf,
+ freq_items[0].buf);
+
+ lines = print_header_token("; ", lines, con_w, con_h, &rem,
+ "%s%% RC6",
+ rc6_items[0].buf);
+ } else {
+ for (i = 0; i < engines->num_gts; i++) {
+ const char *cont = !i ? " - ": "; ";
+
+ lines = print_header_token(cont, lines, con_w, con_h, &rem,
+ "%s/%s MHz GT%d",
+ freq_items_gt[i * 4 + 1].buf,
+ freq_items_gt[i * 4 + 0].buf,
+ i);
+
+ lines = print_header_token("; ", lines, con_w, con_h, &rem,
+ "%s%% RC6 GT%d",
+ rc6_items_gt[i * 3].buf,
+ i);
+ }
+ }
if (engines->r_gpu.present) {
lines = print_header_token("; ", lines, con_w, con_h,
--
2.36.1
next prev parent reply other threads:[~2023-05-17 21:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 21:25 [igt-dev] [PATCH i-g-t v2 00/15] PMU: multi-tile support Umesh Nerlige Ramappa
2023-05-17 21:25 ` [igt-dev] [PATCH i-g-t v2 01/15] perf_pmu: Support multi-tile in rc6 subtest Umesh Nerlige Ramappa
2023-05-17 21:25 ` [igt-dev] [PATCH i-g-t v2 02/15] perf_pmu: Two new rc6 subtests Umesh Nerlige Ramappa
2023-05-17 21:25 ` [igt-dev] [PATCH i-g-t v2 03/15] perf_pmu: Support multi-tile in frequency subtest Umesh Nerlige Ramappa
2023-05-17 21:25 ` [igt-dev] [PATCH i-g-t v2 04/15] perf_pmu: Quiesce GPU if measuring idle busyness without spinner Umesh Nerlige Ramappa
2023-05-17 21:25 ` [igt-dev] [PATCH i-g-t v2 05/15] perf_pmu: Use correct pmu config for multi-tile Umesh Nerlige Ramappa
2023-05-17 21:25 ` [igt-dev] [PATCH i-g-t v2 06/15] intel_gpu_top: Add an array of freq and rc6 counters Umesh Nerlige Ramappa
2023-05-17 21:25 ` [igt-dev] [PATCH i-g-t v2 07/15] intel_gpu_top: Determine number of tiles Umesh Nerlige Ramappa
2023-05-17 21:25 ` [igt-dev] [PATCH i-g-t v2 08/15] intel_gpu_top: Capture freq and rc6 counters from each gt Umesh Nerlige Ramappa
2023-05-17 21:25 ` [igt-dev] [PATCH i-g-t v2 09/15] intel_gpu_top: Switch pmu_counter to use aggregated values Umesh Nerlige Ramappa
2023-05-17 21:25 ` [igt-dev] [PATCH i-g-t v2 10/15] intel_gpu_top: Add definitions for gt-specific items and groups Umesh Nerlige Ramappa
2023-05-17 21:25 ` [igt-dev] [PATCH i-g-t v2 11/15] intel_gpu_top: Bump up size of groups to accomodate multi-gt Umesh Nerlige Ramappa
2023-05-17 21:25 ` [igt-dev] [PATCH i-g-t v2 12/15] intel_gpu_top: Increase visibility for class_view Umesh Nerlige Ramappa
2023-05-17 21:25 ` [igt-dev] [PATCH i-g-t v2 13/15] intel_gpu_top: Show gt specific values if requested Umesh Nerlige Ramappa
2023-05-17 21:25 ` [igt-dev] [PATCH i-g-t v2 14/15] intel_gpu_top: Reduce one level of indent Umesh Nerlige Ramappa
2023-05-17 21:25 ` Umesh Nerlige Ramappa [this message]
2023-05-17 22:15 ` [igt-dev] ✗ Fi.CI.BAT: failure for PMU: multi-tile support (rev4) Patchwork
2023-05-18 12:04 ` Kamil Konieczny
2023-05-18 12:20 ` Yedireswarapu, SaiX Nandan
2023-05-18 12:19 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-05-19 0:13 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-05-19 6:44 ` Umesh Nerlige Ramappa
2023-05-19 8:39 ` Dixit, Ashutosh
2023-05-19 15:55 ` Umesh Nerlige Ramappa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230517212542.3681862-16-umesh.nerlige.ramappa@intel.com \
--to=umesh.nerlige.ramappa@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox