From: Arun R Murthy <arun.r.murthy@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Arun R Murthy <arun.r.murthy@intel.com>
Subject: [igt-dev] [PATCHv5 i-g-t 2/4] tests/kms_async_flips: Run the test for all outputs
Date: Fri, 19 May 2023 12:14:51 +0530 [thread overview]
Message-ID: <20230519064453.1334690-3-arun.r.murthy@intel.com> (raw)
In-Reply-To: <20230519064453.1334690-1-arun.r.murthy@intel.com>
Iterate all outputs, in case we have output specific stuff
(eg. PSR) that could affect the behaviour or async flips
v2: corrected commit message
v3: run test for all outputs
v4: removed the usage of extended
v5: igt_main_args -> igt_main
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
---
tests/kms_async_flips.c | 43 ++++++++---------------------------------
1 file changed, 8 insertions(+), 35 deletions(-)
diff --git a/tests/kms_async_flips.c b/tests/kms_async_flips.c
index fe27a9ec..acc09aa1 100644
--- a/tests/kms_async_flips.c
+++ b/tests/kms_async_flips.c
@@ -58,7 +58,6 @@ typedef struct {
int flip_count;
int frame_count;
bool flip_pending;
- bool extended;
enum pipe pipe;
bool alternate_sync_async;
} data_t;
@@ -548,49 +547,23 @@ static void test_crc(data_t *data)
static void run_test(data_t *data, void (*test)(data_t *))
{
- igt_output_t *output;
- enum pipe pipe;
igt_display_t *display = &data->display;
- for_each_pipe(display, pipe) {
- for_each_valid_output_on_pipe(display, pipe, output) {
- igt_display_reset(display);
-
- igt_output_set_pipe(output, pipe);
- if (!i915_pipe_output_combo_valid(display))
- continue;
-
- igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), output->name) {
- data->output = output;
- data->pipe = pipe;
- test(data);
- }
-
- if (!data->extended)
- break;
- }
- }
-}
+ for_each_pipe_with_valid_output(display, data->pipe, data->output) {
+ igt_display_reset(display);
-static int opt_handler(int opt, int opt_index, void *_data)
-{
- data_t *data = _data;
+ igt_output_set_pipe(data->output, data->pipe);
+ if (!i915_pipe_output_combo_valid(display))
+ continue;
- switch (opt) {
- case 'e':
- data->extended = true;
- break;
+ igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(data->pipe), data->output->name)
+ test(data);
}
-
- return IGT_OPT_HANDLER_SUCCESS;
}
-static const char help_str[] =
- " --e \t\tRun the extended tests\n";
-
static data_t data;
-igt_main_args("e", NULL, help_str, opt_handler, &data)
+igt_main
{
int i;
--
2.25.1
next prev parent reply other threads:[~2023-05-19 6:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 6:44 [igt-dev] [PATCH i-g-t 0/4] some cleanup on kms_async_clip Arun R Murthy
2023-05-19 6:44 ` [igt-dev] [PATCHv2 i-g-t 1/4] tests/kms_async_flips: Get rid of i915 specific fb creation Arun R Murthy
2023-05-19 6:44 ` Arun R Murthy [this message]
2023-05-22 6:18 ` [igt-dev] [PATCHv5 i-g-t 2/4] tests/kms_async_flips: Run the test for all outputs Karthik B S
2023-05-19 6:44 ` [igt-dev] [PATCHv1 i-g-t 3/4] tests/kms_async_flips: Split test_init() Arun R Murthy
2023-05-19 6:44 ` [igt-dev] [PATCHv2 i-g-t 4/4] tests/kms_async_flips: Test all modifiers Arun R Murthy
2023-05-19 7:42 ` [igt-dev] ✓ Fi.CI.BAT: success for some cleanup on kms_async_clip Patchwork
2023-05-19 12:32 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2023-05-19 5:34 [igt-dev] [PATCH i-g-t 4/4] tests/kms_async_flips: Test all modifiers Arun R Murthy
2023-05-19 6:38 ` [igt-dev] [PATCHv5 i-g-t 2/4] tests/kms_async_flips: Run the test for all outputs Arun R Murthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230519064453.1334690-3-arun.r.murthy@intel.com \
--to=arun.r.murthy@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox