From: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v3 01/16] i915/gem_engine_topology: Support gem_list_engines on platforms prior to MTL
Date: Fri, 19 May 2023 08:46:35 -0700 [thread overview]
Message-ID: <20230519154650.3751855-2-umesh.nerlige.ramappa@intel.com> (raw)
In-Reply-To: <20230519154650.3751855-1-umesh.nerlige.ramappa@intel.com>
From: Ashutosh Dixit <ashutosh.dixit@intel.com>
gem_list_engines() should list engines correctly on platforms prior to
MTL. But at present it doesn't, it only supports MTL, and it skips on the
'igt_require(IS_METEORLAKE)' check for prior platforms. Fix this by
modifying gem_engine_to_gt_map() to return gt 0 for prior platforms,
because the only multi-gt platform supported at present in MTL.
Fixes: d2f39ce8186a ("lib/i915/gem_engine_topology: list engines specific to gt")
Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
---
lib/i915/gem_engine_topology.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/lib/i915/gem_engine_topology.c b/lib/i915/gem_engine_topology.c
index 6c8929ec5..7c6cd9ba9 100644
--- a/lib/i915/gem_engine_topology.c
+++ b/lib/i915/gem_engine_topology.c
@@ -372,8 +372,12 @@ mtl_engine_to_gt_map(const struct i915_engine_class_instance *e)
static int gem_engine_to_gt_map(int i915, const struct i915_engine_class_instance *engine)
{
- igt_require(IS_METEORLAKE(intel_get_drm_devid(i915)));
- return mtl_engine_to_gt_map(engine);
+ uint32_t devid = intel_get_drm_devid(i915);
+
+ /* Only MTL multi-gt supported at present */
+ igt_require(intel_graphics_ver(devid) <= IP_VER(12, 70));
+
+ return IS_METEORLAKE(devid) ? mtl_engine_to_gt_map(engine) : 0;
}
/**
--
2.36.1
next prev parent reply other threads:[~2023-05-19 15:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 15:46 [igt-dev] [PATCH i-g-t v3 00/16] PMU: multi-tile support Umesh Nerlige Ramappa
2023-05-19 15:46 ` Umesh Nerlige Ramappa [this message]
2023-05-19 15:46 ` [igt-dev] [PATCH i-g-t v3 02/16] perf_pmu: Support multi-tile in rc6 subtest Umesh Nerlige Ramappa
2023-05-19 15:46 ` [igt-dev] [PATCH i-g-t v3 03/16] perf_pmu: Two new rc6 subtests Umesh Nerlige Ramappa
2023-05-19 15:46 ` [igt-dev] [PATCH i-g-t v3 04/16] perf_pmu: Support multi-tile in frequency subtest Umesh Nerlige Ramappa
2023-05-19 15:46 ` [igt-dev] [PATCH i-g-t v3 05/16] perf_pmu: Quiesce GPU if measuring idle busyness without spinner Umesh Nerlige Ramappa
2023-05-19 15:46 ` [igt-dev] [PATCH i-g-t v3 06/16] perf_pmu: Use correct pmu config for multi-tile Umesh Nerlige Ramappa
2023-05-19 15:46 ` [igt-dev] [PATCH i-g-t v3 07/16] intel_gpu_top: Add an array of freq and rc6 counters Umesh Nerlige Ramappa
2023-05-19 15:46 ` [igt-dev] [PATCH i-g-t v3 08/16] intel_gpu_top: Determine number of tiles Umesh Nerlige Ramappa
2023-05-19 15:46 ` [igt-dev] [PATCH i-g-t v3 09/16] intel_gpu_top: Capture freq and rc6 counters from each gt Umesh Nerlige Ramappa
2023-05-19 15:46 ` [igt-dev] [PATCH i-g-t v3 10/16] intel_gpu_top: Switch pmu_counter to use aggregated values Umesh Nerlige Ramappa
2023-05-19 15:46 ` [igt-dev] [PATCH i-g-t v3 11/16] intel_gpu_top: Add definitions for gt-specific items and groups Umesh Nerlige Ramappa
2023-05-19 15:46 ` [igt-dev] [PATCH i-g-t v3 12/16] intel_gpu_top: Bump up size of groups to accomodate multi-gt Umesh Nerlige Ramappa
2023-05-19 15:46 ` [igt-dev] [PATCH i-g-t v3 13/16] intel_gpu_top: Increase visibility for class_view Umesh Nerlige Ramappa
2023-05-19 15:46 ` [igt-dev] [PATCH i-g-t v3 14/16] intel_gpu_top: Show gt specific values if requested Umesh Nerlige Ramappa
2023-05-19 15:46 ` [igt-dev] [PATCH i-g-t v3 15/16] intel_gpu_top: Reduce one level of indent Umesh Nerlige Ramappa
2023-05-19 15:46 ` [igt-dev] [PATCH i-g-t v3 16/16] intel_gpu_top: Add gt specific values to header in interactive mode Umesh Nerlige Ramappa
2023-05-19 17:33 ` [igt-dev] ✓ Fi.CI.BAT: success for PMU: multi-tile support (rev5) Patchwork
2023-05-19 20:07 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230519154650.3751855-2-umesh.nerlige.ramappa@intel.com \
--to=umesh.nerlige.ramappa@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox