Re: [igt-dev] [PATCH i-g-t 3/4] lib/intel_cmds_info: Drop BLT_CMD_LONG flag

["Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>]

On Mon, May 22, 2023 at 11:57:13AM +0200, Karolina Stolarek wrote:
> It looks like a separate flag for longer commands isn't needed
> and we can use BLT_CMD_EXTENDED instead.

If so what for you're introducing this flag in patch 1/4?

--
Zbigniew

> 
> Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> Signed-off-by: Karolina Stolarek <karolina.stolarek@intel.com>
> ---
>  lib/i915/intel_cmds_info.c | 2 +-
>  lib/i915/intel_cmds_info.h | 1 -
>  2 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/lib/i915/intel_cmds_info.c b/lib/i915/intel_cmds_info.c
> index 3ce2fd74b..09b612279 100644
> --- a/lib/i915/intel_cmds_info.c
> +++ b/lib/i915/intel_cmds_info.c
> @@ -87,7 +87,7 @@ static const struct blt_cmd_info
>  						 BIT(T_LINEAR) |
>  						 BIT(T_YMAJOR) |
>  						 BIT(T_XMAJOR),
> -						 BLT_CMD_LONG);
> +						 BLT_CMD_EXTENDED);
>  
>  static const struct blt_cmd_info
>  		pre_gen6_xy_color_blt = BLT_INFO(XY_COLOR_BLT,
> diff --git a/lib/i915/intel_cmds_info.h b/lib/i915/intel_cmds_info.h
> index 5998a35ca..91d0f15ec 100644
> --- a/lib/i915/intel_cmds_info.h
> +++ b/lib/i915/intel_cmds_info.h
> @@ -34,7 +34,6 @@ struct blt_cmd_info {
>  	uint32_t flags;
>  #define BLT_CMD_EXTENDED               (1 << 0)
>  #define BLT_CMD_SUPPORTS_COMPRESSION   (1 << 1)
> -#define BLT_CMD_LONG                   (1 << 2)
>  };
>  
>  struct intel_cmds_info {
> -- 
> 2.25.1
>