From: Nidhi Gupta <nidhi1.gupta@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Nidhi Gupta <nidhi1.gupta@intel.com>
Subject: [igt-dev] [RFC, i-g-t] tests/kms_vrr: New VRR test to toggle the VRR during fastsets
Date: Fri, 26 May 2023 07:37:31 +0530 [thread overview]
Message-ID: <20230526020731.5250-1-nidhi1.gupta@intel.com> (raw)
Allow VRR to be toggled during fastsets, without
the need of full modeset.
Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
---
tests/kms_vrr.c | 21 ++++++++++++++++-----
1 file changed, 16 insertions(+), 5 deletions(-)
diff --git a/tests/kms_vrr.c b/tests/kms_vrr.c
index d2d79c4e..ea6528e1 100644
--- a/tests/kms_vrr.c
+++ b/tests/kms_vrr.c
@@ -45,7 +45,8 @@ enum {
TEST_DPMS = 1 << 1,
TEST_SUSPEND = 1 << 2,
TEST_FLIPLINE = 1 << 3,
- TEST_NEGATIVE = 1 << 4,
+ TEST_FASTSET = 1 << 4,
+ TEST_NEGATIVE = 1 << 5,
};
typedef struct range {
@@ -193,11 +194,14 @@ static bool vrr_capable(igt_output_t *output)
}
/* Toggles variable refresh rate on the pipe. */
-static void set_vrr_on_pipe(data_t *data, enum pipe pipe, bool enabled)
+static void set_vrr_on_pipe(data_t *data, enum pipe pipe,
+ bool need_modeset, bool enabled)
{
igt_pipe_set_prop_value(&data->display, pipe, IGT_CRTC_VRR_ENABLED,
enabled);
- igt_display_commit2(&data->display, COMMIT_ATOMIC);
+
+ if (need_modeset)
+ igt_display_commit2(&data->display, COMMIT_ATOMIC);
}
/* Prepare the display for testing on the given pipe. */
@@ -370,7 +374,7 @@ test_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint32_t flags)
igt_info("VRR Test execution on %s, PIPE_%s with VRR range: (%u-%u) Hz\n",
output->name, kmstest_pipe_name(pipe), range.min, range.max);
- set_vrr_on_pipe(data, pipe, true);
+ set_vrr_on_pipe(data, pipe, (flags & ~TEST_FASTSET), true);
/*
* Do a short run with VRR, but don't check the result.
@@ -436,7 +440,7 @@ test_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint32_t flags)
* modeset. And the expected behavior is the same as disabling VRR on
* a VRR capable panel.
*/
- set_vrr_on_pipe(data, pipe, (flags & TEST_NEGATIVE)? true : false);
+ set_vrr_on_pipe(data, pipe, (flags & ~TEST_FASTSET), (flags & TEST_NEGATIVE)? true : false);
rate = vtest_ns.mid;
result = flip_and_measure(data, output, pipe, rate, TEST_DURATION_NS);
igt_assert_f(result < 10,
@@ -526,6 +530,13 @@ igt_main
igt_subtest_with_dynamic("negative-basic")
run_vrr_test(&data, test_basic, TEST_NEGATIVE);
+ igt_fixture
+ igt_require_intel(data.drm_fd);
+
+ igt_describe("Tests that VRR basic without modeset");
+ igt_subtest_with_dynamic("flip-basic-fastset")
+ run_vrr_test(&data, test_basic, TEST_FASTSET);
+
igt_fixture {
igt_display_fini(&data.display);
}
--
2.39.0
next reply other threads:[~2023-05-26 2:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 2:07 Nidhi Gupta [this message]
2023-05-26 12:01 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_vrr: New VRR test to toggle the VRR during fastsets Patchwork
2023-05-26 13:31 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-05-26 15:18 ` [igt-dev] [RFC, i-g-t] " Kamil Konieczny
-- strict thread matches above, loose matches on Subject: below --
2023-05-31 17:42 Nidhi Gupta
2023-06-01 13:15 ` Kamil Konieczny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230526020731.5250-1-nidhi1.gupta@intel.com \
--to=nidhi1.gupta@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox