Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andrzej Hajda <andrzej.hajda@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Nirmoy Das <nirmoy.das@intel.com>
Subject: [igt-dev] [PATCH i-g-t v2] i915/gem_ctx_persistence: skip heartbeat tests with GuC
Date: Fri, 26 May 2023 16:20:04 +0200	[thread overview]
Message-ID: <20230526142004.310852-1-andrzej.hajda@intel.com> (raw)

GuC does not support fully updating of persisting contexts, especially
heartbeat related parameters.

Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/3952
Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
---
v2: GuC checks moved to test functions (Kamil)
---
 tests/i915/gem_ctx_persistence.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/i915/gem_ctx_persistence.c b/tests/i915/gem_ctx_persistence.c
index 584137db454..df9b1c491ed 100644
--- a/tests/i915/gem_ctx_persistence.c
+++ b/tests/i915/gem_ctx_persistence.c
@@ -661,6 +661,8 @@ static void test_noheartbeat_many(int i915, int count, unsigned int flags)
 {
 	unsigned long checked = 0;
 
+	igt_require(!gem_using_guc_submission(i915));
+
 	cleanup(i915);
 	enable_hangcheck(i915);
 
@@ -721,6 +723,8 @@ static void test_noheartbeat_close(int i915, unsigned int flags)
 {
 	unsigned long checked = 0;
 
+	igt_require(!gem_using_guc_submission(i915));
+
 	cleanup(i915);
 	enable_hangcheck(i915);
 
-- 
2.34.1

             reply	other threads:[~2023-05-26 14:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-26 14:20 Andrzej Hajda [this message]
2023-05-26 14:43 ` [igt-dev] ✗ GitLab.Pipeline: warning for i915/gem_ctx_persistence: skip heartbeat tests with GuC (rev2) Patchwork
2023-05-26 15:03 ` [igt-dev] [PATCH i-g-t v2] i915/gem_ctx_persistence: skip heartbeat tests with GuC Kamil Konieczny
2023-05-26 15:05 ` [igt-dev] ✓ Fi.CI.BAT: success for i915/gem_ctx_persistence: skip heartbeat tests with GuC (rev2) Patchwork
2023-05-26 15:39 ` [igt-dev] ✓ Fi.CI.BAT: success for i915/gem_ctx_persistence: skip heartbeat tests with GuC (rev3) Patchwork
2023-05-27 10:49 ` [igt-dev] ✓ Fi.CI.IGT: success for i915/gem_ctx_persistence: skip heartbeat tests with GuC (rev2) Patchwork
2023-05-27 11:59 ` [igt-dev] ✓ Fi.CI.IGT: success for i915/gem_ctx_persistence: skip heartbeat tests with GuC (rev3) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230526142004.310852-1-andrzej.hajda@intel.com \
    --to=andrzej.hajda@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=nirmoy.das@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox