From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id BBE7510E1B5 for ; Wed, 31 May 2023 06:52:21 +0000 (UTC) Date: Wed, 31 May 2023 08:52:13 +0200 From: Mauro Carvalho Chehab To: "Sharma, Swati2" Message-ID: <20230531085213.4f86f261@maurocar-mobl2> In-Reply-To: References: <20230529052835.860047-1-bhanuprakash.modem@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [igt-dev] [i-g-t V4 00/82] Document KMS tests List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Tue, 30 May 2023 20:30:08 +0530 "Sharma, Swati2" wrote: > Hi Bhanu, > > IMO, functionality and mega feature seems to be redundant > + * Functionality: vrr > + * Mega feature: VRR > > Any thoughts? They're not identical. See, for instance, General Display Features mega feature. It contains several different functionalities: crc, cursor, force_connector, hotplug... This is on the patches that were already merged. The idea is that mega feature will contain a top level group of features, while functionality will contain the more technical low-level one. > Mauro/Bhanu, > What are our plans for igt_decribe(). It seems desriptions and > igt_describe() is unneeded. Yes. It is on our todo list to remove igt_describe(), igt_describe_f() and IGT_TEST_DESCRIPTION() from the files that are documented via C comments. Regards, Mauro