From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 40D9810E288 for ; Mon, 5 Jun 2023 10:55:31 +0000 (UTC) Date: Mon, 5 Jun 2023 12:55:26 +0200 From: Mauro Carvalho Chehab To: Dominik Karol Piatkowski Message-ID: <20230605125526.3e7d8d8b@maurocar-mobl2> In-Reply-To: <20230605104716.5678-2-dominik.karol.piatkowski@intel.com> References: <20230605104716.5678-1-dominik.karol.piatkowski@intel.com> <20230605104716.5678-2-dominik.karol.piatkowski@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [igt-dev] [PATCH i-g-t 1/8] lib/igt_kmod: rename kselftest functions to ktest List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org, Isabella Basso Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Mon, 5 Jun 2023 12:47:09 +0200 Dominik Karol Piatkowski wrote: > From: Isabella Basso >=20 > This aims at making IGT's structure more general to different kernel > testing frameworks such as KUnit, as they use a lot of the same > functionality. >=20 > Reviewed-by: Janusz Krzysztofik Reviewed-by: Mauro Carvalho Chehab > Signed-off-by: Isabella Basso >=20 > Signed-off-by: Dominik Karol Pi=C4=85tkowski > --- > lib/igt_kmod.c | 22 +++++++++++----------- > lib/igt_kmod.h | 12 ++++++------ > 2 files changed, 17 insertions(+), 17 deletions(-) >=20 > diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c > index ccf0063c..93fa2006 100644 > --- a/lib/igt_kmod.c > +++ b/lib/igt_kmod.c > @@ -749,8 +749,8 @@ static int open_parameters(const char *module_name) > return open(path, O_RDONLY); > } > =20 > -int igt_kselftest_init(struct igt_kselftest *tst, > - const char *module_name) > +int igt_ktest_init(struct igt_ktest *tst, > + const char *module_name) > { > int err; > =20 > @@ -769,7 +769,7 @@ int igt_kselftest_init(struct igt_kselftest *tst, > return 0; > } > =20 > -int igt_kselftest_begin(struct igt_kselftest *tst) > +int igt_ktest_begin(struct igt_ktest *tst) > { > int err; > =20 > @@ -784,7 +784,7 @@ int igt_kselftest_begin(struct igt_kselftest *tst) > return 0; > } > =20 > -int igt_kselftest_execute(struct igt_kselftest *tst, > +int igt_kselftest_execute(struct igt_ktest *tst, > struct igt_kselftest_list *tl, > const char *options, > const char *result) > @@ -822,13 +822,13 @@ int igt_kselftest_execute(struct igt_kselftest *tst, > return err; > } > =20 > -void igt_kselftest_end(struct igt_kselftest *tst) > +void igt_ktest_end(struct igt_ktest *tst) > { > kmod_module_remove_module(tst->kmod, KMOD_REMOVE_FORCE); > close(tst->kmsg); > } > =20 > -void igt_kselftest_fini(struct igt_kselftest *tst) > +void igt_ktest_fini(struct igt_ktest *tst) > { > free(tst->module_name); > kmod_module_unref(tst->kmod); > @@ -851,15 +851,15 @@ void igt_kselftests(const char *module_name, > const char *result, > const char *filter) > { > - struct igt_kselftest tst; > + struct igt_ktest tst; > IGT_LIST_HEAD(tests); > struct igt_kselftest_list *tl, *tn; > =20 > - if (igt_kselftest_init(&tst, module_name) !=3D 0) > + if (igt_ktest_init(&tst, module_name) !=3D 0) > return; > =20 > igt_fixture > - igt_require(igt_kselftest_begin(&tst) =3D=3D 0); > + igt_require(igt_ktest_begin(&tst) =3D=3D 0); > =20 > igt_kselftest_get_tests(tst.kmod, filter, &tests); > igt_subtest_with_dynamic(filter ?: "all-tests") { > @@ -878,9 +878,9 @@ void igt_kselftests(const char *module_name, > } > =20 > igt_fixture { > - igt_kselftest_end(&tst); > + igt_ktest_end(&tst); > igt_require(!igt_list_empty(&tests)); > } > =20 > - igt_kselftest_fini(&tst); > + igt_ktest_fini(&tst); > } > diff --git a/lib/igt_kmod.h b/lib/igt_kmod.h > index d05af4a6..ff59f1ec 100644 > --- a/lib/igt_kmod.h > +++ b/lib/igt_kmod.h > @@ -76,7 +76,7 @@ void igt_kselftests(const char *module_name, > const char *result_option, > const char *filter); > =20 > -struct igt_kselftest { > +struct igt_ktest { > struct kmod_module *kmod; > char *module_name; > int kmsg; > @@ -89,19 +89,19 @@ struct igt_kselftest_list { > char param[]; > }; > =20 > -int igt_kselftest_init(struct igt_kselftest *tst, > +int igt_ktest_init(struct igt_ktest *tst, > const char *module_name); > -int igt_kselftest_begin(struct igt_kselftest *tst); > +int igt_ktest_begin(struct igt_ktest *tst); > =20 > void igt_kselftest_get_tests(struct kmod_module *kmod, > const char *filter, > struct igt_list_head *tests); > -int igt_kselftest_execute(struct igt_kselftest *tst, > +int igt_kselftest_execute(struct igt_ktest *tst, > struct igt_kselftest_list *tl, > const char *module_options, > const char *result); > =20 > -void igt_kselftest_end(struct igt_kselftest *tst); > -void igt_kselftest_fini(struct igt_kselftest *tst); > +void igt_ktest_end(struct igt_ktest *tst); > +void igt_ktest_fini(struct igt_ktest *tst); > =20 > #endif /* IGT_KMOD_H */