From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 53DF210E2CE for ; Tue, 6 Jun 2023 08:18:17 +0000 (UTC) Date: Tue, 6 Jun 2023 10:18:11 +0200 From: Mauro Carvalho Chehab To: "Piatkowski, Dominik Karol" Message-ID: <20230606101811.519cace0@maurocar-mobl2> In-Reply-To: References: <20230605104716.5678-1-dominik.karol.piatkowski@intel.com> <9166079.rMLUfLXkoz@jkrzyszt-mobl2.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [igt-dev] [PATCH v5 i-g-t 0/8] Introduce KUnit List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "igt-dev@lists.freedesktop.org" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Tue, 6 Jun 2023 07:54:56 +0000 "Piatkowski, Dominik Karol" wrote: > Hi Janusz, > > > -----Original Message----- > > From: Janusz Krzysztofik > > Sent: wtorek, 6 czerwca 2023 09:47 > > To: igt-dev@lists.freedesktop.org; Piatkowski, Dominik Karol > > ; Mauro Carvalho Chehab > > > > Cc: Janusz Krzysztofik > > Subject: Re: [PATCH v5 i-g-t 0/8] Introduce KUnit > > > > On Monday, 5 June 2023 12:47:08 CEST Dominik Karol Piatkowski wrote: > > > This series is a continuation of Isabella's work on introducing KUnit > > > to IGT. > > > > > > Sample drm_buddy output: > > > Starting subtest: all-tests > > > [thread:8003] TAP version 1 > > > [thread:8003] Executing 6 tests in: drm_buddy > > > Starting dynamic subtest: drm_buddy__drm_test_buddy_alloc_limit > > > Dynamic subtest drm_buddy__drm_test_buddy_alloc_limit: > > SUCCESS (0.000s) > > > Starting dynamic subtest: > > drm_buddy__drm_test_buddy_alloc_range > > > Dynamic subtest drm_buddy__drm_test_buddy_alloc_range: > > SUCCESS (0.000s) > > > Starting dynamic subtest: > > drm_buddy__drm_test_buddy_alloc_optimistic > > > Dynamic subtest drm_buddy__drm_test_buddy_alloc_optimistic: > > SUCCESS (0.000s) > > > Starting dynamic subtest: > > drm_buddy__drm_test_buddy_alloc_pessimistic > > > Dynamic subtest drm_buddy__drm_test_buddy_alloc_pessimistic: > > SUCCESS (0.000s) > > > Starting dynamic subtest: > > drm_buddy__drm_test_buddy_alloc_smoke > > > Dynamic subtest drm_buddy__drm_test_buddy_alloc_smoke: > > SUCCESS (0.000s) > > > Starting dynamic subtest: > > drm_buddy__drm_test_buddy_alloc_pathological > > > Dynamic subtest drm_buddy__drm_test_buddy_alloc_pathological: > > SUCCESS (0.000s) > > > Starting dynamic subtest: drm_buddy > > > Dynamic subtest drm_buddy: SUCCESS (0.000s) > > > Subtest all-tests: SUCCESS (0.707s) > > > > It would be nice if we could see CI results from the new kunit subtests > > before accepting the series. Unfortunately, none of the tests seems to have > > been executed within the pre-merge run. Can we fix that? > > AFAIK, Kconfig used by CI does not have required params set (CONFIG_KUNIT and CONFIG_DRM_I915_KUNIT_SELFTESTS). I submitted a merge request to enable these params, but it was not merged yet. The best option I can think of right now, is a trybot run tested with Kconfig patch enabling these params. Would that be ok with you? Where is such merge request? Let's review/merge it first. Then, re-trigger the test. Regards, Mauro