From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3453610E53B for ; Wed, 7 Jun 2023 18:23:19 +0000 (UTC) From: =?UTF-8?q?Zbigniew=20Kempczy=C5=84ski?= To: igt-dev@lists.freedesktop.org Date: Wed, 7 Jun 2023 20:23:13 +0200 Message-Id: <20230607182313.82079-1-zbigniew.kempczynski@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [igt-dev] [PATCH i-g-t v3] tests/xe_create: Add multiple engines create/destroy subtest List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: Exercise basic engine concurrency create/destroy functionality. v2: use different random seeds in children to avoid same engine pattern selection (Kamil) check execution time and report failure if it's too long (Kamil) Signed-off-by: Zbigniew Kempczyński Cc: Kamil Konieczny --- tests/xe/xe_create.c | 106 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 106 insertions(+) diff --git a/tests/xe/xe_create.c b/tests/xe/xe_create.c index ae21154646..d85a22567c 100644 --- a/tests/xe/xe_create.c +++ b/tests/xe/xe_create.c @@ -88,6 +88,106 @@ static void create_invalid_size(int fd) xe_vm_destroy(fd, vm); } +enum engine_destroy { + NOLEAK, + LEAK +}; + +static uint32_t __xe_engine_create(int fd, uint32_t vm, + struct drm_xe_engine_class_instance *instance, + uint64_t ext, + uint32_t *enginep) +{ + struct drm_xe_engine_create create = { + .extensions = ext, + .vm_id = vm, + .width = 1, + .num_placements = 1, + .instances = to_user_pointer(instance), + }; + int err = 0; + + if (igt_ioctl(fd, DRM_IOCTL_XE_ENGINE_CREATE, &create) == 0) { + *enginep = create.engine_id; + } else { + igt_warn("Can't create engine, errno: %d\n", errno); + err = -errno; + igt_assume(err); + } + errno = 0; + + return err; +} + +#define MAXENGINES 2048 +#define MAXTIME 2 + +/** + * SUBTEST: create-engines-%s + * Description: Check process ability of multiple engines creation + * Run type: FULL + * + * arg[1]: + * + * @noleak: destroy engines in the code + * @leak: destroy engines in close() path + */ +static void create_engines(int fd, enum engine_destroy ed) +{ + struct timespec tv = { }; + uint32_t num_engines, engines_per_process, vm; + int nproc = sysconf(_SC_NPROCESSORS_ONLN), seconds; + bool failed = false; + + fd = drm_reopen_driver(fd); + num_engines = xe_number_hw_engines(fd); + vm = xe_vm_create(fd, DRM_XE_VM_CREATE_ASYNC_BIND_OPS, 0); + + engines_per_process = max_t(uint32_t, 1, MAXENGINES / nproc); + igt_debug("nproc: %u, engines per process: %u\n", nproc, engines_per_process); + + igt_nsec_elapsed(&tv); + + igt_fork(n, nproc) { + struct drm_xe_engine_class_instance *hwe; + uint32_t engine, engines[engines_per_process]; + int idx, err, i; + + srandom(n); + + for (i = 0; i < engines_per_process; i++) { + idx = rand() % num_engines; + hwe = xe_hw_engine(fd, idx); + err = __xe_engine_create(fd, vm, hwe, 0, &engine); + igt_debug("[%2d] Create engine: err=%d, engine=%u [idx = %d]\n", + n, err, engine, i); + if (err) + break; + + if (ed == NOLEAK) + engines[i] = engine; + } + + if (ed == NOLEAK) { + while (--i >= 0) { + igt_debug("[%2d] Destroy engine: %u\n", n, engines[i]); + xe_engine_destroy(fd, engines[i]); + } + } + } + igt_waitchildren(); + + xe_vm_destroy(fd, vm); + close(fd); + + seconds = igt_seconds_elapsed(&tv); + if (seconds >= MAXTIME) + failed = true; + + igt_assert_f(!failed, "Creating %d engines tooks too long: %d [limit: %d]\n", + MAXENGINES, seconds, MAXTIME); +} + /** * SUBTEST: create-massive-size * Description: Verifies xe bo create returns expected error code on massive @@ -121,6 +221,12 @@ igt_main create_invalid_size(xe); } + igt_subtest("create-engines-noleak") + create_engines(xe, NOLEAK); + + igt_subtest("create-engines-leak") + create_engines(xe, LEAK); + igt_subtest("create-massive-size") { create_massive_size(xe); } -- 2.34.1