From: Mauro Carvalho Chehab <mauro.chehab@linux.intel.com>
To: Dominik Karol Piatkowski <dominik.karol.piatkowski@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 8/9] KUnit: Change subtest name from all-tests to module name
Date: Mon, 12 Jun 2023 15:15:00 +0200 [thread overview]
Message-ID: <20230612151500.612491b1@maurocar-mobl2> (raw)
In-Reply-To: <20230612124916.7372-9-dominik.karol.piatkowski@intel.com>
On Mon, 12 Jun 2023 14:49:15 +0200
Dominik Karol Piatkowski <dominik.karol.piatkowski@intel.com> wrote:
> Use KUnit module name instead of all-tests when no name is specified.
>
> Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@intel.com>
> Cc: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
> Cc: Mauro Carvalho Chehab <mauro.chehab@linux.intel.com>
Works for me.
Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> ---
> lib/igt_kmod.c | 2 +-
> tests/drm_mm.c | 42 +++++++++++++++++++++---------------------
> 2 files changed, 22 insertions(+), 22 deletions(-)
>
> diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
> index a6e751482..1511bdef4 100644
> --- a/lib/igt_kmod.c
> +++ b/lib/igt_kmod.c
> @@ -855,7 +855,7 @@ void igt_kunit(const char *module_name, const char *name, const char *opts)
> * and for documentation.
> */
> if (name == NULL)
> - name = "all-tests";
> + name = module_name;
>
> igt_subtest_with_dynamic(name)
> __igt_kunit(module_name, opts);
> diff --git a/tests/drm_mm.c b/tests/drm_mm.c
> index 089eae2b9..9a8b3f3fc 100644
> --- a/tests/drm_mm.c
> +++ b/tests/drm_mm.c
> @@ -29,123 +29,123 @@
> * Feature: mapping
> * Run type: FULL
> *
> - * SUBTEST: all-tests
> + * SUBTEST: drm_mm_test
> *
> - * SUBTEST: all-tests@align
> + * SUBTEST: drm_mm_test@align
> * Category: Infrastructure
> * Description: drm_mm range manager SW validation
> * Functionality: DRM memory mangemnt
> * Test category: GEM_Legacy
> *
> - * SUBTEST: all-tests@align32
> + * SUBTEST: drm_mm_test@align32
> * Category: Infrastructure
> * Description: drm_mm range manager SW validation
> * Functionality: DRM memory mangemnt
> * Test category: GEM_Legacy
> *
> - * SUBTEST: all-tests@align64
> + * SUBTEST: drm_mm_test@align64
> * Category: Infrastructure
> * Description: drm_mm range manager SW validation
> * Functionality: DRM memory mangemnt
> * Test category: GEM_Legacy
> *
> - * SUBTEST: all-tests@bottomup
> + * SUBTEST: drm_mm_test@bottomup
> * Category: Infrastructure
> * Description: drm_mm range manager SW validation
> * Functionality: DRM memory mangemnt
> * Test category: GEM_Legacy
> *
> - * SUBTEST: all-tests@color
> + * SUBTEST: drm_mm_test@color
> * Category: Infrastructure
> * Description: drm_mm range manager SW validation
> * Functionality: DRM memory mangemnt
> * Test category: GEM_Legacy
> *
> - * SUBTEST: all-tests@color_evict
> + * SUBTEST: drm_mm_test@color_evict
> * Category: Infrastructure
> * Description: drm_mm range manager SW validation
> * Functionality: DRM memory mangemnt
> * Test category: GEM_Legacy
> *
> - * SUBTEST: all-tests@color_evict_range
> + * SUBTEST: drm_mm_test@color_evict_range
> * Category: Infrastructure
> * Description: drm_mm range manager SW validation
> * Functionality: DRM memory mangemnt
> * Test category: GEM_Legacy
> *
> - * SUBTEST: all-tests@debug
> + * SUBTEST: drm_mm_test@debug
> * Category: Infrastructure
> * Description: drm_mm range manager SW validation
> * Functionality: DRM memory mangemnt
> * Test category: GEM_Legacy
> *
> - * SUBTEST: all-tests@evict
> + * SUBTEST: drm_mm_test@evict
> * Category: Infrastructure
> * Description: drm_mm range manager SW validation
> * Functionality: DRM memory mangemnt
> * Test category: GEM_Legacy
> *
> - * SUBTEST: all-tests@evict_range
> + * SUBTEST: drm_mm_test@evict_range
> * Category: Infrastructure
> * Description: drm_mm range manager SW validation
> * Functionality: DRM memory mangemnt
> * Test category: GEM_Legacy
> *
> - * SUBTEST: all-tests@frag
> + * SUBTEST: drm_mm_test@frag
> * Category: Infrastructure
> * Description: drm_mm range manager SW validation
> * Functionality: DRM memory mangemnt
> * Test category: GEM_Legacy
> *
> - * SUBTEST: all-tests@highest
> + * SUBTEST: drm_mm_test@highest
> * Category: Infrastructure
> * Description: drm_mm range manager SW validation
> * Functionality: DRM memory mangemnt
> * Test category: GEM_Legacy
> *
> - * SUBTEST: all-tests@init
> + * SUBTEST: drm_mm_test@init
> * Category: Infrastructure
> * Description: drm_mm range manager SW validation
> * Functionality: DRM memory mangemnt
> * Test category: GEM_Legacy
> *
> - * SUBTEST: all-tests@insert
> + * SUBTEST: drm_mm_test@insert
> * Category: Infrastructure
> * Description: drm_mm range manager SW validation
> * Functionality: DRM memory mangemnt
> * Test category: GEM_Legacy
> *
> - * SUBTEST: all-tests@insert_range
> + * SUBTEST: drm_mm_test@insert_range
> * Category: Infrastructure
> * Description: drm_mm range manager SW validation
> * Functionality: DRM memory mangemnt
> * Test category: GEM_Legacy
> *
> - * SUBTEST: all-tests@lowest
> + * SUBTEST: drm_mm_test@lowest
> * Category: Infrastructure
> * Description: drm_mm range manager SW validation
> * Functionality: DRM memory mangemnt
> * Test category: GEM_Legacy
> *
> - * SUBTEST: all-tests@replace
> + * SUBTEST: drm_mm_test@replace
> * Category: Infrastructure
> * Description: drm_mm range manager SW validation
> * Functionality: DRM memory mangemnt
> * Test category: GEM_Legacy
> *
> - * SUBTEST: all-tests@reserve
> + * SUBTEST: drm_mm_test@reserve
> * Category: Infrastructure
> * Description: drm_mm range manager SW validation
> * Functionality: DRM memory mangemnt
> * Test category: GEM_Legacy
> *
> - * SUBTEST: all-tests@sanitycheck
> + * SUBTEST: drm_mm_test@sanitycheck
> * Category: Infrastructure
> * Description: drm_mm range manager SW validation
> * Functionality: DRM memory mangemnt
> * Test category: GEM_Legacy
> *
> - * SUBTEST: all-tests@topdown
> + * SUBTEST: drm_mm_test@topdown
> * Category: Infrastructure
> * Description: drm_mm range manager SW validation
> * Functionality: DRM memory mangemnt
next prev parent reply other threads:[~2023-06-12 13:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 12:49 [igt-dev] [PATCH v6 i-g-t 0/9] Introduce KUnit Dominik Karol Piatkowski
2023-06-12 12:49 ` [igt-dev] [PATCH i-g-t 1/9] lib/igt_kmod: rename kselftest functions to ktest Dominik Karol Piatkowski
2023-06-12 12:49 ` [igt-dev] [PATCH i-g-t 2/9] lib/igt_kmod.c: check if module is builtin before attempting to unload it Dominik Karol Piatkowski
2023-06-12 12:49 ` [igt-dev] [PATCH i-g-t 3/9] lib/igt_kmod: add compatibility for KUnit Dominik Karol Piatkowski
2023-06-12 12:49 ` [igt-dev] [PATCH i-g-t 4/9] tests: DRM selftests: switch to KUnit Dominik Karol Piatkowski
2023-06-12 12:49 ` [igt-dev] [PATCH i-g-t 5/9] Change logic of ktap parser to run on a thread Dominik Karol Piatkowski
2023-06-12 12:49 ` [igt-dev] [PATCH i-g-t 6/9] kunit tests: add an optional name for the selftests Dominik Karol Piatkowski
2023-06-12 12:49 ` [igt-dev] [PATCH i-g-t 7/9] KUnit: Remove igt_kselftest fallback Dominik Karol Piatkowski
2023-06-12 13:16 ` Mauro Carvalho Chehab
2023-06-12 12:49 ` [igt-dev] [PATCH i-g-t 8/9] KUnit: Change subtest name from all-tests to module name Dominik Karol Piatkowski
2023-06-12 13:15 ` Mauro Carvalho Chehab [this message]
2023-06-12 12:49 ` [igt-dev] [PATCH i-g-t 9/9] tests/xe: Add a test that launches the xe driver live kunit tests Dominik Karol Piatkowski
2023-06-12 13:32 ` [igt-dev] ✓ Fi.CI.BAT: success for Introduce KUnit (rev6) Patchwork
2023-06-12 20:14 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230612151500.612491b1@maurocar-mobl2 \
--to=mauro.chehab@linux.intel.com \
--cc=dominik.karol.piatkowski@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox