Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Kunal Joshi <kunal1.joshi@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: kunal1.joshi@intel.com
Subject: [igt-dev] [PATCH i-g-t 2/6] RFC tests/i915/kms_frontbuffer_tracking: xe doesn't support tiling as of now
Date: Tue, 13 Jun 2023 00:31:30 +0530	[thread overview]
Message-ID: <20230612190134.2902272-3-kunal1.joshi@intel.com> (raw)
In-Reply-To: <20230612190134.2902272-1-kunal1.joshi@intel.com>

XE doesn't support tiling as of now, so set tiling to linear

v2: use is_xe_device() instead of static variable (Jouni)
    assert if xe device and unsupported tiling method specified
    in opt handler (Jouni)
v3: Fix condition in igt_assert
v4: Keep tiling check in igt_require (Bhanu)
v5: Handle opt.tiling elegantly (Bhanu)

Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
---
 tests/i915/kms_frontbuffer_tracking.c | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/tests/i915/kms_frontbuffer_tracking.c b/tests/i915/kms_frontbuffer_tracking.c
index c2b99670..61403afb 100644
--- a/tests/i915/kms_frontbuffer_tracking.c
+++ b/tests/i915/kms_frontbuffer_tracking.c
@@ -261,7 +261,6 @@ struct {
 	.only_pipes = PIPE_COUNT,
 	.shared_fb_x_offset = 248,
 	.shared_fb_y_offset = 500,
-	.tiling = TILING_DEFAULT,
 };
 
 struct modeset_params {
@@ -1341,6 +1340,16 @@ static void setup_drm(void)
 	drm.fd = drm_open_driver_master(DRIVER_INTEL | DRIVER_XE);
 	drm.debugfs = igt_debugfs_dir(drm.fd);
 
+	/*
+	 * Skip if xe device and unsupported tiling method specified
+	 * in opt_handler
+	 */
+	if (opt.tiling)
+		igt_require(is_i915_device(drm.fd) ||
+			    (is_xe_device(drm.fd) && opt.tiling == TILING_LINEAR));
+	else
+		opt.tiling = is_i915_device(drm.fd) ? TILING_DEFAULT : TILING_LINEAR;
+
 	kmstest_set_vt_graphics_mode();
 	igt_display_require(&drm.display, drm.fd);
 
@@ -3634,6 +3643,7 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
 
 			for (t.tiling = TILING_LINEAR; t.tiling < TILING_COUNT;
 			     t.tiling++) {
+
 				if (t.tiling == TILING_X)
 					continue;
 
@@ -3646,6 +3656,9 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
 					      feature_str(t.feature),
 					      tiling_str(t.tiling)) {
 
+					if (is_xe_device(drm.fd))
+						igt_require(t.tiling == TILING_LINEAR);
+
 					/* Tiling Y is only supported on GEN9+ */
 					if (t.tiling == TILING_Y) {
 						igt_require(AT_LEAST_GEN(devid, 9));
-- 
2.34.1

  parent reply	other threads:[~2023-06-12 18:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-12 19:01 [igt-dev] [PATCH i-g-t 0/6] RFC Enable kms_frontbuffer_tracking on X Kunal Joshi
2023-06-12 19:01 ` [igt-dev] [PATCH i-g-t 1/6] RFC tests/i915/kms_frontbuffer_tracking: Add xe support Kunal Joshi
2023-06-12 19:01 ` Kunal Joshi [this message]
2023-06-13  5:59   ` [igt-dev] [PATCH i-g-t 2/6] RFC tests/i915/kms_frontbuffer_tracking: xe doesn't support tiling as of now Modem, Bhanuprakash
2023-06-12 19:01 ` [igt-dev] [PATCH i-g-t 3/6] tests/i915/kms_frontbuffer_tracking: all gem ioctls are not supported for xe " Kunal Joshi
2023-06-12 19:01 ` [igt-dev] [PATCH i-g-t 4/6] RFC lib/ioctl_wrappers: GEM_SET_DOMAIN ioctl not supported on xe Kunal Joshi
2023-06-12 19:01 ` [igt-dev] [PATCH i-g-t 5/6] RFC tests/i915/kms_frontbuffer_tracking: xe only supports MMAP_WC, BLT, RENDER Kunal Joshi
2023-06-13  6:01   ` Modem, Bhanuprakash
2023-06-12 19:01 ` [igt-dev] [PATCH i-g-t 6/6] HAX: test kms_frontbuffer_tracking for regression by changes Kunal Joshi
2023-06-12 20:05 ` [igt-dev] ✗ Fi.CI.BAT: failure for RFC Enable kms_frontbuffer_tracking on X Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2023-06-13 16:59 [igt-dev] [PATCH i-g-t 0/6] RFC Enable kms_frontbuffer_tracking on XE Kunal Joshi
2023-06-13 16:59 ` [igt-dev] [PATCH i-g-t 2/6] RFC tests/i915/kms_frontbuffer_tracking: xe doesn't support tiling as of now Kunal Joshi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230612190134.2902272-3-kunal1.joshi@intel.com \
    --to=kunal1.joshi@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox