From: Christoph Manszewski <christoph.manszewski@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v2 1/1] lib: Let gen7/gen8 inherit gen4_render.h
Date: Tue, 13 Jun 2023 11:44:55 +0200 [thread overview]
Message-ID: <20230613094455.2636571-2-christoph.manszewski@intel.com> (raw)
In-Reply-To: <20230613094455.2636571-1-christoph.manszewski@intel.com>
Currently 'PIPELINE_SELECT_3D' macros are redifined. This can lead to
compiler warnings when including headers containing those redifinitions.
Instead of redefining pipe selects, inherit them from gen4_render.h
Signed-off-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Signed-off-by: Christoph Manszewski <christoph.manszewski@intel.com>
---
lib/gen7_media.h | 2 +-
lib/gen8_media.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/gen7_media.h b/lib/gen7_media.h
index b5e49cae..93dc7312 100644
--- a/lib/gen7_media.h
+++ b/lib/gen7_media.h
@@ -3,6 +3,7 @@
#include <stdint.h>
#include "surfaceformat.h"
+#include "gen4_render.h"
#define GEN7_FLOATING_POINT_IEEE_754 0
#define GEN7_FLOATING_POINT_NON_IEEE_754 1
@@ -13,7 +14,6 @@
((Subopcode) << 16))
#define GEN7_PIPELINE_SELECT GFXPIPE(1, 1, 4)
-# define PIPELINE_SELECT_3D (0 << 0)
# define PIPELINE_SELECT_GPGPU (2 << 0)
#define GEN7_STATE_BASE_ADDRESS GFXPIPE(0, 1, 1)
diff --git a/lib/gen8_media.h b/lib/gen8_media.h
index b5c19e50..07ea2ac0 100644
--- a/lib/gen8_media.h
+++ b/lib/gen8_media.h
@@ -3,6 +3,7 @@
#include <stdint.h>
#include "surfaceformat.h"
+#include "gen4_render.h"
#define GEN8_FLOATING_POINT_IEEE_754 0
#define GEN8_FLOATING_POINT_NON_IEEE_754 1
@@ -13,7 +14,6 @@
((Subopcode) << 16))
#define GEN8_PIPELINE_SELECT GFXPIPE(1, 1, 4)
-# define PIPELINE_SELECT_3D (0 << 0)
#define GEN8_STATE_BASE_ADDRESS GFXPIPE(0, 1, 1)
--
2.40.1
next prev parent reply other threads:[~2023-06-13 9:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 9:44 [igt-dev] [PATCH i-g-t v2 0/1] lib: Avoid macro redifinition in gen7/gen8_media.h Christoph Manszewski
2023-06-13 9:44 ` Christoph Manszewski [this message]
2023-06-13 16:23 ` [igt-dev] [PATCH i-g-t v2 1/1] lib: Let gen7/gen8 inherit gen4_render.h Kamil Konieczny
2023-06-13 10:27 ` [igt-dev] ✓ Fi.CI.BAT: success for lib: Avoid macro redifinition in gen7/gen8_media.h (rev2) Patchwork
2023-06-13 11:56 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230613094455.2636571-2-christoph.manszewski@intel.com \
--to=christoph.manszewski@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox