Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jasber Chen <yipeng.chen@amd.com>
To: <igt-dev@lists.freedesktop.org>
Cc: Jasber Chen <yipeng.chen@amd.com>
Subject: [igt-dev] [PATCH] From: Jasber Chen <yipeng.chen@amd.com>
Date: Thu, 15 Jun 2023 11:41:43 +0800	[thread overview]
Message-ID: <20230615034143.1319444-1-yipeng.chen@amd.com> (raw)

tests/amdgpu skips query-timestamp-while-idle test on raven/raven2 asic.
Querying GPU clocks can not work as expected when GPU is idling.

Change-Id: If2c6e9e358ce826a5e5d5f909819285b6ada821e
Signed-off-by: Jasber Chen <yipeng.chen@amd.com>
---
 tests/amdgpu/amd_info.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/tests/amdgpu/amd_info.c b/tests/amdgpu/amd_info.c
index d6aea827..644c370f 100644
--- a/tests/amdgpu/amd_info.c
+++ b/tests/amdgpu/amd_info.c
@@ -28,6 +28,8 @@
 #include <amdgpu.h>
 #include <amdgpu_drm.h>
 
+#include "lib/amdgpu/amdgpu_asic_addr.h"
+
 static amdgpu_device_handle dev;
 
 static void query_firmware_version_test(void)
@@ -121,9 +123,12 @@ static void query_timestamp_test(uint32_t sleep_time, int sample_count)
 
 IGT_TEST_DESCRIPTION("Test the consistency of the data provided through the "
 		     "DRM_AMDGPU_INFO IOCTL");
+
 igt_main
 {
 	int fd = -1;
+	int r = -1;
+	struct amdgpu_gpu_info gpu_info = {0};
 
 	igt_fixture {
 		uint32_t major, minor;
@@ -136,6 +141,9 @@ igt_main
 
 		igt_info("Initialized amdgpu, driver version %d.%d\n",
 			 major, minor);
+
+		r = amdgpu_query_gpu_info(dev, &gpu_info);
+		igt_assert_eq(r, 0);
 	}
 
 	igt_describe("Make sure we can retrieve the firmware version");
@@ -150,7 +158,13 @@ igt_main
 	igt_describe("Check that the GPU time keeps on ticking, even during "
 		     "long idle times which could lead to clock/power gating");
 	igt_subtest("query-timestamp-while-idle")
+	/* Skip query-timestamp-while-idle test on Raven / Raven2 */
+	/* GPU clocks may not work as expected when GPU is idling */
+	if(!ASICREV_IS_RAVEN(gpu_info.chip_external_rev) &&
+	   !ASICREV_IS_RAVEN2(gpu_info.chip_external_rev) )
+	{
 		query_timestamp_test(7000000, 1);
+	}
 
 	igt_fixture {
 		amdgpu_device_deinitialize(dev);
-- 
2.25.1

             reply	other threads:[~2023-06-15  3:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-15  3:41 Jasber Chen [this message]
2023-06-15 11:27 ` [igt-dev] [PATCH] From: Jasber Chen <yipeng.chen@amd.com> Kamil Konieczny
2023-06-15 12:37 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-06-15 14:38 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230615034143.1319444-1-yipeng.chen@amd.com \
    --to=yipeng.chen@amd.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox