Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mauro.chehab@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: aditya.chauhan@intel.com, Sai Gowtham Ch <sai.gowtham.ch@intel.com>
Subject: [igt-dev] [PATCH i-g-t] tests/xe/xe_spin_batch: fix test documentation
Date: Mon, 19 Jun 2023 11:53:24 +0200	[thread overview]
Message-ID: <20230619095324.3931861-1-mauro.chehab@linux.intel.com> (raw)

From: Mauro Carvalho Chehab <mchehab@kernel.org>

The test documentation is wrong:
- it should have just one TEST: tag with the contents of the
  test file;
- it is missing Category, Sub-category, Functionality and
  Test category fields. Those are needed for proper grafana
  functionality mapping.

Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
---
 tests/xe/xe_spin_batch.c | 19 ++++++++-----------
 1 file changed, 8 insertions(+), 11 deletions(-)

diff --git a/tests/xe/xe_spin_batch.c b/tests/xe/xe_spin_batch.c
index bc13bddddf73..29a837251058 100644
--- a/tests/xe/xe_spin_batch.c
+++ b/tests/xe/xe_spin_batch.c
@@ -4,15 +4,20 @@
 #include "xe/xe_ioctl.h"
 #include "xe/xe_query.h"
 
+/**
+ * TEST: Tests for spin batch submissons.
+ * Category: Software building block
+ * Sub-category: spin
+ * Functionality: intel-bb
+ * Test category: functionality test
+ */
+
 #define MAX_INSTANCE 9
 
 /**
- * TEST: Basic test for spin batch submissons.
- *
  * SUBTEST: spin-basic
  * Description: Basic test to submit spin batch submissons on copy engine.
  * Run type: FULL
- *
  */
 
 static void spin_basic(int fd)
@@ -28,12 +33,9 @@ static void spin_basic(int fd)
 }
 
 /**
- * TEST:Test for spin batch submissons.
- *
  * SUBTEST: spin-batch
  * Description: Create vm and engine of hwe class and run the spinner on it.
  * Run type: FULL
- *
  */
 
 static void spin(int fd, struct drm_xe_engine_class_instance *hwe)
@@ -57,12 +59,9 @@ static void spin(int fd, struct drm_xe_engine_class_instance *hwe)
 }
 
 /**
- * TEST: Basic test for spin batch submission on all hwe.
- *
  * SUBTEST: spin-basic-all
  * Description: Basic test which validates the functionality of spinner on all hwe.
  * Run type: FULL
- *
  */
 static void spin_basic_all(int fd)
 {
@@ -91,11 +90,9 @@ static void spin_basic_all(int fd)
 }
 
 /**
- * TEST: Test for spin batch submissions.
  * SUBTEST: spin-all
  * Description: Spinner test to run on all the engines!
  * Run type: FULL
- *
  */
 
 static void spin_all(int fd, int gt, int class)
-- 
2.40.1

             reply	other threads:[~2023-06-19  9:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-19  9:53 Mauro Carvalho Chehab [this message]
2023-06-19 10:17 ` [igt-dev] [PATCH i-g-t] tests/xe/xe_spin_batch: fix test documentation Ch, Sai Gowtham
2023-06-19 17:50 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230619095324.3931861-1-mauro.chehab@linux.intel.com \
    --to=mauro.chehab@linux.intel.com \
    --cc=aditya.chauhan@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=sai.gowtham.ch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox