Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [i-g-t 10/18] tests/i915/kms_big_fb: Add tiling support for XE
Date: Mon, 19 Jun 2023 17:28:50 +0530	[thread overview]
Message-ID: <20230619115858.2013195-11-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20230619115858.2013195-1-bhanuprakash.modem@intel.com>

Remove the tiling restrictions in Xe specific tests

Fixes: 34168d915 (tests/i915/kms_big_fb: Add XE support)
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/i915/kms_big_fb.c | 23 +----------------------
 1 file changed, 1 insertion(+), 22 deletions(-)

diff --git a/tests/i915/kms_big_fb.c b/tests/i915/kms_big_fb.c
index c120a14a6..34e6e9c46 100644
--- a/tests/i915/kms_big_fb.c
+++ b/tests/i915/kms_big_fb.c
@@ -928,10 +928,6 @@ igt_main
 	for (int i = 1; i < ARRAY_SIZE(modifiers); i++) {
 		igt_subtest_f("%s-addfb-size-overflow",
 			      modifiers[i].name) {
-			/* No tiling support in XE. */
-			igt_skip_on(is_xe_device(data.drm_fd) &&
-				    modifiers[i].modifier != DRM_FORMAT_MOD_LINEAR);
-
 			data.modifier = modifiers[i].modifier;
 			test_size_overflow(&data);
 		}
@@ -941,10 +937,6 @@ igt_main
 	for (int i = 1; i < ARRAY_SIZE(modifiers); i++) {
 		igt_subtest_f("%s-addfb-size-offset-overflow",
 			      modifiers[i].name) {
-			/* No tiling support in XE. */
-			igt_skip_on(is_xe_device(data.drm_fd) &&
-				    modifiers[i].modifier != DRM_FORMAT_MOD_LINEAR);
-
 			data.modifier = modifiers[i].modifier;
 			test_size_offset_overflow(&data);
 		}
@@ -953,10 +945,6 @@ igt_main
 	igt_describe("Sanity check if addfb ioctl works correctly for given size and strides of fb");
 	for (int i = 0; i < ARRAY_SIZE(modifiers); i++) {
 		igt_subtest_f("%s-addfb", modifiers[i].name) {
-			/* No tiling support in XE. */
-			igt_skip_on(is_xe_device(data.drm_fd) &&
-				    modifiers[i].modifier != DRM_FORMAT_MOD_LINEAR);
-
 			data.modifier = modifiers[i].modifier;
 			test_addfb(&data);
 		}
@@ -974,13 +962,8 @@ igt_main
 				igt_describe("Sanity check if addfb ioctl works correctly for given "
 						"combination of modifier formats and rotation");
 				igt_subtest_f("%s-%dbpp-rotate-%d", modifiers[i].name,
-					      formats[j].bpp, rotations[k].angle) {
-					/* No tiling support in XE. */
-					igt_skip_on(is_xe_device(data.drm_fd) &&
-						    data.modifier != DRM_FORMAT_MOD_LINEAR);
-
+					      formats[j].bpp, rotations[k].angle)
 					test_scanout(&data);
-				}
 			}
 
 			igt_fixture
@@ -1022,10 +1005,6 @@ igt_main
 						igt_require(intel_display_ver(intel_get_drm_devid(data.drm_fd)) >= 5);
 						data.max_hw_fb_width = min(data.hw_stride / (formats[j].bpp >> 3), data.max_fb_width);
 
-						/* No tiling support in XE. */
-						igt_skip_on(is_xe_device(data.drm_fd) &&
-							    modifiers[i].modifier != DRM_FORMAT_MOD_LINEAR);
-
 						test_scanout(&data);
 					}
 
-- 
2.40.0

  parent reply	other threads:[~2023-06-19 12:05 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-19 11:58 [igt-dev] [i-g-t 00/18] Add XE suppor for display tests Bhanuprakash Modem
2023-06-19 11:58 ` [igt-dev] [i-g-t 01/18] lib: Add tiling support for XE Bhanuprakash Modem
2023-06-19 11:58 ` [igt-dev] [i-g-t 02/18] lib/igt_fb: Intel bops & ibb is mandatory " Bhanuprakash Modem
2023-06-19 11:58 ` [igt-dev] [i-g-t 03/18] tests/kms_cursor_edge_walk: Fix intel specific checks Bhanuprakash Modem
2023-06-19 11:58 ` [igt-dev] [i-g-t 04/18] tests/kms_getfb: Extended ccs tests to support XE Bhanuprakash Modem
2023-06-19 11:58 ` [igt-dev] [i-g-t 05/18] tests/kms_addfb_basic: Add tiling support for XE Bhanuprakash Modem
2023-06-19 11:58 ` [igt-dev] [i-g-t 06/18] tests/kms_plane: " Bhanuprakash Modem
2023-06-19 11:58 ` [igt-dev] [i-g-t 07/18] tests/kms_plane_lowres: " Bhanuprakash Modem
2023-06-19 11:58 ` [igt-dev] [i-g-t 08/18] tests/kms_plane_scaling: " Bhanuprakash Modem
2023-06-19 11:58 ` [igt-dev] [i-g-t 09/18] tests/kms_rotation_crc: " Bhanuprakash Modem
2023-06-19 11:58 ` Bhanuprakash Modem [this message]
2023-06-19 11:58 ` [igt-dev] [i-g-t 11/18] tests/i915/kms_draw_crc: " Bhanuprakash Modem
2023-06-19 11:58 ` [igt-dev] [i-g-t 12/18] tests/i915/kms_flip_scaled_crc: " Bhanuprakash Modem
2023-06-19 11:58 ` [igt-dev] [i-g-t 13/18] tests/i915/kms_flip_tiling: " Bhanuprakash Modem
2023-06-19 11:58 ` [igt-dev] [i-g-t 14/18] tests/i915/kms_ccs: Add XE support Bhanuprakash Modem
2023-06-19 11:58 ` [igt-dev] [i-g-t 15/18] tests/i915/kms_fb_coherancy: " Bhanuprakash Modem
2023-06-19 11:58 ` [igt-dev] [i-g-t 16/18] tests/i915/kms_fbcon_fbt: " Bhanuprakash Modem
2023-06-19 11:58 ` [igt-dev] [i-g-t 17/18] tests/kms_async_flips: " Bhanuprakash Modem
2023-07-19  3:01   ` Karthik B S
2023-06-19 11:58 ` [igt-dev] [i-g-t 18/18] tests/kms_prime: " Bhanuprakash Modem
2023-06-19 18:54 ` [igt-dev] ✗ Fi.CI.BAT: failure for Add XE suppor for display tests Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230619115858.2013195-11-bhanuprakash.modem@intel.com \
    --to=bhanuprakash.modem@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox