From: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Upadhyay <tejas.upadhyay@intel.com>
Subject: [igt-dev] [PATCH v4 2/4] lib/igt_sysfs: Handling gt related sysfs uapi changes
Date: Tue, 27 Jun 2023 23:38:03 +0530 [thread overview]
Message-ID: <20230627180805.4189160-3-himal.prasad.ghimiray@intel.com> (raw)
In-Reply-To: <20230627180805.4189160-1-himal.prasad.ghimiray@intel.com>
Patch https://patchwork.freedesktop.org/series/118927/
is moving gt sysfs parent under tile folder.
With the above patch path for sysfs changes:
from: /sys/class/drm/cardX/device/gtN/
to : /sys/class/drm/cardX/device/tileN/gtN
Adding xe_for_each_gt_under_each_tile macro to
access new path.
v2:
- Calculate number of tiles once within iterator. (Rahul)
v3:
- Drop usage of local variable for tilecount.
- Change order of tile and gt. (Ashutosh)
Reviewed-by: Upadhyay <tejas.upadhyay@intel.com>
Cc: Aravind Iddamsetty <aravind.iddamsetty@intel.com>
Cc: Upadhyay <tejas.upadhyay@intel.com>
Cc: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
Cc: Francois Dugast <francois.dugast@intel.com>
Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
Cc: Matt Roper <matthew.d.roper@intel.com>
Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
---
lib/igt_sysfs.h | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/lib/igt_sysfs.h b/lib/igt_sysfs.h
index de2c9a86..e4a0451b 100644
--- a/lib/igt_sysfs.h
+++ b/lib/igt_sysfs.h
@@ -80,6 +80,12 @@
#define xe_for_each_tile for_each_sysfs_tile_dirfd
+/* FIXME: Need to revisit if GT indexing under TILE changes from KMD */
+#define xe_for_each_gt_under_each_tile(xe__, tile__, gt__) \
+ for (gt__ = 0, tile__ = 0; \
+ gt__ < xe_number_gt(xe__); \
+ (xe_number_gt(xe__) == igt_sysfs_get_num_tiles(xe__)) ? ++gt__, ++tile__ : ++gt__)
+
enum i915_attr_id {
RPS_ACT_FREQ_MHZ,
RPS_CUR_FREQ_MHZ,
--
2.25.1
next prev parent reply other threads:[~2023-06-27 18:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 18:08 [igt-dev] [PATCH v4 0/4] Handle GT and tile seperation in IGT Himal Prasad Ghimiray
2023-06-27 18:08 ` [igt-dev] [PATCH v4 1/4] lib/igt_sysfs: Add support to query number of tiles Himal Prasad Ghimiray
2023-07-01 17:09 ` Dixit, Ashutosh
2023-07-04 4:41 ` Ghimiray, Himal Prasad
2023-06-27 18:08 ` Himal Prasad Ghimiray [this message]
2023-06-27 18:08 ` [igt-dev] [PATCH v4 3/4] tests/xe/xe_guc_pc: Change the sysfs paths Himal Prasad Ghimiray
2023-06-30 17:33 ` Kamil Konieczny
2023-07-05 8:31 ` Ghimiray, Himal Prasad
2023-07-01 17:58 ` Dixit, Ashutosh
2023-07-03 8:00 ` Kamil Konieczny
2023-07-04 5:46 ` Ghimiray, Himal Prasad
2023-06-27 18:08 ` [igt-dev] [PATCH v4 4/4] tests/xe/xe_sysfs_tile_prop: adds new test to verify per tile vram addr_range Himal Prasad Ghimiray
2023-06-27 19:07 ` [igt-dev] ✓ Fi.CI.BAT: success for Handle GT and tile seperation in IGT (rev3) Patchwork
2023-06-28 10:52 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-06-29 17:47 ` Kamil Konieczny
2023-06-30 7:35 ` Yedireswarapu, SaiX Nandan
2023-06-30 7:34 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230627180805.4189160-3-himal.prasad.ghimiray@intel.com \
--to=himal.prasad.ghimiray@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=tejas.upadhyay@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox