From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by gabe.freedesktop.org (Postfix) with ESMTPS id 44E0910E061 for ; Wed, 28 Jun 2023 12:53:06 +0000 (UTC) Received: by mail-lj1-x236.google.com with SMTP id 38308e7fff4ca-2b69f216c73so52841001fa.3 for ; Wed, 28 Jun 2023 05:53:06 -0700 (PDT) From: Juha-Pekka Heikkila To: igt-dev@lists.freedesktop.org Date: Wed, 28 Jun 2023 15:52:58 +0300 Message-Id: <20230628125258.6614-2-juhapekka.heikkila@gmail.com> In-Reply-To: <20230628125258.6614-1-juhapekka.heikkila@gmail.com> References: <20230628125258.6614-1-juhapekka.heikkila@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [igt-dev] [PATCH i-g-t 2/2] tests/i915/kms_big_fb: take out blitter fallback path as it is replaced with Cairo List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: After adding Cairo fallback path blitter path will never be used anymore Signed-off-by: Juha-Pekka Heikkila --- tests/i915/kms_big_fb.c | 19 ++++--------------- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/tests/i915/kms_big_fb.c b/tests/i915/kms_big_fb.c index 15bc35061..f8857d486 100644 --- a/tests/i915/kms_big_fb.c +++ b/tests/i915/kms_big_fb.c @@ -133,20 +133,9 @@ static void copy_pattern(data_t *data, /* * We expect the kernel to limit the max fb * size/stride to something that can still - * rendered with the blitter/render engine. + * rendered with the render engine. */ - if (data->render_copy) { - data->render_copy(data->ibb, src, sx, sy, w, h, dst, dx, dy); - } else { - w = min(w, src_fb->width - sx); - w = min(w, dst_fb->width - dx); - - h = min(h, src_fb->height - sy); - h = min(h, dst_fb->height - dy); - - intel_bb_blt_copy(data->ibb, src, sx, sy, src->surface[0].stride, - dst, dx, dy, dst->surface[0].stride, w, h, dst->bpp); - } + data->render_copy(data->ibb, src, sx, sy, w, h, dst, dx, dy); fini_buf(dst); fini_buf(src); @@ -976,10 +965,10 @@ igt_main /* * Gen3 render engine is limited to 2kx2k, whereas - * the display engine can do 4kx4k. Use the blitter + * the display engine can do 4kx4k. Use fallback cairo path * on gen3 to avoid exceeding the render engine limits. * On gen2 we could use either, but let's go for the - * blitter there as well. + * cairo there as well. */ if (intel_display_ver(data.devid) >= 4) data.render_copy = igt_get_render_copyfunc(data.devid); -- 2.25.1