Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arthur Grillo <arthurgrillo@riseup.net>
To: Development mailing list for IGT GPU Tools
	<igt-dev@lists.freedesktop.org>
Cc: tales.aparecida@gmail.com, andrealmeid@riseup.net
Subject: [igt-dev] [PATCH i-g-t] lib/igt_fb: Add check for intel device on use_enginecopy
Date: Mon,  3 Jul 2023 16:00:53 -0300	[thread overview]
Message-ID: <20230703190052.14865-2-arthurgrillo@riseup.net> (raw)

Certain tests (eg: kms_plane) are failing on vkms due to an assert in
intel_get_drm_devid which checks for an intel device.

Add check for intel device before calling intel_get_drm_devid.

Fixes: 422557124731 ("lib/igt_fb: include lib/intel_blt functions to blitter path")

Signed-off-by: Arthur Grillo <arthurgrillo@riseup.net>
---
 lib/igt_fb.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index 9529d198a..a8988274f 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -2526,6 +2526,9 @@ static bool blitter_ok(const struct igt_fb *fb)
 
 static bool use_enginecopy(const struct igt_fb *fb)
 {
+	if (!is_intel_device(fb->fd))
+		return false;
+
 	if (!is_xe_device(fb->fd) && blitter_ok(fb))
 		return false;
 
-- 
2.41.0

             reply	other threads:[~2023-07-03 19:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-03 19:00 Arthur Grillo [this message]
2023-07-03 19:34 ` [igt-dev] [PATCH i-g-t] lib/igt_fb: Add check for intel device on use_enginecopy Juha-Pekka Heikkila
2023-07-03 19:47 ` Maira Canal
2023-07-03 20:38 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-07-03 22:22 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-07-04  6:22   ` Juha-Pekka Heikkila

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230703190052.14865-2-arthurgrillo@riseup.net \
    --to=arthurgrillo@riseup.net \
    --cc=andrealmeid@riseup.net \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=tales.aparecida@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox