From: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v4 04/21] tests/gem_ccs: Use global image dump comparison function
Date: Wed, 12 Jul 2023 19:12:14 +0200 [thread overview]
Message-ID: <20230712171231.290555-5-zbigniew.kempczynski@intel.com> (raw)
In-Reply-To: <20230712171231.290555-1-zbigniew.kempczynski@intel.com>
As this function was extracted and available globally keeping local
version doesn't makes sense.
Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
---
tests/i915/gem_ccs.c | 50 +-------------------------------------------
1 file changed, 1 insertion(+), 49 deletions(-)
diff --git a/tests/i915/gem_ccs.c b/tests/i915/gem_ccs.c
index 9beddeaee4..8f5d5b4f96 100644
--- a/tests/i915/gem_ccs.c
+++ b/tests/i915/gem_ccs.c
@@ -85,54 +85,6 @@ struct test_config {
if (param.write_png) \
blt_surface_to_png((fd), (id), (name), (obj), (w), (h)); } while (0)
-static int compare_nxn(const struct blt_copy_object *surf1,
- const struct blt_copy_object *surf2,
- int xsize, int ysize, int bx, int by)
-{
- int x, y, corrupted;
- uint32_t pos, px1, px2;
-
- corrupted = 0;
- for (y = 0; y < ysize; y++) {
- for (x = 0; x < xsize; x++) {
- pos = bx * xsize + by * ysize * surf1->pitch / 4;
- pos += x + y * surf1->pitch / 4;
- px1 = surf1->ptr[pos];
- px2 = surf2->ptr[pos];
- if (px1 != px2)
- corrupted++;
- }
- }
-
- return corrupted;
-}
-
-static void dump_corruption_info(const struct blt_copy_object *surf1,
- const struct blt_copy_object *surf2)
-{
- const int xsize = 8, ysize = 8;
- int w, h, bx, by, corrupted;
-
- igt_assert(surf1->x1 == surf2->x1 && surf1->x2 == surf2->x2);
- igt_assert(surf1->y1 == surf2->y1 && surf1->y2 == surf2->y2);
- w = surf1->x2;
- h = surf1->y2;
-
- igt_info("dump corruption - width: %d, height: %d, sizex: %x, sizey: %x\n",
- surf1->x2, surf1->y2, xsize, ysize);
-
- for (by = 0; by < h / ysize; by++) {
- for (bx = 0; bx < w / xsize; bx++) {
- corrupted = compare_nxn(surf1, surf2, xsize, ysize, bx, by);
- if (corrupted == 0)
- igt_info(".");
- else
- igt_info("%c", '0' + corrupted);
- }
- igt_info("\n");
- }
-}
-
static void surf_copy(int i915,
const intel_ctx_t *ctx,
const struct intel_execution_engine2 *e,
@@ -232,7 +184,7 @@ static void surf_copy(int i915,
WRITE_PNG(i915, run_id, "corrected", &blt.dst, dst->x2, dst->y2);
result = memcmp(src->ptr, dst->ptr, src->size);
if (result)
- dump_corruption_info(src, dst);
+ blt_dump_corruption_info_32b(src, dst);
munmap(ccsmap, ccssize);
gem_close(i915, ccs);
--
2.34.1
next prev parent reply other threads:[~2023-07-12 17:15 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 17:12 [igt-dev] [PATCH i-g-t v4 00/21] Extend intel_blt to work on Xe Zbigniew Kempczyński
2023-07-12 17:12 ` [igt-dev] [PATCH i-g-t v4 01/21] lib/intel_blt: Add blt_ctrl_surf_object() helper Zbigniew Kempczyński
2023-07-13 6:53 ` Karolina Stolarek
2023-07-12 17:12 ` [igt-dev] [PATCH i-g-t v4 02/21] tests/gem_ccs: Drop local function for setting ctrl surface object Zbigniew Kempczyński
2023-07-13 6:59 ` Karolina Stolarek
2023-07-12 17:12 ` [igt-dev] [PATCH i-g-t v4 03/21] lib/intel_blt: Add dump of two surfaces comparison in 8x8 blocks Zbigniew Kempczyński
2023-07-13 7:08 ` Karolina Stolarek
2023-07-12 17:12 ` Zbigniew Kempczyński [this message]
2023-07-13 7:12 ` [igt-dev] [PATCH i-g-t v4 04/21] tests/gem_ccs: Use global image dump comparison function Karolina Stolarek
2023-07-12 17:12 ` [igt-dev] [PATCH i-g-t v4 05/21] tests/api_intel_allocator: Don't use allocator ahnd aliasing api Zbigniew Kempczyński
2023-07-12 17:12 ` [igt-dev] [PATCH i-g-t v4 06/21] lib/intel_allocator: Drop aliasing allocator handle api Zbigniew Kempczyński
2023-07-12 17:12 ` [igt-dev] [PATCH i-g-t v4 07/21] lib/intel_allocator: Remove extensive debugging Zbigniew Kempczyński
2023-07-12 17:12 ` [igt-dev] [PATCH i-g-t v4 08/21] lib/xe_ioctl: Export non-assert xe_exec function Zbigniew Kempczyński
2023-07-12 17:12 ` [igt-dev] [PATCH i-g-t v4 09/21] lib/xe_query: Use vramN when returning string region name Zbigniew Kempczyński
2023-07-12 17:12 ` [igt-dev] [PATCH i-g-t v4 10/21] lib/xe_query: Add xe_region_class() helper Zbigniew Kempczyński
2023-07-12 17:12 ` [igt-dev] [PATCH i-g-t v4 11/21] lib/drmtest: Add get_intel_driver() helper Zbigniew Kempczyński
2023-07-12 17:12 ` [igt-dev] [PATCH i-g-t v4 12/21] lib/xe_util: Return dynamic subtest name for Xe Zbigniew Kempczyński
2023-07-12 17:12 ` [igt-dev] [PATCH i-g-t v4 13/21] lib/xe_util: Add vm bind/unbind helper " Zbigniew Kempczyński
2023-07-13 7:15 ` Karolina Stolarek
2023-07-13 7:53 ` Zbigniew Kempczyński
2023-07-12 17:12 ` [igt-dev] [PATCH i-g-t v4 14/21] lib/intel_allocator: Add intel_allocator_bind() Zbigniew Kempczyński
2023-07-13 7:17 ` Karolina Stolarek
2023-07-12 17:12 ` [igt-dev] [PATCH i-g-t v4 15/21] lib/intel_ctx: Add xe context information Zbigniew Kempczyński
2023-07-13 7:22 ` Karolina Stolarek
2023-07-12 17:12 ` [igt-dev] [PATCH i-g-t v4 16/21] lib/intel_blt: Introduce blt_copy_init() helper to cache driver Zbigniew Kempczyński
2023-07-12 17:12 ` [igt-dev] [PATCH i-g-t v4 17/21] lib/intel_blt: Extend blitter library to support xe driver Zbigniew Kempczyński
2023-07-13 7:24 ` Karolina Stolarek
2023-07-12 17:12 ` [igt-dev] [PATCH i-g-t v4 18/21] tests/xe_ccs: Check if flatccs is working with block-copy for Xe Zbigniew Kempczyński
2023-07-13 7:40 ` Karolina Stolarek
2023-07-12 17:12 ` [igt-dev] [PATCH i-g-t v4 19/21] tests/xe_exercise_blt: Check blitter library fast-copy " Zbigniew Kempczyński
2023-07-13 7:43 ` Karolina Stolarek
2023-07-13 10:39 ` Zbigniew Kempczyński
2023-07-12 17:12 ` [igt-dev] [PATCH i-g-t v4 20/21] tests/api-intel-allocator: Adopt to exercise allocator to Xe Zbigniew Kempczyński
2023-07-12 17:12 ` [igt-dev] [PATCH i-g-t v4 21/21] tests/gem_ccs: Avoid writing png twice Zbigniew Kempczyński
2023-07-12 19:19 ` [igt-dev] ✓ Fi.CI.BAT: success for Extend intel_blt to work on Xe (rev4) Patchwork
2023-07-12 19:29 ` [igt-dev] ○ CI.xeBAT: info " Patchwork
2023-07-12 22:52 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-07-13 5:51 ` Zbigniew Kempczyński
2023-07-14 5:13 ` Yedireswarapu, SaiX Nandan
2023-07-13 7:30 ` [igt-dev] ○ CI.xeBAT: info " Patchwork
2023-07-14 5:02 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230712171231.290555-5-zbigniew.kempczynski@intel.com \
--to=zbigniew.kempczynski@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox