Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Kunal Joshi <kunal1.joshi@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Kunal Joshi <kunal1.joshi@intel.com>
Subject: [igt-dev] [PATCH i-g-t 3/3] lib/igt_chamelium: Added function to sort chamelium ports based on is_mapped
Date: Thu, 13 Jul 2023 14:47:26 +0530	[thread overview]
Message-ID: <20230713091726.272816-4-kunal1.joshi@intel.com> (raw)
In-Reply-To: <20230713091726.272816-1-kunal1.joshi@intel.com>

port_count was used to iterate on chamelium ports but its not
neccessary that mapped ports are always on the top chamelium_ports
array after autodiscovery

Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
---
 lib/igt_chamelium.c | 42 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/lib/igt_chamelium.c b/lib/igt_chamelium.c
index a737330a6..8358ca109 100644
--- a/lib/igt_chamelium.c
+++ b/lib/igt_chamelium.c
@@ -2638,6 +2638,44 @@ static bool get_connector_id_for_port(struct chamelium *chamelium,
 	return false;
 }
 
+static void selective_sort_ports(struct chamelium_port *ports) {
+    int mapped_count = 0;
+    int unmapped_count = 0;
+    int mapped_index = 0;
+    int unmapped_index = mapped_count;
+
+    /*
+     * Count the number of mapped and unmapped ports
+     */
+    for (int i = 0; i < CHAMELIUM_MAX_PORTS; i++) {
+        if (ports[i].is_mapped) {
+            mapped_count++;
+        } else {
+            unmapped_count++;
+        }
+    }
+
+    /*
+     * Rearrange the ports such that mapped ports are at the start
+     */
+    unmapped_index = mapped_count;
+
+    struct chamelium_port sorted_ports[CHAMELIUM_MAX_PORTS];
+
+    for (int i = 0; i < CHAMELIUM_MAX_PORTS; i++) {
+        if (ports[i].is_mapped) {
+            sorted_ports[mapped_index++] = ports[i];
+        } else {
+            sorted_ports[unmapped_index++] = ports[i];
+        }
+    }
+
+    /*
+     * Copy the sorted ports back to the original array
+     */
+    memcpy(ports, sorted_ports, CHAMELIUM_MAX_PORTS * sizeof(struct chamelium_port));
+}
+
 /**
  * chamelium_autodiscover: automagically discover the Chamelium port mapping
  *
@@ -2755,6 +2793,10 @@ unplug_port:
 	}
 	sleep(CHAMELIUM_HOTPLUG_DETECTION_DELAY);
 
+	/*
+	 * Sort the ports based on the is_mapped flag
+	 */
+	selective_sort_ports(chamelium->ports);
 	elapsed_ns = igt_nsec_elapsed(&start);
 	igt_debug("Auto-discovery took %fms and found %i connector(s)\n",
 		  (float)elapsed_ns / (1000 * 1000), chamelium->port_count);
-- 
2.25.1

  parent reply	other threads:[~2023-07-13  9:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-13  9:17 [igt-dev] [PATCH i-g-t 0/3] Fix autodiscovery in chamelium Kunal Joshi
2023-07-13  9:17 ` [igt-dev] [PATCH i-g-t 1/3] lib/igt_chamelium: reset chamelium before starting autodiscovery Kunal Joshi
2023-07-14  6:15   ` B, Jeevan
2023-07-13  9:17 ` [igt-dev] [PATCH i-g-t 2/3] lib/igt_chamelium: Added is_mapped to track mapped ports Kunal Joshi
2023-07-14  6:19   ` B, Jeevan
2023-07-13  9:17 ` Kunal Joshi [this message]
2023-07-14  6:27   ` [igt-dev] [PATCH i-g-t 3/3] lib/igt_chamelium: Added function to sort chamelium ports based on is_mapped B, Jeevan
2023-07-13 10:26 ` [igt-dev] ✓ Fi.CI.BAT: success for Fix autodiscovery in chamelium Patchwork
2023-07-13 12:05 ` [igt-dev] ○ CI.xeBAT: info " Patchwork
2023-07-13 13:25 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-07-18  5:41 ` [igt-dev] ○ CI.xeBAT: info for Fix autodiscovery in chamelium (rev2) Patchwork
2023-07-18  5:57 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-07-18  8:19 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230713091726.272816-4-kunal1.joshi@intel.com \
    --to=kunal1.joshi@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox