From: Ashutosh Dixit <ashutosh.dixit@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 12/20] tests/i915/perf: Don't load module
Date: Thu, 20 Jul 2023 16:17:48 -0700 [thread overview]
Message-ID: <20230720231756.3464641-13-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20230720231756.3464641-1-ashutosh.dixit@intel.com>
Because now the perf code is being shared between i915 and xe, we have two
modules to load and can't decide which to load unless we've loaded one. So
to avoid the chicken and egg issue, don't load any module. The default
module in the system should automatically get loaded.
Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
---
tests/i915/perf.c | 16 ----------------
1 file changed, 16 deletions(-)
diff --git a/tests/i915/perf.c b/tests/i915/perf.c
index 7cbf3f7ca287..e0afbbc45ea2 100644
--- a/tests/i915/perf.c
+++ b/tests/i915/perf.c
@@ -5952,22 +5952,6 @@ igt_main
const intel_ctx_t *ctx;
const struct intel_execution_engine2 *e;
- igt_fixture {
- struct stat sb;
-
- /*
- * Prior tests may have unloaded i915 or failed while
- * loading/unloading i915. Load i915 here before we stat the
- * files.
- */
- drm_load_module(DRIVER_INTEL);
-
- igt_require(stat(i9xe.sysctl_path_paranoid, &sb)
- == 0);
- igt_require(stat(i9xe.sysctl_path_max_sample_rate, &sb)
- == 0);
- }
-
igt_subtest("i915-ref-count")
test_i915_ref_count();
--
2.41.0
next prev parent reply other threads:[~2023-07-20 23:18 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 23:17 [igt-dev] [PATCH i-g-t 00/20] Extend i915/perf for testing Xe OA Ashutosh Dixit
2023-07-20 23:17 ` [igt-dev] [PATCH i-g-t 01/20] drm-uapi/xe_drm: OA changes Ashutosh Dixit
2023-07-20 23:17 ` [igt-dev] [PATCH i-g-t 02/20] lib/xe/xe_query: Add xe_gts interface Ashutosh Dixit
2023-07-20 23:17 ` [igt-dev] [PATCH i-g-t 03/20] lib/i915/perf: Add xe_perf_for_fd Ashutosh Dixit
2023-07-20 23:17 ` [igt-dev] [PATCH i-g-t 04/20] lib/i915/perf: Derive topology info for xe devices Ashutosh Dixit
2023-07-20 23:17 ` [igt-dev] [PATCH i-g-t 05/20] tests/i915/perf: Track variables across i915 and xe Ashutosh Dixit
2023-07-20 23:17 ` [igt-dev] [PATCH i-g-t 06/20] tests/i915/perf: Skip not ready tests for xe Ashutosh Dixit
2023-07-20 23:17 ` [igt-dev] [PATCH i-g-t 07/20] tests/i915/perf: Fix i915_perf_revision for use with xe Ashutosh Dixit
2023-07-20 23:17 ` [igt-dev] [PATCH i-g-t 08/20] tests/i915/perf: Fix sysfs functions for xe Ashutosh Dixit
2023-07-20 23:17 ` [igt-dev] [PATCH i-g-t 09/20] tests/i915/perf: Fix test_i915_ref_count " Ashutosh Dixit
2023-07-20 23:17 ` [igt-dev] [PATCH i-g-t 10/20] tests/i915/perf: Support only default_engine_group " Ashutosh Dixit
2023-07-20 23:17 ` [igt-dev] [PATCH i-g-t 11/20] tests/i915/perf: Only iterate over render engines " Ashutosh Dixit
2023-07-20 23:17 ` Ashutosh Dixit [this message]
2023-07-20 23:17 ` [igt-dev] [PATCH i-g-t 13/20] tests/i915/perf: Move test_sysctl_defaults after the fixture Ashutosh Dixit
2023-07-20 23:17 ` [igt-dev] [PATCH i-g-t 14/20] tests/i915/perf: Fix has_class_instance for xe Ashutosh Dixit
2023-07-20 23:17 ` [igt-dev] [PATCH i-g-t 15/20] tests/i915/perf: Temporarily skip render_copy " Ashutosh Dixit
2023-07-20 23:17 ` [igt-dev] [PATCH i-g-t 16/20] tests/i915/perf: Skip intel_ctx_create_all_physical " Ashutosh Dixit
2023-07-20 23:17 ` [igt-dev] [PATCH i-g-t 17/20] tests/i915/perf: Skip __for_each_render_engine " Ashutosh Dixit
2023-07-20 23:17 ` [igt-dev] [PATCH i-g-t 18/20] tests/i915/perf: Fix buf_map " Ashutosh Dixit
2023-07-21 5:17 ` Zbigniew Kempczyński
2023-07-20 23:17 ` [igt-dev] [PATCH i-g-t 19/20] tests/i915/perf: Use engine_id in gen12_test_mi_rpc " Ashutosh Dixit
2023-07-20 23:17 ` [igt-dev] [PATCH i-g-t 20/20] HAX: Add OA tests to xe-fast-feedback.testlist Ashutosh Dixit
2023-07-21 0:11 ` [igt-dev] ✓ Fi.CI.BAT: success for Extend i915/perf for testing Xe OA Patchwork
2023-07-21 0:19 ` [igt-dev] ○ CI.xeBAT: info " Patchwork
2023-07-21 5:19 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2023-08-08 0:59 [igt-dev] [PATCH i-g-t 00/20] " Ashutosh Dixit
2023-08-08 1:00 ` [igt-dev] [PATCH i-g-t 12/20] tests/i915/perf: Don't load module Ashutosh Dixit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230720231756.3464641-13-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox