Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [i-g-t V2 04/17] tests/kms_addfb_basic: Add tiling support for XE
Date: Wed,  2 Aug 2023 15:50:46 +0530	[thread overview]
Message-ID: <20230802102059.3650360-5-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20230802102059.3650360-1-bhanuprakash.modem@intel.com>

Remove the tiling restrictions in Xe specific tests

8c3b02be3 (tests/kms_addfb_basic: Add XE support)
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_addfb_basic.c | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
index 065f21975..9a6344376 100644
--- a/tests/kms_addfb_basic.c
+++ b/tests/kms_addfb_basic.c
@@ -391,7 +391,7 @@ static void tiling_tests(int fd)
 
 	igt_subtest_group {
 		igt_fixture {
-			igt_require_i915(fd);
+			igt_require_intel(fd);
 			tiled_x_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
 				DRM_FORMAT_XRGB8888, I915_FORMAT_MOD_X_TILED,
 				1024*4, NULL, NULL, NULL);
@@ -410,7 +410,8 @@ static void tiling_tests(int fd)
 		f.pitches[0] = 1024*4;
 		igt_describe("Check if addfb2 and rmfb call works for basic x-tiling test");
 		igt_subtest("basic-x-tiled-legacy") {
-			igt_require(gem_available_fences(fd) > 0);
+			if (is_i915_device(fd))
+				igt_require(gem_available_fences(fd) > 0);
 			f.handles[0] = tiled_x_bo;
 
 			do_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, &f);
@@ -420,6 +421,7 @@ static void tiling_tests(int fd)
 
 		igt_describe("Check if addfb2 call works for x and y tiling");
 		igt_subtest("framebuffer-vs-set-tiling") {
+			igt_require_i915(fd);
 			igt_require(gem_available_fences(fd) > 0);
 			f.handles[0] = gem_bo;
 
@@ -434,6 +436,7 @@ static void tiling_tests(int fd)
 		igt_describe("Test that addfb2 call fails correctly for pitches mismatch");
 			f.pitches[0] = 512*4;
 		igt_subtest("tile-pitch-mismatch") {
+			igt_require_i915(fd);
 			igt_require(gem_available_fences(fd) > 0);
 			f.handles[0] = tiled_x_bo;
 
@@ -443,8 +446,12 @@ static void tiling_tests(int fd)
 		igt_describe("Test that addfb2 call fails correctly for basic y-tiling test");
 		f.pitches[0] = 1024*4;
 		igt_subtest("basic-y-tiled-legacy") {
-			igt_require(!gem_has_lmem(fd));
-			igt_require(gem_available_fences(fd) > 0);
+			if (is_i915_device(fd)) {
+				igt_require(!gem_has_lmem(fd));
+				igt_require(gem_available_fences(fd) > 0);
+			} else {
+				igt_require(!xe_has_vram(fd));
+			}
 			f.handles[0] = tiled_y_bo;
 
 			do_ioctl_err(fd, DRM_IOCTL_MODE_ADDFB2, &f, EINVAL);
@@ -995,7 +1002,7 @@ igt_main
 		size_tests(fd);
 
 		igt_fixture
-			igt_require_i915(fd);
+			igt_require_intel(fd);
 
 		addfb25_ytile(fd);
 
-- 
2.40.0

  parent reply	other threads:[~2023-08-02 10:28 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-02 10:20 [igt-dev] [i-g-t V2 00/17] Add XE suppor for display tests Bhanuprakash Modem
2023-08-02 10:20 ` [igt-dev] [i-g-t V2 01/17] lib: Add tiling support for XE Bhanuprakash Modem
2023-08-02 10:20 ` [igt-dev] [i-g-t V2 02/17] tests/kms_cursor_edge_walk: Fix intel specific checks Bhanuprakash Modem
2023-08-02 10:20 ` [igt-dev] [i-g-t V2 03/17] tests/kms_getfb: Extended ccs tests to support XE Bhanuprakash Modem
2023-08-02 10:20 ` Bhanuprakash Modem [this message]
2023-08-02 10:20 ` [igt-dev] [i-g-t V2 05/17] tests/kms_plane: Add tiling support for XE Bhanuprakash Modem
2023-08-02 10:20 ` [igt-dev] [i-g-t V2 06/17] tests/kms_plane_lowres: " Bhanuprakash Modem
2023-08-02 10:20 ` [igt-dev] [i-g-t V2 07/17] tests/kms_plane_scaling: " Bhanuprakash Modem
2023-08-02 10:20 ` [igt-dev] [i-g-t V2 08/17] tests/kms_rotation_crc: " Bhanuprakash Modem
2023-08-02 10:20 ` [igt-dev] [i-g-t V2 09/17] tests/i915/kms_big_fb: " Bhanuprakash Modem
2023-08-02 10:20 ` [igt-dev] [i-g-t V2 10/17] tests/i915/kms_draw_crc: " Bhanuprakash Modem
2023-08-02 10:20 ` [igt-dev] [i-g-t V2 11/17] tests/i915/kms_flip_scaled_crc: " Bhanuprakash Modem
2023-08-02 10:20 ` [igt-dev] [i-g-t V2 12/17] tests/i915/kms_flip_tiling: " Bhanuprakash Modem
2023-08-02 10:20 ` [igt-dev] [i-g-t V2 13/17] tests/i915/kms_ccs: Add XE support Bhanuprakash Modem
2023-08-02 10:20 ` [igt-dev] [i-g-t V2 14/17] tests/i915/kms_fb_coherancy: " Bhanuprakash Modem
2023-08-02 10:20 ` [igt-dev] [i-g-t V2 15/17] tests/i915/kms_fbcon_fbt: " Bhanuprakash Modem
2023-08-02 10:20 ` [igt-dev] [i-g-t V2 16/17] tests/kms_async_flips: " Bhanuprakash Modem
2023-08-02 10:20 ` [igt-dev] [i-g-t V2 17/17] tests/kms_prime: " Bhanuprakash Modem
2023-08-02 11:10 ` [igt-dev] ○ CI.xeBAT: info for Add XE suppor for display tests (rev2) Patchwork
2023-08-02 11:18 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-08-02 13:50 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230802102059.3650360-5-bhanuprakash.modem@intel.com \
    --to=bhanuprakash.modem@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox