From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9195410E0B8 for ; Tue, 8 Aug 2023 04:51:12 +0000 (UTC) From: Ankit Nautiyal To: igt-dev@lists.freedesktop.org Date: Tue, 8 Aug 2023 10:17:47 +0530 Message-Id: <20230808044747.3274795-1-ankit.k.nautiyal@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [igt-dev] [PATCH i-g-t] tests/i915/kms_dsc_helper: Fix helper to check dsc with output_format List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: Fix the condition that checks for DSC support by platform and the sink in the helper is_dsc_output_format_supported. v2: -Fix commit message (Swati). -Add closes tag. (Swati). -Add debug message only for sink check (Ankit). Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/9062 Fixes: c365922f01c12 (tests/i915/kms_dsc: Enable validation for VDSC output formats) Cc: Swati Sharma Cc: Jouni H_gander Signed-off-by: Ankit Nautiyal Reviewed-by: Jouni Högander Tested-by: Swati Sharma --- tests/i915/kms_dsc_helper.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/tests/i915/kms_dsc_helper.c b/tests/i915/kms_dsc_helper.c index ae59edb6bec9..df999c9bde62 100644 --- a/tests/i915/kms_dsc_helper.c +++ b/tests/i915/kms_dsc_helper.c @@ -133,13 +133,14 @@ static bool is_dsc_output_format_supported_by_platform(int disp_ver, enum dsc_ou bool is_dsc_output_format_supported(int drmfd, int disp_ver, igt_output_t *output, enum dsc_output_format output_format) { - if (!(igt_is_dsc_output_format_supported_by_sink(drmfd, output->name, output_format)) && - (is_dsc_output_format_supported_by_platform(disp_ver, output_format))) { - igt_debug("DSC %s output format not supported on connector %s\n", - kmstest_dsc_output_format_str(output_format), - output->name); - return false; - } + if (!is_dsc_output_format_supported_by_platform(disp_ver, output_format)) + return false; + + if (!igt_is_dsc_output_format_supported_by_sink(drmfd, output->name, output_format)) { + igt_debug("DSC %s output format not supported on connector %s\n", + kmstest_dsc_output_format_str(output_format), output->name); + return false; + } return true; } -- 2.40.1